From: Ferruh Yigit <ferruh.yigit@intel.com>
To: "Wei Hu (Xavier)" <xavier.huwei@huawei.com>,
luyicai <luyicai@huawei.com>,
dev@dpdk.org, Thomas Monjalon <thomas@monjalon.net>
Cc: chas3@att.com, zhangliang@bigo.sg, chenchanghu@huawei.com,
jerry.lilijun@huawei.com, haifeng.lin@huawei.com,
guohongzhi1@huawei.com, stable@dpdk.org
Subject: Re: [dpdk-dev] [PATCH V2] net/bonding: fix lacp negotiation failed
Date: Sat, 11 Jul 2020 04:07:16 +0100 [thread overview]
Message-ID: <1e87e908-d5fe-89b1-2b6b-310424fe0408@intel.com> (raw)
In-Reply-To: <9fc7792c-690d-8745-57d8-7235c48cad8f@huawei.com>
On 7/11/2020 2:20 AM, Wei Hu (Xavier) wrote:
>
> On 2020/7/10 11:29, luyicai wrote:
>> From: Yicai Lu <luyicai@huawei.com>
>>
>> When two host is connected directly without any devices like switch,
>> rx_machine_update would recieving partner lacp negotiation packets,
>> and partner's port mac is filled with zeros in this packet,
>> which is different with internal's mode4 mac. So in this situation,
>> it would never go rx_machine branch and then execute mac swap for negotiation!
>> Thus bond mode 4 will negotiation failed.
>>
>> Fixes: 56cbc0817399 ("net/bonding: fix LACP negotiation")
>> Cc: stable@dpdk.org
>>
>> Signed-off-by: luyicai <luyicai@huawei.com>
>
> Reviewed-by: Wei Hu (Xavier) <xavier.huwei@huawei.com>
>
Applied to dpdk-next-net/master, thanks.
next prev parent reply other threads:[~2020-07-11 3:07 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1589887092-26360-1>
2020-07-10 3:29 ` luyicai
2020-07-11 1:20 ` Wei Hu (Xavier)
2020-07-11 3:07 ` Ferruh Yigit [this message]
2019-03-21 10:22 [dpdk-dev] [PATCH v2] " Liang Zhang
2019-03-21 10:22 ` Liang Zhang
2019-03-21 19:34 ` Ferruh Yigit
2019-03-21 19:34 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1e87e908-d5fe-89b1-2b6b-310424fe0408@intel.com \
--to=ferruh.yigit@intel.com \
--cc=chas3@att.com \
--cc=chenchanghu@huawei.com \
--cc=dev@dpdk.org \
--cc=guohongzhi1@huawei.com \
--cc=haifeng.lin@huawei.com \
--cc=jerry.lilijun@huawei.com \
--cc=luyicai@huawei.com \
--cc=stable@dpdk.org \
--cc=thomas@monjalon.net \
--cc=xavier.huwei@huawei.com \
--cc=zhangliang@bigo.sg \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).