From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 554DE1B29B for ; Fri, 20 Oct 2017 21:04:37 +0200 (CEST) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 20 Oct 2017 12:04:34 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.43,408,1503385200"; d="scan'208";a="912025369" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.241.224.220]) ([10.241.224.220]) by FMSMGA003.fm.intel.com with ESMTP; 20 Oct 2017 12:04:33 -0700 To: Roger B Melton , wenzhuo.lu@intel.com Cc: dev@dpdk.org, Bruce Richardson , "Ananyev, Konstantin" References: <20171012172435.34700-1-rmelton@cisco.com> From: Ferruh Yigit Message-ID: <1e8e5766-6c52-d09d-d7ac-11492b946c90@intel.com> Date: Fri, 20 Oct 2017 12:04:32 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <20171012172435.34700-1-rmelton@cisco.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v2] net/e1000: correct VLAN tag byte order for i35x LB packets X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 20 Oct 2017 19:04:38 -0000 On 10/12/2017 10:24 AM, Roger B Melton wrote: > When copying VLAN tags from the RX descriptor to the vlan_tci field > in the mbuf header, igb_rxtx.c:eth_igb_recv_pkts() and > eth_igb_recv_scattered_pkts() both assume that the VLAN tag is always > little endian. While i350, i354 and /i350vf VLAN non-loopback > packets are stored little endian, VLAN tags in loopback packets for > those devices are big endian. > > For i350, i354 and i350vf VLAN loopback packets, swap the tag when > copying from the RX descriptor to the mbuf header. This will ensure > that the mbuf vlan_tci is always little endian. > > Signed-off-by: Roger B Melton <...> > @@ -946,9 +954,16 @@ eth_igb_recv_pkts(void *rx_queue, struct rte_mbuf **rx_pkts, > > rxm->hash.rss = rxd.wb.lower.hi_dword.rss; > hlen_type_rss = rte_le_to_cpu_32(rxd.wb.lower.lo_dword.data); > - /* Only valid if PKT_RX_VLAN_PKT set in pkt_flags */ > - rxm->vlan_tci = rte_le_to_cpu_16(rxd.wb.upper.vlan); > - > + /* > + * The vlan_tci field is only valid when PKT_RX_VLAN_PKT is > + * set in the pkt_flags field and must be in CPU byte order. > + */ > + if ((staterr & rte_cpu_to_le_32(E1000_RXDEXT_STATERR_LB)) && > + (rxq->flags & IGB_RXQ_FLAG_LB_BSWAP_VLAN)) { This is adding more condition checks into Rx path. What is the performance cost of this addition? > + rxm->vlan_tci = rte_be_to_cpu_16(rxd.wb.upper.vlan); > + } else { > + rxm->vlan_tci = rte_le_to_cpu_16(rxd.wb.upper.vlan); > + } > pkt_flags = rx_desc_hlen_type_rss_to_pkt_flags(rxq, hlen_type_rss); > pkt_flags = pkt_flags | rx_desc_status_to_pkt_flags(staterr); > pkt_flags = pkt_flags | rx_desc_error_to_pkt_flags(staterr); <...>