From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B150FA0547; Tue, 31 May 2022 15:40:40 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9FDF44067B; Tue, 31 May 2022 15:40:40 +0200 (CEST) Received: from shelob.oktetlabs.ru (shelob.oktetlabs.ru [91.220.146.113]) by mails.dpdk.org (Postfix) with ESMTP id 95E2E40143 for ; Tue, 31 May 2022 15:40:39 +0200 (CEST) Received: from [192.168.1.38] (unknown [188.170.81.145]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by shelob.oktetlabs.ru (Postfix) with ESMTPSA id C278586; Tue, 31 May 2022 16:40:38 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 shelob.oktetlabs.ru C278586 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=oktetlabs.ru; s=default; t=1654004438; bh=NekGrTdT0Hw8VFoHZomToSFPG4865pVJXa9LQuTCqas=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=oNikJX8oIYR0ObUVdNU/UOg5H8LbVqxfumeQRCBOerkffe+saEWjbKvxu9U2F1xgn MM83tK7+UQooENo7sxJ+l5E5UXtpWIoLeLWjV0pP/gxtYEK8vAyqK3X7DlsSEiAR0B gUykhApv04FBcvCBR8xTdAUhbBLJZrn7gR7lYuPU= Message-ID: <1e995559-b436-7db7-cf15-9cad536c4390@oktetlabs.ru> Date: Tue, 31 May 2022 16:40:37 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH v6 0/9] net/vmxnet3: support versions 5 and 6 Content-Language: en-US To: Pankaj Gupta , jbehrens@vmware.com Cc: dev@dpdk.org References: <20220525004028.24938-1-pagupta@vmware.com> From: Andrew Rybchenko In-Reply-To: <20220525004028.24938-1-pagupta@vmware.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 5/25/22 03:40, Pankaj Gupta wrote: > v6 (Andrew Rybchenko): > Minor style changes in patches description > Split FW version get patch to have callbacks reorder seperately > Minor fix in FW version get patch to put callback definition, > assignment and implementation just after device info get > > v5: > Use RTE_MIN instead of defining MIN in drivers/net/vmxnet3/vmxnet3_ethdev.c > User RETA instead of reta in commit message > Fix the issue thrown by checkpatches.sh in file drivers/net/vmxnet3/vmxnet3_ethdev.c > > v4: > Changing the subject for [Patch 8/8] from "net/vmxnet3: fix merge error > in initialization for rxDataRing feature" to > "Fixes: 046f11619567 ("net/vmxnet3: support MSI-X interrupt")" > > v3: > adding Reviewed-by info in all the patches > > v2: > address review comments from Andrew Rybchenko andrew.rybchenko@oktetlabs.ru > > Pankaj Gupta (9): > net/vmxnet3: add version 5 support > net/vmxnet3: implement RETA query and RETA update > net/vmxnet3: add Rx queue usage count utility > net/vmxnet3: fix ethdev callbacks init order > net/vmxnet3: report HW version on FW version get > net/vmxnet3: add version 6 support > net/vmxnet3: advertise RETA size in device info > net/vmxnet3: set packet type for fragmented packet > net/vmxnet3: fix merge error in Rx data ring initialization > > doc/guides/rel_notes/release_21_08.rst | 12 + > drivers/net/vmxnet3/base/vmxnet3_defs.h | 73 ++++- > drivers/net/vmxnet3/vmxnet3_ethdev.c | 339 +++++++++++++++++++----- > drivers/net/vmxnet3/vmxnet3_ethdev.h | 15 +- > drivers/net/vmxnet3/vmxnet3_rxtx.c | 49 +++- > 5 files changed, 400 insertions(+), 88 deletions(-) > Applied, thanks. Please, double-check patches descriptor and release notes.