Re: [dpdk-dev] [PATCH 00/11] Support flow API in Solarflare PMD

[Andrew Rybchenko <arybchenko@solarflare.com>]

On 03/07/2017 04:27 PM, Ferruh Yigit wrote:
> On 3/2/2017 4:03 PM, Andrew Rybchenko wrote:
>> Support simple queue destination flow API filters in Solarflare
>> libefx-based PMD including:
>>   - Ethernet source/destination, EtherType exact matching
>>   - VLAN ID exact matching including double-tagging
>>   - IPv4/6 source/destination and IP protocol exact matching
>>   - TCP/UDP source/destination exact matching
>>
>> Supported combinations of fields mentioned above depend on
>> firmware (including running variant) and correctly processed by
>> validate callback.
>>
>>
>> Andrew Rybchenko (2):
>>    net/sfc: implement dummy filter control callback
>>    net/sfc: provide a way to check if filter is supported
>>
>> Mark Spender (2):
>>    net/sfc/base: split local MAC I/G back into separate flags
>>    net/sfc/base: improve API to get supported filter matches
>>
>> Roman Zhukov (7):
>>    net/sfc: add flow API filters support
>>    net/sfc: add VLAN in flow API filters support
>>    net/sfc: add IPV4 in flow API filters support
>>    net/sfc: add IPV6 in flow API filters support
>>    net/sfc: add TCP in flow API filters support
>>    net/sfc: add UDP in flow API filters support
>>    net/sfc: add unknown unicast/multicast match in flow API
> Hi Andrew,
>
> Patchset looks good overall, I just did some really minor comments, can
> you please address them in next version of the patchset?

Hi Ferruh,

thanks for the review. We'll address the review notes in v2.

> Also can you please update release notes, to announce "SFC rte_flow
> support" ?

Will do. I remember about roadmap, but I'm always forgetting about 
release notes.

Thanks,
Andrew.