From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from nbfkord-smmo01.seg.att.com (nbfkord-smmo01.seg.att.com [209.65.160.76]) by dpdk.org (Postfix) with ESMTP id 5576E108A for ; Tue, 7 Mar 2017 15:57:05 +0100 (CET) Received: from unknown [193.34.186.16] (EHLO webmail.solarflare.com) by nbfkord-smmo01.seg.att.com(mxl_mta-7.2.4-7) with ESMTP id 14aceb85.2b94e160e940.1066831.00-2471.3064624.nbfkord-smmo01.seg.att.com (envelope-from ); Tue, 07 Mar 2017 14:57:05 +0000 (UTC) X-MXL-Hash: 58beca414c2e2219-12ba3657123e2c750903f789099de7065a2177ec Received: from unknown [193.34.186.16] (EHLO webmail.solarflare.com) by nbfkord-smmo01.seg.att.com(mxl_mta-7.2.4-7) over TLS secured channel with ESMTP id 63aceb85.0.1066821.00-2386.3064599.nbfkord-smmo01.seg.att.com (envelope-from ); Tue, 07 Mar 2017 14:56:55 +0000 (UTC) X-MXL-Hash: 58beca370f6d84d2-7a698ed7b16db48fbf545bd4b51b44dab7b663dc Received: from [192.168.38.17] (84.52.89.52) by ukex01.SolarFlarecom.com (10.17.10.4) with Microsoft SMTP Server (TLS) id 15.0.1044.25; Tue, 7 Mar 2017 14:56:48 +0000 To: Ferruh Yigit , References: <1488470591-5853-1-git-send-email-arybchenko@solarflare.com> From: Andrew Rybchenko Message-ID: <1ec06a0a-c320-ea3d-0de9-00117f72e484@solarflare.com> Date: Tue, 7 Mar 2017 17:56:43 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.1 MIME-Version: 1.0 In-Reply-To: X-Originating-IP: [84.52.89.52] X-ClientProxiedBy: ocex03.SolarFlarecom.com (10.20.40.36) To ukex01.SolarFlarecom.com (10.17.10.4) X-TM-AS-Product-Ver: SMEX-11.0.0.1191-8.100.1062-22926.003 X-TM-AS-Result: No--18.573300-0.000000-31 X-TM-AS-User-Approved-Sender: Yes X-TM-AS-User-Blocked-Sender: No X-AnalysisOut: [v=2.1 cv=LaQ6n2ri c=1 sm=1 tr=0 a=8P+NB+fYZDP74ap4g4d9Kw==] X-AnalysisOut: [:17 a=RB3BGLmKESwA:10 a=6Iz7jQTuP9IA:10 a=Cwnjr7Ri7eNI49pd] X-AnalysisOut: [N6UA:9 a=ZDaZaNRFo6itdwnh:21 a=OkQfgtj3H_Z7txIj:21 a=pILNO] X-AnalysisOut: [xqGKmIA:10 a=QyXUC8HyAAAA:8 a=pBD-UmMaPJ2aqE0g1KYA:9 a=QpH] X-AnalysisOut: [9CNPiGQF7EOrF:21 a=_W_S_7VecoQA:10 a=avl4LiGQNoF5OB0DmCJ7:] X-AnalysisOut: [22] X-Spam: [F=0.2000000000; CM=0.500; S=0.200(2015072901)] X-MAIL-FROM: X-SOURCE-IP: [193.34.186.16] Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH 00/11] Support flow API in Solarflare PMD X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 07 Mar 2017 14:57:05 -0000 On 03/07/2017 04:27 PM, Ferruh Yigit wrote: > On 3/2/2017 4:03 PM, Andrew Rybchenko wrote: >> Support simple queue destination flow API filters in Solarflare >> libefx-based PMD including: >> - Ethernet source/destination, EtherType exact matching >> - VLAN ID exact matching including double-tagging >> - IPv4/6 source/destination and IP protocol exact matching >> - TCP/UDP source/destination exact matching >> >> Supported combinations of fields mentioned above depend on >> firmware (including running variant) and correctly processed by >> validate callback. >> >> >> Andrew Rybchenko (2): >> net/sfc: implement dummy filter control callback >> net/sfc: provide a way to check if filter is supported >> >> Mark Spender (2): >> net/sfc/base: split local MAC I/G back into separate flags >> net/sfc/base: improve API to get supported filter matches >> >> Roman Zhukov (7): >> net/sfc: add flow API filters support >> net/sfc: add VLAN in flow API filters support >> net/sfc: add IPV4 in flow API filters support >> net/sfc: add IPV6 in flow API filters support >> net/sfc: add TCP in flow API filters support >> net/sfc: add UDP in flow API filters support >> net/sfc: add unknown unicast/multicast match in flow API > Hi Andrew, > > Patchset looks good overall, I just did some really minor comments, can > you please address them in next version of the patchset? Hi Ferruh, thanks for the review. We'll address the review notes in v2. > Also can you please update release notes, to announce "SFC rte_flow > support" ? Will do. I remember about roadmap, but I'm always forgetting about release notes. Thanks, Andrew.