From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3DF9843305; Mon, 20 Nov 2023 11:48:17 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2C41442DDE; Mon, 20 Nov 2023 11:48:17 +0100 (CET) Received: from NAM02-DM3-obe.outbound.protection.outlook.com (mail-dm3nam02on2047.outbound.protection.outlook.com [40.107.95.47]) by mails.dpdk.org (Postfix) with ESMTP id BCB9B4021D; Mon, 20 Nov 2023 11:48:15 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=L5vHMWZOtbEOcxgJzgZvfcDMlE2OmWSQ7xYYUou+gg7KaiOLAQ+dssf2mJrBNxSnwozE6GJjmuFHD6o7cJ2W56kFhaf2SpG4RmUHnyre0Qn1uiBzCBW/IEHj1MKcGpbALsVPgQPma8Eb+mxl18KdDqx+aRbdKyysQiOQgTPE+oeuplGjR4zVzTRjVbBPGZsUlXRhu6kdFs6Ztq5CUw1NfwWOWDoPlCsq4ewNvIEs5BhvTzT5QiJw4VU10+voQF0r9gsqtOE0BURWIDvCACBvHnzNqiq6M+wyZux3Zse3H0DWRD7vqjBmJ5pOd+O8/NAmjcS4HLhL/RYSjl5nZ6qu1Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=skd5v5l0AppGO9f0kOJ1nwQrcjq73qb1x2yiTt7DSjQ=; b=RKDsuvUb5ZIzwjc8lej85Z+F0ERJnq3eCtaFWEFju3qP7MKar6H3J+v3HC42n3IKQQRK4Xnkk2B1VjSMOnHa41pPowz2MokGroCsbuysmR1XLxYu7AhxpoPRBfvQsNgDSZ8xqXiJvGFAQ59U8ObwgdDRQ3g+BWe6LmB7htMfOJTdciowcxicavVsiJEX/URvAMFvrbonmNlFPDoGK3Fo2Oe/zaugYzrXOfnZvQQTkp15+eLrholh7ocZmrqOINBcOgMQhX1s7/7OXNMPewgnub3CyXc8ODvVUBPCq/1pmqs/OTyi+in+OkyVJUqPW3yXH+qNtp81iwJFble/bM0uUg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=skd5v5l0AppGO9f0kOJ1nwQrcjq73qb1x2yiTt7DSjQ=; b=isrvaLYDvcVqvIn8RRj3tYyuUoBzoxWH2QeeZWxKr6M7N/Au6XSAtpImGNu/nbW4ISarbIjWG688GGdsLD0qo57OJSW5YjNZF1eSMQxjLeQ8hdHpPMUqwlEZbi3L7GbJ0rB/k0cZLiHVWnAU0tBMXhLyS7V6wTPkFeMBcp10e+k= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by DM4PR12MB5391.namprd12.prod.outlook.com (2603:10b6:5:39a::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7002.27; Mon, 20 Nov 2023 10:48:14 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::2569:edb2:670f:816f]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::2569:edb2:670f:816f%6]) with mapi id 15.20.7002.027; Mon, 20 Nov 2023 10:48:13 +0000 Message-ID: <1efe72a8-4c36-4dd2-a1a6-f6174bac178a@amd.com> Date: Mon, 20 Nov 2023 10:47:36 +0000 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] app/test-pmd: fix L4 checksum with padding data Content-Language: en-US To: Stephen Hemminger Cc: Kaiwen Deng , dev@dpdk.org, stable@dpdk.org, qiming.yang@intel.com, yidingx.zhou@intel.com, Aman Singh , Yuying Zhang , Olivier Matz , Pablo de Lara References: <20230804082849.533059-1-kaiwenx.deng@intel.com> <892f0567-e1ee-4283-9726-5db1dd92c2cb@amd.com> <20231116145817.78eb0954@hermes.local> <7a41467c-c863-4ea1-bf7c-9206bf56aa34@amd.com> <20231116192857.0d49ec5b@hermes.local> <1effba02-7a4c-47bd-8097-a158832c45d7@amd.com> <20231117082210.4d290191@hermes.local> From: Ferruh Yigit Autocrypt: addr=ferruh.yigit@amd.com; keydata= xsFNBGJDD3EBEAC/M7Tk/DfQSmP1K96vyzdhfSBzlCaGtcxNXorq4fALruqVsD3oi0yfyEz9 4YN8x7py0o9EL8ZdpOX0skc0AMCDAaw033uWhCn0GLMeGRKUbfOAPvL6ecSDvGD7CJIO9j0J eZUvasBgPdM/435PEr9DmC6Ggzdzt8IuG4PoLi5jpFSfcqxZFCCxLUDEo/w0nuguk2FTuYJg B2zEZ4JTBZrw7hIHiFh8D8hr6YA6a5uTofq1tr+l048lbtdFUl8TR0aIExVzE4Z8qKZlcE+9 RQaewjK5Al1jLE4sHdmd3GN+IvgDF3D/fLsi25SKJDeGSdeHkOmaX0qGeM4WKIfU6iARRCiQ N3AmBIxZ/A7UXBKLaOyZ+/i3sE6Wb53nrO4i8+0K2Qwyh6LjTeiJAIjYKN43ppxz3DaI+QwQ vI+uyHr4Gg0Da9EPPz/YyKauSeOZCfCB5gIfICO0j6x0SCl8uQ2nLpjxcZkf0gjcwUzP3h+S 3x6NfDji9YEij0zczW/dcSpGgZ6vsFpPrtnP9ZXy6J53yp0kJtOJoOlkEFFdU2yCZnCDseum CoudmGLZVvS0/DzHDJejq+3kK3FDGktZBOxZIIpal+nFqS7lVgOZc4+huVv3jyhzoAUOEyXA XK5j6o7g8STUY+z33QNnHpdLvecMwuzmvqy0jR54yAbZ64mB9QARAQABzSNGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBhbWQuY29tPsLBlwQTAQgAQQIbAwULCQgHAgYVCgkICwIEFgID AQIeAQIXgAIZARYhBEm7aYjps5XGsPHCElRTPtCKKm/6BQJkdyEEBQkE3meNAAoJEFRTPtCK Km/6UdcP/0/kEp49aIUhkRnQfmKmNVpcBEs4NqceNCWTQlaXdEwL1lxf1L49dsF5Jz1yvWi3 tMtq0Mk1o68mQ7q8iZAzIeLxGQAlievMNE0BzLWPFmuX+ac98ITBqKdnUAn6ig5ezR+jxrAU 58utUszDl16eMabtCu76sINL5izB8zCWcDEUB4UqM8iBSQZ7/a7TSBVS0jVBldAORg1qfFIs cGMPQn/skhy3QqbK3u3Rhc44zRxvzrQJmhY6T1rpeniHSyGOeIYqjpbpnMU5n1VWzQ4NXvAD VDkZ4NDw6CpvF4S2h2Ds7w7GKvT6RRTddrl672IaLcaWRiqBNCPm+eKh4q5/XkOXTgUqYBVg Ors8uS9EbQC/SAcp9VHF9fB+3nadxZm4CLPe5ZDJnSmgu/ea7xjWQYR8ouo2THxqNZtkercc GOxGFxIaLcJIR/XChh9d0LKgc1FfVARTMW8UrPgINVEmVSFmAVSgVfsWIV+NSpG9/e90E4SV gMLPABn1YpJ8ca/IwqovctqDDXfxZOvCPOVWTzQe/ut767W+ctGR1kRkxWcz470SycOcY+PW VRPJd91Af0GdLFkwzZgNzkd6Gyc9XXcv4lwwqBLhWrBhqPYB0aZXIG1E/cVTiRp4dWpFHAFD DcuLldjIw93lCDsIeEDM9rBizGVMWEoeFmqSe7pzGTPXzsFNBGJDD3EBEAC8fBFQHej8qgIG CBzoIEd1cZgPIARlIhRudODXoNDbwA+zJMKtOVwol3Hh1qJ2/yZP11nZsqrP4fyUvMxrwhDe WBWFVDbWHLnqXMnKuUU1vQMujbzgq/4Rb9wSMW5vBL6YxhZng+h71JgS/9nVtzyaTtsOTrJi 6nzFSDx6Wbza2jYvL9rlK0yxJcMEiKwZQ/if4KcOesD0rtxomU/iSEv6DATcJbGXP6T93nPl 90XksijRKAmOwvdu3A8IIlxiSSVRP0lxiHOeR35y6PjHY2usfEDZZOVOfDfhlCVAIBZUZALv VmFOVSTYXeKgYa6Ooaf72+cHM3SgJIbYnevJfFv8YQW0MEAJ/IXE7B1Lk+pHNxwU3VBCrKnA fd/PTvviesuYRkrRD6qqZnINeu3b2DouVGGt2fVcGA38BujCd3p8i7azoGc7A6cgF7z9ETnr ANrbg1/dJyDmkDxOxVrVquTBbxJbDy2HaIe9wyJTEK2Sznpy62DaHVY+gfDQzexBXM10geHC IIUhEnOUYVaq65X3ZDjyAQnNDBQ4uMqSHZk8DpJ22X+T+IMzWzWl+VyU4UZXjkLKPvlqPjJk 1RbKScek5L2GhxHQbPaD76Hx4Jiel0vm2G+4wei8Ay1+0YRFkhySxogU/uQVXHTv63KzQMak oIfnN/V2R0ucarsvMBW+gwARAQABwsF8BBgBCAAmAhsMFiEESbtpiOmzlcaw8cISVFM+0Ioq b/oFAmR3IPsFCQTeZ44ACgkQVFM+0Ioqb/qINhAAtcor9bevHy22HvJvXX17IOpPSklZJAeQ Az43ZEo5kRlJ8mElc2g3RzYCvL/V3fSiIATxIsLq/MDtYhO8AAvklxND/u2zeBd7BkRZTZZX W1V1cM3oTvfx3LOhDu4f2ExQzCGdkzbXTRswSJIe1W0qwsDp+YPekbrsKp1maZArGeu+6FuW honeosIrWS98QJmscEhP8ooyJkLDCCOgEk+mJ/JBjzcJGuYn6+Iy/ApMw/vqiLGL1UWekcTA g18mREHqIR+A3ZvypIufSFB52oIs1zD/uh/MgmL62bY/Cw6M2SxiVxLRsav9TNkF6ZaNQCgn GqifliCEMvEuLZRBOZSYH2A/PfwjYW0Ss0Gyfywmb2IA990gcQsXxuCLG7pAbWaeYazoYYEQ NYmWatZNMAs68ERI2zvrVxdJ/fBWAllIEd0uQ4P05GtAHPdTIDQYp545+TPV7oyF0LfXcsQs SFVZE6igdvkjfYmh+QOrHGZvpWXLTmffVf/AQ81wspzbfxJ7sYM4P8Mg5kKOsaoUdyA/2qVe cMh1CLUHXF1GlofpGbe1lj4KUJVse5g3qwV7i9VrseA8c4VIZewdIjkzAhmmbxl+8rM/LKBH dZUMTzME5PFCXJIZ83qkZQ795MTe2YScp9dIV7fsS5tpDwIs7BZNVM1l3NAdK+DLHqNxKuyO 8Zk= In-Reply-To: <20231117082210.4d290191@hermes.local> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR2P281CA0169.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:99::10) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|DM4PR12MB5391:EE_ X-MS-Office365-Filtering-Correlation-Id: d24cc414-e489-4c7b-fbb6-08dbe9b63217 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: CFx+6VWOYYh8ffEFmmmoI6pFqiQqF4gdTt2X5zsfgdgwZsXRoGmo0gXmfCGygl1VVFZ06k7D3sT18OR302udF9m+mue/UYyMdiE501s3GVFp1GqJKt3Heun4vF3JWJASrBNlSPnNu7G0rNynBryyHvQtXS0SNNO2Ux+etBk0dmtdSyIDFWyEmOlCDu+l26KDBwq8tfBToHp+ODF2f8JmlR90Ologc2Dst4gRuB0kIJw1+zm9M4jkOAuA0bEnGoR8CF6pITMp/sGOsIiqul/cVTiCziX996gQeiL7Ny0/CJxv30e71taIEk5ugALLfUESy3pnWXGIN/Urg6F60cqas/+JMrf0Wq4w87Ix0uuM0Vx3HlZ+AocZZb7ACwK8kvCmbvXRCQO16DyP6Z0eym9suKSNjW/vKQyJcqrHjmOWrd15C1u4NsYBR2fbCKEq6nUsiE5Aqv5+8O38icgzRs6sv5H07MJsaMC/BLQUB+FtneAhLpeMaVsB3foKK2+GlGUhu0YtwhcastsSeW2Jxdb1BdVh+OBDb8dKSPg1ldDMt1pGZIJU3JFQxhr6kpVZ+aTpWelviBBYqwKJhuGuiOKsMv/1PWxumINkiMjEKilicnVgXBkw/NoAQK+0JqvA6VnbjxdpyhHlU8Le4S+Ot1giLg== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(136003)(376002)(39860400002)(346002)(366004)(396003)(230922051799003)(64100799003)(451199024)(1800799012)(186009)(4744005)(2906002)(4326008)(8676002)(8936002)(86362001)(31696002)(7416002)(5660300002)(44832011)(41300700001)(36756003)(26005)(53546011)(6512007)(6506007)(2616005)(38100700002)(31686004)(316002)(66476007)(54906003)(66556008)(6916009)(66946007)(478600001)(6666004)(6486002)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?c1Z0ZHhhRmFLMWVHUGNaYzl1WkZZNko2UjRxclBEOWpCcSttbnN4U3RvdVhj?= =?utf-8?B?WnF6TU02WXF2Tmh2c0NBOTRWeEdndmhwYlh3cGd5bEpOSzR2WE44b0N2NGlY?= =?utf-8?B?UUROUkVhKzMvc0tXSFd3VnFhUmkwcDhRRzNmZ3lHWUd4NlBUUjY3OVFTMGQ3?= =?utf-8?B?d1lWSW0vV3VFSGNaKy9sVEJVdCtRa2gwM0huQlc3U1VBeU5YWUM0UkpoaExV?= =?utf-8?B?dm14b0xjaXBKRmRzSnAyaXVaMUMwSGRXSzFPMkZoMDJiczFYeXl2TmZ0MnJp?= =?utf-8?B?b0ZjRjhGVjFZWk9WUEpHNU9STUYrSjZaL0Y4RkhTQ090S0FJaUgrZ2Y2NmRD?= =?utf-8?B?d2Jxa1ppUkg0cEtDaExCK0pKMnZCU2lTM3B5bmE5aXl2MWRzQjJtZVVHR201?= =?utf-8?B?eno5czRqekRvUXlzeXJNVXErd1Y0cHRNMXByb1hXaDcvVmhpRkJZMlRlR0Rs?= =?utf-8?B?aFZXeGtRdzZ2KzV6MkhTblUzTjBOWWc3NjdrdEFHTUs1cEFlL1QrYThmblYy?= =?utf-8?B?TWhQYXZuWEhWWEg1c2xNUlFHWnMwNFhkeVROMXloSHFFa25jK0VFVEN4SkE5?= =?utf-8?B?RFNJOTJVU0ROZUdHZlcybjk5U2pnQXBYdUVDY0pOa1pWbFowNmwvTGJ2RDFP?= =?utf-8?B?OFZBeHR2b1V3VHRqejFrN2wzTXYrSWhaWXl2N25jZ1FjaVNoTWIxUkVGc1JD?= =?utf-8?B?RVRJa1Q5aVVlR2p4R0dlZTh2L1ovWjIyUEdBNThQSjRTNTRMTjBsOVl2a2ZJ?= =?utf-8?B?WWlISFQwVUZVTTMyOFMvMW5CemdhMG9LR295WlZxUlA4WGdPdVNiY2hmVElh?= =?utf-8?B?T3lWbmlOdFlGTlZsRnVCWHdyQ0Fpc0ZRVDZvWWtGRkpOc2RDYVR2M3FZcjdC?= =?utf-8?B?U21pR1hVeGw0WHUvcGpZM0hkNkVZNE9yNHFKeEgwdWcxdHlPblQ0VGpZOWo0?= =?utf-8?B?b2tLdDQreUlvYThtbUpaZ2dyZFBINHJoT0Nzd2g0MjYreDJCdmVyd3lXUmEx?= =?utf-8?B?dWI3VnRuVStIRjVWQWRxUkIwVWhQb21mK3N3SGVOTkwvb1RnQjcya2ZlYTdS?= =?utf-8?B?eGcyNmgwWHA3eHREVjIyUm93OGZ3dXB5bzBvZHcvNU9leWsvb0JoTHRTU0tR?= =?utf-8?B?eEFZdWhGMjUxRGNNeHZtUXFsUmRaQVREd3RtQXFKYXZTZGpSbHVJQnZ5bVhN?= =?utf-8?B?emZacVZEaEIyZFUyV2RVd1Vpem1WbWJrUGtyeElGVUwvVnYwelZhUGo3YXpl?= =?utf-8?B?UTdXQUdEb3pad29rdXVVb2tWaFBzamN5OVQ4T0lGWURibnNqT2xoS3A1ZCtv?= =?utf-8?B?QUpSUnN0cEJPblltR3BJMi9nNXpxc3dJUU55T2RPM3NsTVpxSHkwOVhnT1BW?= =?utf-8?B?a2xNNk9tQm9mbndNK2NobE5OVWdlemVYbm9aeWZiYkdNNkdIQkc1NlFHMUtt?= =?utf-8?B?RDVaK0UrbVNUeW85UEUvbFdqTlpsL2tSMWt4bWMxcFVTbFJJUERmdFluVUJl?= =?utf-8?B?b1lVNC82bTVvbjB5V2Vkak45akJHc3JIWlZ2MWtyb0pjZ1U0YSszRkpTZDFY?= =?utf-8?B?NVZ4cG5QZnhYdENESzc4T1VlMTV4M044aTVJU3ZMWFFMeUtpVzU0M2pyaFJM?= =?utf-8?B?UUxOTUxldy9aNC90UGFIdnBZcll4a1hTVEtKN0o1bVQvV0g0djVEYlQ1eU9R?= =?utf-8?B?bHBiYUhQNVcyRVd1cnJwV0c0RElaek9IK0x2b2p1UWkvS3BzSC9KWWpZdzdt?= =?utf-8?B?UnZpVjkzYm1Kb2tyMmhsODR1TXFZd1R0cnoyNFlKNldpSW1iOGhSK1FNL2Nv?= =?utf-8?B?djgwRXllb013YXZPZ3lMN2JZUlJTNFp0eVRYeVpKbVhxL1Z5T0I2c0poMWhq?= =?utf-8?B?cFBuVjhaV0VDd1ZScnNqZTNkUDRpY2ttSWxiSXU1c1pMVlRsOWErNitLUHY1?= =?utf-8?B?Y0MrUUJ6QTJ5cVEwNHpjVi9EZjZ1TU1XWEo1VVJrWFVoU243V2c1K2F6OGZh?= =?utf-8?B?cUlPUVowOTdoeFlhcWlBUUloaDBSZjlNRnRENE1yeTlyNEVDbVM2anQ2TC9o?= =?utf-8?B?RDcxRDBkYzhDNEhnR2lQSFovUUhCZlhSTndmZ0g1VUpoamlJREhmZlZyZXZv?= =?utf-8?Q?vrlA=3D?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: d24cc414-e489-4c7b-fbb6-08dbe9b63217 X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Nov 2023 10:48:13.8825 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: wMvccZFdnaHeJimsxYAXbQoGqbM9mw7HXPc2/XmIIxemCvWWnouby3i9sJ9vnmkj X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB5391 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 11/17/2023 4:22 PM, Stephen Hemminger wrote: > On Fri, 17 Nov 2023 09:29:41 +0000 > Ferruh Yigit wrote: > >>>> I agree using 'l3_len' instead is correct fix. >>>> >>>> But this requires ABI/API change, >>>> plus do we have any reason to keep the padding, discarding it as this >>>> patch does is also simpler alternative. >>> >>> >>> Possibly an API version to change the args would work to fix. >>> >> >> rte_ipv4_udptcp_cksum_mbuf() and rte_ipv6_udptcp_cksum_mbuf() are inline >> functions, unfortunately we can't version them. >> >> But those functions already gets IP header as parameter, can't we use IP >> header to get the payload size? If so this can be fixed without updating >> API. > > Inlines are easier. Just make a fixed new function and make sure the old > one is not used. They shouldn't have been inline in the first place. > I guess inlines as because of performance concerns, since it is in datapath.