From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 097A2A0C47;
	Fri, 11 Jun 2021 11:19:03 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 776F54067C;
	Fri, 11 Jun 2021 11:19:03 +0200 (CEST)
Received: from shelob.oktetlabs.ru (shelob.oktetlabs.ru [91.220.146.113])
 by mails.dpdk.org (Postfix) with ESMTP id A7A1A4014F
 for <dev@dpdk.org>; Fri, 11 Jun 2021 11:19:01 +0200 (CEST)
Received: from [192.168.38.17] (aros.oktetlabs.ru [192.168.38.17])
 (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256)
 (No client certificate requested)
 by shelob.oktetlabs.ru (Postfix) with ESMTPSA id 177BF7F5F2;
 Fri, 11 Jun 2021 12:19:01 +0300 (MSK)
DKIM-Filter: OpenDKIM Filter v2.11.0 shelob.oktetlabs.ru 177BF7F5F2
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=oktetlabs.ru;
 s=default; t=1623403141;
 bh=fPT2Eg5tW+ihzEPHCnlkHTdDqVuaoPPcPQuM5hGiUF4=;
 h=Subject:To:Cc:References:From:Date:In-Reply-To;
 b=RgaOLOzkM0Lif1UVUV1FYlHNL+Qcyrz1oc6lo2vYIzFPQFJlm7VShvQFGPqd589+s
 NXoBcFDK0gxHPPiAyqOGEq57r32tJndxGw38QzDb3VhkiGJpu7mAcxU9su7HWBQbHO
 g5WRg/5VwhSLEe4J1p6uHJAUDcr+8WK0IUZgaUpk=
To: "Li, Xiaoyun" <xiaoyun.li@intel.com>, Ferruh Yigit <ferruh.yigit@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
References: <20210527162452.1568351-1-andrew.rybchenko@oktetlabs.ru>
 <CH0PR11MB5523420483262F73A7DE1D1099349@CH0PR11MB5523.namprd11.prod.outlook.com>
From: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
Organization: OKTET Labs
Message-ID: <1f419fbb-b951-1a84-3329-97701c32c956@oktetlabs.ru>
Date: Fri, 11 Jun 2021 12:19:00 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.10.0
MIME-Version: 1.0
In-Reply-To: <CH0PR11MB5523420483262F73A7DE1D1099349@CH0PR11MB5523.namprd11.prod.outlook.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Subject: Re: [dpdk-dev] [PATCH] app/testpmd: send failure logs to stderr
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 6/11/21 5:06 AM, Li, Xiaoyun wrote:
> Hi
> -----Original Message-----
> From: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru> 
> Sent: Friday, May 28, 2021 00:25
> To: Li, Xiaoyun <xiaoyun.li@intel.com>
> Cc: dev@dpdk.org
> Subject: [PATCH] app/testpmd: send failure logs to stderr
> 
> Running with stdout suppressed or redirected for further processing is very confusing in the case of errors.
> 
> Signed-off-by: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
> ---
> 
> This patch looks good to me.
> But what do you think about make it as a fix and backport to stable branches?
> Anyway works for me.

I have no strong opinion on the topic.

@Ferruh, what do you think?

> Acked-by: Xiaoyun Li <xiaoyun.li@intel.com>