Re: [dpdk-dev] [PATCH v5] net/virtio: set offload flag for jumbo frames

[Maxime Coquelin <maxime.coquelin@redhat.com>]

On 2/5/19 12:17 PM, Jens Freimann wrote:
> Port configuration fails because offload flags don't match the expected
> value when max-pkt-len is set to a value that should enable receive port
> offloading but doesn't.
> 
> The .dev_infos_get callback can be called before the configure callback.
> At that time we don't know the maximum packet size yet because it is
> only set up when ports are started. So in virtio_dev_info_get() just
> always set the jumbo packet offload flag.
> 
> Check the maximum packet length at device configure time, because then we
> have access to the max-pkt-len value provided by the user. If the
> max-pkt-len exceeds the maximum MTU supported by the device we remove
> the VIRTIO_NET_F_MTU flag from requested features.
> 
> Fixes: a4996bd89c42 ("ethdev: new Rx/Tx offloads API")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Jens Freimann <jfreimann@redhat.com>
> ---
>   drivers/net/virtio/virtio_ethdev.c | 6 ++++++
>   1 file changed, 6 insertions(+)

Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>

Thanks,
Maxime