From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2C492A04CC; Mon, 21 Sep 2020 14:48:12 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 75D2B1D9AC; Mon, 21 Sep 2020 14:48:11 +0200 (CEST) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id DBA121D9AA for ; Mon, 21 Sep 2020 14:48:09 +0200 (CEST) IronPort-SDR: FoYMZmjaTTxgNvEvMk6SxAryDk6f+wNr3Uc3OYgbg+DI0gOXPTl1TinaXWzy4RSyL8UTe8Abcr /3bzkf5xOX9w== X-IronPort-AV: E=McAfee;i="6000,8403,9750"; a="245202867" X-IronPort-AV: E=Sophos;i="5.77,286,1596524400"; d="scan'208";a="245202867" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Sep 2020 05:48:07 -0700 IronPort-SDR: zMAVodcvBOkdhVNRGk6AAagxXss861OHONu/7m0RvROJs5rYs56x85tDpRUtPzZDYIyPAHIJi7 Ro1QDAUm4Dyg== X-IronPort-AV: E=Sophos;i="5.77,286,1596524400"; d="scan'208";a="309018902" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.213.217.64]) ([10.213.217.64]) by orsmga006-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Sep 2020 05:48:00 -0700 To: i.dyukov@samsung.com, dev@dpdk.org, v.kuramshin@samsung.com, thomas@monjalon.net, david.marchand@redhat.com, arybchenko@solarflare.com, wei.zhao1@intel.com, jia.guo@intel.com, beilei.xing@intel.com, qiming.yang@intel.com, wenzhuo.lu@intel.com, mb@smartsharesystems.com, stephen@networkplumber.org, nicolas.chautru@intel.com, bruce.richardson@intel.com, konstantin.ananyev@intel.com, cristian.dumitrescu@intel.com, radu.nicolau@intel.com, akhil.goyal@nxp.com, declan.doherty@intel.com, skori@marvell.com, pbhagavatula@marvell.com, jerinj@marvell.com, kirankumark@marvell.com, david.hunt@intel.com, anatoly.burakov@intel.com, xiaoyun.li@intel.com, jingjing.wu@intel.com, john.mcnamara@intel.com, jasvinder.singh@intel.com, byron.marohn@intel.com, yipeng1.wang@intel.com References: <20200427095737.11082-1-i.dyukov@samsung.com> <20200915190728.18143-1-i.dyukov@samsung.com> <20200915190728.18143-8-i.dyukov@samsung.com> From: Ferruh Yigit Message-ID: <1f6cd1ec-1695-61a4-2f27-5fda30235d4e@intel.com> Date: Mon, 21 Sep 2020 13:47:57 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.2.2 MIME-Version: 1.0 In-Reply-To: <20200915190728.18143-8-i.dyukov@samsung.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH v11 07/24] examples: new link status print format X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 9/15/2020 8:07 PM, Ivan Dyukov wrote: > Add usage of rte_eth_link_to_str function to example > applications: > * ipv4_multicast > * l2fwd-jobstats > * l2fwd-keepalive > * l3fwd > * link_status_interrupt > > Signed-off-by: Ivan Dyukov <...> > diff --git a/examples/l3fwd/main.c b/examples/l3fwd/main.c > index 24ede4290..0aeae216a 100644 > --- a/examples/l3fwd/main.c > +++ b/examples/l3fwd/main.c > @@ -810,6 +810,7 @@ check_all_ports_link_status(uint32_t port_mask) > uint8_t count, all_ports_up, print_flag = 0; > struct rte_eth_link link; > int ret; > + char link_status_text[RTE_ETH_LINK_MAX_STR_LEN]; > > printf("\nChecking link status"); > fflush(stdout); > @@ -833,14 +834,10 @@ check_all_ports_link_status(uint32_t port_mask) > } > /* print link status if flag set */ > if (print_flag == 1) { > - if (link.link_status) > - printf( > - "Port%d Link Up. Speed %u Mbps -%s\n", > - portid, link.link_speed, > - (link.link_duplex == ETH_LINK_FULL_DUPLEX) ? > - ("full-duplex") : ("half-duplex")); > - else > - printf("Port %d Link Down\n", portid); > + rte_eth_link_to_str(link_status_text, > + sizeof(link_status_text), &link); > + printf("Port %d %s\n", portid, > + link_status_text); > continue; l3fwd/Makefile is missing "CFLAGS += -DALLOW_EXPERIMENTAL_API", although the meson file has it. Using this new experimental API is causing build error, will updating as following as part of this patch: +# Added for 'rte_eth_link_to_str()' +CFLAGS += -DALLOW_EXPERIMENTAL_API