From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by dpdk.org (Postfix) with ESMTP id 28FF6D592 for ; Tue, 17 Apr 2018 18:09:40 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 17 Apr 2018 09:09:39 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.48,464,1517904000"; d="scan'208";a="46890465" Received: from aburakov-mobl.ger.corp.intel.com (HELO [10.237.220.128]) ([10.237.220.128]) by fmsmga004.fm.intel.com with ESMTP; 17 Apr 2018 09:09:38 -0700 To: Thomas Monjalon Cc: dev@dpdk.org References: <2822934.JnSj6TxSKo@xps> From: "Burakov, Anatoly" Message-ID: <1f840947-c8ab-3fe1-4b00-3fd4a14e135b@intel.com> Date: Tue, 17 Apr 2018 17:09:37 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: <2822934.JnSj6TxSKo@xps> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH 00/10] Coverity fixes for EAL memory X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 17 Apr 2018 16:09:40 -0000 On 17-Apr-18 4:56 PM, Thomas Monjalon wrote: > 17/04/2018 17:50, Anatoly Burakov: >> This patchset fixes a host of coverity issues in memory subsystem >> introduced with recent DPDK memory hotplug patchset. >> >> Coverity issues fixed: >> - 272601 - leaking fd >> - 272560 - double close fd >> - 272568 - leaking fd >> - 272570 - leaking fd >> - 272589 - dereference before null check >> - 272602 - freeing wrong pointer >> - 272608 - expression does nothing >> - 272577 - negative return not handled >> - 272578 - negative return not handled >> - 272584 - use after free > > Looks like you should buy a Coverity license > to run it locally before submitting ;) > Well, in fairness, most of these issues (and similar issues submitted in another patchset) will not ever manifest themselves under normal circumstances, so it's not as bad as it perhaps might present itself. -- Thanks, Anatoly