* [dpdk-dev] [PATCH] vhost: invoke dev configuration after set vring call message
@ 2019-01-14 7:34 Xiaolong Ye
2019-01-17 8:34 ` Maxime Coquelin
2019-01-17 11:34 ` Maxime Coquelin
0 siblings, 2 replies; 3+ messages in thread
From: Xiaolong Ye @ 2019-01-14 7:34 UTC (permalink / raw)
To: dev, Maxime Coquelin, Tiwei Bie; +Cc: xiao.w.wang, Xiaolong Ye
As qemu will only send VHOST_USER_SET_VRING_ENABLE message for guest
enabled vrings (only first queue pair will be enabled at initialized
stage), this will cause trouble for multiqueue case, vDPA's dev_conf
callback will get no chance be invoked. Decouple the dev_conf callback from
VHOST_USER_SET_VRING_ENABLE solves this issue.
Signed-off-by: Xiaolong Ye <xiaolong.ye@intel.com>
---
lib/librte_vhost/vhost_user.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/librte_vhost/vhost_user.c b/lib/librte_vhost/vhost_user.c
index 8fec773d5..469e61e5a 100644
--- a/lib/librte_vhost/vhost_user.c
+++ b/lib/librte_vhost/vhost_user.c
@@ -2045,7 +2045,7 @@ vhost_user_msg_handler(int vid, int fd)
vdpa_dev = rte_vdpa_get_device(did);
if (vdpa_dev && virtio_is_ready(dev) &&
!(dev->flags & VIRTIO_DEV_VDPA_CONFIGURED) &&
- msg.request.master == VHOST_USER_SET_VRING_ENABLE) {
+ msg.request.master == VHOST_USER_SET_VRING_CALL) {
if (vdpa_dev->ops->dev_conf)
vdpa_dev->ops->dev_conf(dev->vid);
dev->flags |= VIRTIO_DEV_VDPA_CONFIGURED;
--
2.17.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] [PATCH] vhost: invoke dev configuration after set vring call message
2019-01-14 7:34 [dpdk-dev] [PATCH] vhost: invoke dev configuration after set vring call message Xiaolong Ye
@ 2019-01-17 8:34 ` Maxime Coquelin
2019-01-17 11:34 ` Maxime Coquelin
1 sibling, 0 replies; 3+ messages in thread
From: Maxime Coquelin @ 2019-01-17 8:34 UTC (permalink / raw)
To: Xiaolong Ye, dev, Tiwei Bie; +Cc: xiao.w.wang
On 1/14/19 8:34 AM, Xiaolong Ye wrote:
> As qemu will only send VHOST_USER_SET_VRING_ENABLE message for guest
> enabled vrings (only first queue pair will be enabled at initialized
> stage), this will cause trouble for multiqueue case, vDPA's dev_conf
> callback will get no chance be invoked. Decouple the dev_conf callback from
> VHOST_USER_SET_VRING_ENABLE solves this issue.
>
> Signed-off-by: Xiaolong Ye <xiaolong.ye@intel.com>
> ---
> lib/librte_vhost/vhost_user.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>
Thanks,
Maxime
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] [PATCH] vhost: invoke dev configuration after set vring call message
2019-01-14 7:34 [dpdk-dev] [PATCH] vhost: invoke dev configuration after set vring call message Xiaolong Ye
2019-01-17 8:34 ` Maxime Coquelin
@ 2019-01-17 11:34 ` Maxime Coquelin
1 sibling, 0 replies; 3+ messages in thread
From: Maxime Coquelin @ 2019-01-17 11:34 UTC (permalink / raw)
To: Xiaolong Ye, dev, Tiwei Bie; +Cc: xiao.w.wang
On 1/14/19 8:34 AM, Xiaolong Ye wrote:
> As qemu will only send VHOST_USER_SET_VRING_ENABLE message for guest
> enabled vrings (only first queue pair will be enabled at initialized
> stage), this will cause trouble for multiqueue case, vDPA's dev_conf
> callback will get no chance be invoked. Decouple the dev_conf callback from
> VHOST_USER_SET_VRING_ENABLE solves this issue.
>
> Signed-off-by: Xiaolong Ye <xiaolong.ye@intel.com>
> ---
> lib/librte_vhost/vhost_user.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
Applied to dpdk-next-virtio/master.
Thanks,
Maxime
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-01-17 11:34 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-01-14 7:34 [dpdk-dev] [PATCH] vhost: invoke dev configuration after set vring call message Xiaolong Ye
2019-01-17 8:34 ` Maxime Coquelin
2019-01-17 11:34 ` Maxime Coquelin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).