DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH 0/3] Coverity fixes for DPDK IPC
@ 2018-04-17 15:46 Anatoly Burakov
  2018-04-17 15:46 ` [dpdk-dev] [PATCH 1/3] ipc: use strlcpy where applicable Anatoly Burakov
                   ` (3 more replies)
  0 siblings, 4 replies; 6+ messages in thread
From: Anatoly Burakov @ 2018-04-17 15:46 UTC (permalink / raw)
  To: dev; +Cc: thomas

This patchset fixes a few Coverity issues introduced
when various parts of DPDK IPC were added, and explains
away other reported issues.

Coverity issues fixed:
- 272595 - return without mutex unlock
- 272609 - fd leak

Coverity issues intentionally not fixed:
- 260407 - strcpy into fixed size buffer
  - Both src and dst strings are fixed size, so this is false
    positive
  - Hopefully will be silenced by replacing strcpy with strlcpy
- 272565 - strcpy into fixed size buffer
  - Same as above
- 272582 - strcpy into fixed size buffer
  - Same as above
- 268321 - tainted string
  - Not an issue, we handle errors correctly
- 272593 - tainted string
  - Same as above
- 272604 - tainted string
  - Same as above
- 260410 - not checking return value of rte_thread_setname
  - We intentionally don't care if it fails
- 272583 - return without mutex unlock
  - Independently discovered and fixed [1]

[1] http://dpdk.org/dev/patchwork/patch/38042/

Anatoly Burakov (3):
  ipc: use strlcpy where applicable
  ipc: fix return without mutex unlock
  ipc: fix resource leak

 lib/librte_eal/common/eal_common_proc.c | 23 ++++++++++++-----------
 1 file changed, 12 insertions(+), 11 deletions(-)

-- 
2.7.4

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2018-04-23 20:34 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-04-17 15:46 [dpdk-dev] [PATCH 0/3] Coverity fixes for DPDK IPC Anatoly Burakov
2018-04-17 15:46 ` [dpdk-dev] [PATCH 1/3] ipc: use strlcpy where applicable Anatoly Burakov
2018-04-17 15:46 ` [dpdk-dev] [PATCH 2/3] ipc: fix return without mutex unlock Anatoly Burakov
2018-04-17 15:46 ` [dpdk-dev] [PATCH 3/3] ipc: fix resource leak Anatoly Burakov
2018-04-20 14:40 ` [dpdk-dev] [PATCH 0/3] Coverity fixes for DPDK IPC Tan, Jianfeng
2018-04-23 20:34   ` Thomas Monjalon

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).