From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 15C3143B01; Mon, 12 Feb 2024 16:07:14 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id F1458402D9; Mon, 12 Feb 2024 16:07:13 +0100 (CET) Received: from NAM12-BN8-obe.outbound.protection.outlook.com (mail-bn8nam12on2057.outbound.protection.outlook.com [40.107.237.57]) by mails.dpdk.org (Postfix) with ESMTP id 6EC7C402D0 for <dev@dpdk.org>; Mon, 12 Feb 2024 16:07:12 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=JOkbInaKUB9kuJny2ZO+agyTdAjJpy5QQKOfNBM6GO9RJCLQnx65K9b2VGcPfYhiLUMnNIy5QpoAY/9AcjMOlwesdynuF9l+AVr04ehCaoIM+4cRS1MTMVnVRvluQabqBpaBiYeMV7D1DwtbACuTEdDWTmUlg6moUOst6XscFpsSLIyk0KlymNpULyUyfO9K/Fi1DKezQS+CBfEjHd7lXyPQuhBJLp8ypPXayLRAtDniCw9hQtKi020pp68kldtae29VQwyUhLrV1uE+Ldbhm+CFdiqvnhXoCif1OuCDLcXtSnUBXgW3LPXvCvAK/HSQdr8lqDLBYE7Lj180R3A+mA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=vvENV4f0jACAypMQWlACv5ZjaoXhoEV2ZETm45KoEwQ=; b=BlM0creIioWvE9B57B3dAIIf1nLGz6RBJ3BACOu3ocS5i2Jq+dcjXFxTOE0euWOUOjyeBkaGbS+wpkOcT0cHIyhfQpmTI45PwSo87zQ1KBOfdQBGGxgEf0VuB0CFtMqwAG4qte5SHHNcD1WDDRxcjmLHP745odMHPPQ2AlfjgiYGRYtYQs8AVQQg6ODAaIWLGvhJu5HsV1gAVUR7D7jEnQA36d92Z3NBXv6KU4lKASBGRA0/fn/1dBXfI5jEdmtB2pyORNUccnoXrKBSLrH9RPuacHWDENETN0kwWnl5FHdEhx+n9+Iwd2FqbCaHI5iotKGATBY07odmm4+did9lvA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=vvENV4f0jACAypMQWlACv5ZjaoXhoEV2ZETm45KoEwQ=; b=i3Uk5a0iWJl2qDeRXgjY3F2EJirqkma2HmbNOMAizHjptkTO0Z4xxJnOXK2mluYkCxapSKYANynM+velxSBs5JHSr74kM4NXg+UtC0KR58dyxKP8TnvrWS6C16UsWfEALD7zHBhr3ZPhNynFGlPEFKg9j5nRmVx/hNhn/3+XOP0= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by CH0PR12MB5089.namprd12.prod.outlook.com (2603:10b6:610:bc::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7292.14; Mon, 12 Feb 2024 15:07:07 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::3ec7:6339:1c14:c529]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::3ec7:6339:1c14:c529%4]) with mapi id 15.20.7292.022; Mon, 12 Feb 2024 15:07:07 +0000 Message-ID: <1fb79b00-d6a7-4b0c-9dcd-193b2c6b9f0c@amd.com> Date: Mon, 12 Feb 2024 15:07:05 +0000 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5] ethdev: add template table resize API Content-Language: en-US To: "Etelson, Gregory" <getelson@nvidia.com> Cc: dev@dpdk.org, mkashani@nvidia.com, thomas@monjalon.net, Ori Kam <orika@nvidia.com>, Aman Singh <aman.deep.singh@intel.com>, Yuying Zhang <yuying.zhang@intel.com>, Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru> References: <20231217093205.321082-1-getelson@nvidia.com> <20240211093053.397469-1-getelson@nvidia.com> <7c5bcfe0-dd24-4ca8-acf1-62c6246458ad@amd.com> <b5c6cf79-c75d-d3ee-67ce-b52cdeb6f523@nvidia.com> From: Ferruh Yigit <ferruh.yigit@amd.com> Autocrypt: addr=ferruh.yigit@amd.com; keydata= xsFNBGJDD3EBEAC/M7Tk/DfQSmP1K96vyzdhfSBzlCaGtcxNXorq4fALruqVsD3oi0yfyEz9 4YN8x7py0o9EL8ZdpOX0skc0AMCDAaw033uWhCn0GLMeGRKUbfOAPvL6ecSDvGD7CJIO9j0J eZUvasBgPdM/435PEr9DmC6Ggzdzt8IuG4PoLi5jpFSfcqxZFCCxLUDEo/w0nuguk2FTuYJg B2zEZ4JTBZrw7hIHiFh8D8hr6YA6a5uTofq1tr+l048lbtdFUl8TR0aIExVzE4Z8qKZlcE+9 RQaewjK5Al1jLE4sHdmd3GN+IvgDF3D/fLsi25SKJDeGSdeHkOmaX0qGeM4WKIfU6iARRCiQ N3AmBIxZ/A7UXBKLaOyZ+/i3sE6Wb53nrO4i8+0K2Qwyh6LjTeiJAIjYKN43ppxz3DaI+QwQ vI+uyHr4Gg0Da9EPPz/YyKauSeOZCfCB5gIfICO0j6x0SCl8uQ2nLpjxcZkf0gjcwUzP3h+S 3x6NfDji9YEij0zczW/dcSpGgZ6vsFpPrtnP9ZXy6J53yp0kJtOJoOlkEFFdU2yCZnCDseum CoudmGLZVvS0/DzHDJejq+3kK3FDGktZBOxZIIpal+nFqS7lVgOZc4+huVv3jyhzoAUOEyXA XK5j6o7g8STUY+z33QNnHpdLvecMwuzmvqy0jR54yAbZ64mB9QARAQABzSNGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBhbWQuY29tPsLBlwQTAQgAQQIbAwULCQgHAgYVCgkICwIEFgID AQIeAQIXgAIZARYhBEm7aYjps5XGsPHCElRTPtCKKm/6BQJkdyEEBQkE3meNAAoJEFRTPtCK Km/6UdcP/0/kEp49aIUhkRnQfmKmNVpcBEs4NqceNCWTQlaXdEwL1lxf1L49dsF5Jz1yvWi3 tMtq0Mk1o68mQ7q8iZAzIeLxGQAlievMNE0BzLWPFmuX+ac98ITBqKdnUAn6ig5ezR+jxrAU 58utUszDl16eMabtCu76sINL5izB8zCWcDEUB4UqM8iBSQZ7/a7TSBVS0jVBldAORg1qfFIs cGMPQn/skhy3QqbK3u3Rhc44zRxvzrQJmhY6T1rpeniHSyGOeIYqjpbpnMU5n1VWzQ4NXvAD VDkZ4NDw6CpvF4S2h2Ds7w7GKvT6RRTddrl672IaLcaWRiqBNCPm+eKh4q5/XkOXTgUqYBVg Ors8uS9EbQC/SAcp9VHF9fB+3nadxZm4CLPe5ZDJnSmgu/ea7xjWQYR8ouo2THxqNZtkercc GOxGFxIaLcJIR/XChh9d0LKgc1FfVARTMW8UrPgINVEmVSFmAVSgVfsWIV+NSpG9/e90E4SV gMLPABn1YpJ8ca/IwqovctqDDXfxZOvCPOVWTzQe/ut767W+ctGR1kRkxWcz470SycOcY+PW VRPJd91Af0GdLFkwzZgNzkd6Gyc9XXcv4lwwqBLhWrBhqPYB0aZXIG1E/cVTiRp4dWpFHAFD DcuLldjIw93lCDsIeEDM9rBizGVMWEoeFmqSe7pzGTPXzsFNBGJDD3EBEAC8fBFQHej8qgIG CBzoIEd1cZgPIARlIhRudODXoNDbwA+zJMKtOVwol3Hh1qJ2/yZP11nZsqrP4fyUvMxrwhDe WBWFVDbWHLnqXMnKuUU1vQMujbzgq/4Rb9wSMW5vBL6YxhZng+h71JgS/9nVtzyaTtsOTrJi 6nzFSDx6Wbza2jYvL9rlK0yxJcMEiKwZQ/if4KcOesD0rtxomU/iSEv6DATcJbGXP6T93nPl 90XksijRKAmOwvdu3A8IIlxiSSVRP0lxiHOeR35y6PjHY2usfEDZZOVOfDfhlCVAIBZUZALv VmFOVSTYXeKgYa6Ooaf72+cHM3SgJIbYnevJfFv8YQW0MEAJ/IXE7B1Lk+pHNxwU3VBCrKnA fd/PTvviesuYRkrRD6qqZnINeu3b2DouVGGt2fVcGA38BujCd3p8i7azoGc7A6cgF7z9ETnr ANrbg1/dJyDmkDxOxVrVquTBbxJbDy2HaIe9wyJTEK2Sznpy62DaHVY+gfDQzexBXM10geHC IIUhEnOUYVaq65X3ZDjyAQnNDBQ4uMqSHZk8DpJ22X+T+IMzWzWl+VyU4UZXjkLKPvlqPjJk 1RbKScek5L2GhxHQbPaD76Hx4Jiel0vm2G+4wei8Ay1+0YRFkhySxogU/uQVXHTv63KzQMak oIfnN/V2R0ucarsvMBW+gwARAQABwsF8BBgBCAAmAhsMFiEESbtpiOmzlcaw8cISVFM+0Ioq b/oFAmR3IPsFCQTeZ44ACgkQVFM+0Ioqb/qINhAAtcor9bevHy22HvJvXX17IOpPSklZJAeQ Az43ZEo5kRlJ8mElc2g3RzYCvL/V3fSiIATxIsLq/MDtYhO8AAvklxND/u2zeBd7BkRZTZZX W1V1cM3oTvfx3LOhDu4f2ExQzCGdkzbXTRswSJIe1W0qwsDp+YPekbrsKp1maZArGeu+6FuW honeosIrWS98QJmscEhP8ooyJkLDCCOgEk+mJ/JBjzcJGuYn6+Iy/ApMw/vqiLGL1UWekcTA g18mREHqIR+A3ZvypIufSFB52oIs1zD/uh/MgmL62bY/Cw6M2SxiVxLRsav9TNkF6ZaNQCgn GqifliCEMvEuLZRBOZSYH2A/PfwjYW0Ss0Gyfywmb2IA990gcQsXxuCLG7pAbWaeYazoYYEQ NYmWatZNMAs68ERI2zvrVxdJ/fBWAllIEd0uQ4P05GtAHPdTIDQYp545+TPV7oyF0LfXcsQs SFVZE6igdvkjfYmh+QOrHGZvpWXLTmffVf/AQ81wspzbfxJ7sYM4P8Mg5kKOsaoUdyA/2qVe cMh1CLUHXF1GlofpGbe1lj4KUJVse5g3qwV7i9VrseA8c4VIZewdIjkzAhmmbxl+8rM/LKBH dZUMTzME5PFCXJIZ83qkZQ795MTe2YScp9dIV7fsS5tpDwIs7BZNVM1l3NAdK+DLHqNxKuyO 8Zk= In-Reply-To: <b5c6cf79-c75d-d3ee-67ce-b52cdeb6f523@nvidia.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO2P265CA0279.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:a1::27) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|CH0PR12MB5089:EE_ X-MS-Office365-Filtering-Correlation-Id: 1965c006-a7cf-471c-9c1f-08dc2bdc4788 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: zwTHV48XlpqnyhgpuX4P7daTofImOlzzX+5kfUQMDCOjiE6zJUo/XDrYm6CWkk4MeWSow4DIZm03SNrXFjW/UJ5iA5/hLHSvjVDUn8fnYxIHuS1drxJeoeAvU2lrA5J5e/EdG8rNWZGV0xs7eQ2geQskgkgGpUa1t15+YV+dnSJrUhQhsqax2EOdakLS8FUngr201D/kIXYJ87PvLnoiN879pWn1AaMeXJHDzGddY/ADZWao355o9BsJSX8hh8WshDTuQFwDeQthP68WtQ9bLTcW0zgNz+m/4XksnY1IXZhpuSw+1iv4RqZ0Lkbr+v0YOwcARS1pUOT5Vnk+Sax+Sp7isUUAvublKlTrtq4ETExYliQMdcRza4MUSYjvDfokKADKhWOJRHh/3dYQBRYNm8geTfVVrR764bpL0X9iomEy34xx8x6t+6oJ4NaS6PMudCqSg4zR3SSD6G/R475oJkuCvfVYzno8YAT2JSAO3+SIW53izx7cKFpMVddSZbQ7P8bhbHS4ULs7ziCDLi/qZQq222nu+2gPqpwqEkqvZpx9ZQTibuGFctVXwiahRd/D X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(396003)(346002)(39860400002)(136003)(376002)(366004)(230922051799003)(1800799012)(186009)(451199024)(64100799003)(31686004)(38100700002)(86362001)(31696002)(2906002)(5660300002)(44832011)(6512007)(478600001)(26005)(53546011)(6486002)(41300700001)(2616005)(6506007)(83380400001)(6916009)(36756003)(4326008)(54906003)(66476007)(66556008)(316002)(8676002)(66946007)(8936002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?N2xlbzJrazZNWkVSMzB3SkRnbHBPdUd2ZWJwVjBRRGcvbXpwZVhCd0RnTHM0?= =?utf-8?B?aTFkRFZIdWhCRkFuckZFb2FaZlh4V0RmOWRnTkRGYlB6UGtvWi9rbWpyWTRD?= =?utf-8?B?cCsvYVhFSFJuZkJTRnBtdldycjFxM2gxcGYxMk5XRWtsQ1BMMmR2UngxRnIx?= =?utf-8?B?M0dsZHFKbkpPS2N1d3lTeWd2RlBYbUtjc2pOYnhGdTNoRitucEg0Z0hVM2ky?= =?utf-8?B?NTNtWVpCMFZoZzdxWWsxdTEvVTZpbW1FOWw0TlJ1aU5qSEJlQmFGTmhYVHla?= =?utf-8?B?dDlSTWpiMWErZmg5SW83QlpIOFNVM21FRFFENXN1RFNSbkZkSDMzcG1pZGlU?= =?utf-8?B?Ykd3UmFJc1FjNjM1dkg4Y1VkWFdzSW5hUzY2VWhqRTJJeTBXUG5CeEZOTjg4?= =?utf-8?B?OXNlbVFpN25mQ21iVEpjdG5LcXl5Wk5pbTVPTVBpbjhVQjV1UnpNVnlhd1gx?= =?utf-8?B?UEN1VTdqUFA0STh0MkpEZi9MODlZWjFkbGNFY1lYTzdJTVFFOGpZaU9pOGd4?= =?utf-8?B?QlRESlFrcjBheTB0eHVnOU05dFN5THh3TjBXUmpzUXVtQjgvMFJORnM5eXBy?= =?utf-8?B?ckI3eWJneDFNdWpLT3ZIMnBURnhybHZGMjdIQmlFSTJUdXFZZ0ppOUNGV2xa?= =?utf-8?B?T2thZVZhM0w1b3ljVWZwRnNpRlVPMStNc1FrNldEcENBRUJUYUpDOCtpTnkv?= =?utf-8?B?bUl5dDR2ZHpFb0hkakdqMTJOdjhXaXBEeGMrcmhvRHE0RXdpWlFTSXdTQ0Zv?= =?utf-8?B?YWdhb2w2c1ZhWHN6TUM5eWtXdmp3VzlydVMxOXU5R1hRK1JVdjRIZlQ5alpt?= =?utf-8?B?NHlzNEhkUmhGY3g2eGFqZWRMdHlicjZ4cTY0ZnVkQThaRDM2dUdZSDlPa0JQ?= =?utf-8?B?V3RLczRnaFNQQ20wcGUrN1k3YU1SSXN3UTgrejVPTkNLRTRpTEl2cy9VYk5V?= =?utf-8?B?L296ZTIyYXpwTjRLOUx2d3pqVUtqcHZTL3JCV05FY2Y0WGMwSS9PQXJQV1pG?= =?utf-8?B?em4xTlhlSXV4SHlTS21wRUJhMzB5S0RFeXJuU3ZvY095aEQ3Y3pERXVyRG9S?= =?utf-8?B?b3hVTitYQlAxV3FHcmpXUTBQRkFzV0h1MGlFZHBKdVNQYVZ0T2h1OWlodEt5?= =?utf-8?B?amdTMHdWaTN2dWVZY0tnZllXMUVLMENPREU5Y2xRRHdaM2pEK2NtU2RkN05C?= =?utf-8?B?eFVkbXhjNWlINGpoT04va3JYL055Wm85MnNOZlJKY3RPZEJPNWtSWkY4cTRD?= =?utf-8?B?NG4rK3hQSlFORmt4RmVsaHAxd2Rmek9yczFvYWtmeDFtdEJEM21mTFczMDJK?= =?utf-8?B?bmxJeXFLTzhzYysrbUtoQndoZ1dKYjRVSVVSdG91V2RYZ2R2bU9lVDFLRTBH?= =?utf-8?B?TVdwV09pNkVqZVpBbDA2c3hjUHlBMkdCNVhyZmVKcEhjZnBuT3NzRHBvcVhV?= =?utf-8?B?WTVxTWRqbmtWUzB6Z05UbkFOU2oyR2FrYjl2czl4ZTdsdVlNR201aTA0M1d0?= =?utf-8?B?R3FTakFQbm4rbkNTS1R4dWdpWHdXUmhzbEdXRndTYUlOVDdQTjREOVM3Y2pD?= =?utf-8?B?WlVWeW9MZ0UzclVBVi9yTGpyaUVzMHBoZUs2bm9uYWU3WUZnZlVwU0w0dUc1?= =?utf-8?B?UDU5YmdMV2RDVEt2eXQvTlVIZ1JhUnBjK2xsVndaMGhubjFDN3E2WlpDVE5D?= =?utf-8?B?YThDNkkveVdvMmNBWUdmemd3cFluelNaZjlhL091NXYzYUFXTWRkTTFHRU0w?= =?utf-8?B?S0RMeUovSGFVNVNTQmNqVXhXUmZITmswZ1JsSnp5WlpUN24zSFEzZDhlcVlJ?= =?utf-8?B?NnNiRmwvWDNJWDc1czZHQXcrYkQrT3VsSklQYjByM1g1dFhaVFZZS1owMi9E?= =?utf-8?B?UnpWMlpMc3g3WGYrZkMzN2FTblBhejN3ME53YkFySHNBTlFVQkNIS1VEZm5Q?= =?utf-8?B?U2VYcjBTSXN5Ym16QXNNcU5kdWk4a3BZMmIwMXA1MkN3bjJhbjc0R1BCcjA1?= =?utf-8?B?dncxNkoreXpwaERVUHViR1REd2dhTDROMmRCUEEwSDUrcXdoYjJnNmUxeUk0?= =?utf-8?B?bGhWT091QUkrSEw5a3MveER3YXppQ0FteEhQaWN1dm5kcUorQVZqU2FhM3hB?= =?utf-8?Q?84G5mKX8ivykhZF4tSCIC1r8c?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1965c006-a7cf-471c-9c1f-08dc2bdc4788 X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Feb 2024 15:07:07.4534 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: itAg3hX6oHPKf2yYCGJef7xsezZbIiFC9HRkKTEmEigJx89istYmf+is068Voog1 X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR12MB5089 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org On 2/12/2024 3:01 PM, Etelson, Gregory wrote: > Hello Ferruh, > > >> >> I have two more clarification requests, can you please check them below? >> >> >> If one ore more flow failed to update, for any reason, should user retry >> the update (in that case we need a retry error maybe) and can user still >> call 'rte_flow_template_table_resize_complete()' (for possible next >> table resize operation)? Can you please clarify this in your document. > > Please see my comment below. > >> >> When user calls update() with a flow from new table, API should ignore >> it and return success, you mentioned this is what mlx implementation is >> doing, what do you think to make this as default API behavior and >> document it in above API documentation? >> >> > > I'll update the patch. > >> >> If 'rte_flow_template_table_resize_complete()' fails, can application >> call another resize()? Is this managed in the application level or >> driver level (by returning error to next resize if complete() is not >> successful)? Is it something to clarify in your document? >> >> > > PMD failures in `rte_flow_async_update_resized()` and > `rte_flow_template_table_resize_complete()` are not recoverable. > OK, just please make sure this is clear in the documentation. Thanks.