From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9D0CEA0544; Wed, 12 Oct 2022 09:20:07 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 806AA42D86; Wed, 12 Oct 2022 09:20:07 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id DB74742BF0 for ; Wed, 12 Oct 2022 09:20:05 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1665559205; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=efD8etB/HPnD+O/SfPW6BypbkGJR4HeiBDT95A0MZE4=; b=LmPawCDtwJch6u/SGPbY/0IKNY08vYgGsMyXursp1lD3z2s0kMH7EH+zu6z3YWYtduRl4k qnj/xSBbcXWJxHry5UYqQpsUSORxy5nNtqXbKYTZAg+1gWOMQCpCmqGte8/Vw1HViL330U ACvFsnaJWydJ8RvjXFM8bzhZj+NJe9g= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-333-7d0vCEgDOCCBTytcalyI3g-1; Wed, 12 Oct 2022 03:20:01 -0400 X-MC-Unique: 7d0vCEgDOCCBTytcalyI3g-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.rdu2.redhat.com [10.11.54.8]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id AF9B285A583; Wed, 12 Oct 2022 07:20:00 +0000 (UTC) Received: from [10.39.208.19] (unknown [10.39.208.19]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 8BAF8C8E40E; Wed, 12 Oct 2022 07:19:58 +0000 (UTC) Message-ID: <1fba18e8-e4e6-55cc-6fc8-1703a1a21a3d@redhat.com> Date: Wed, 12 Oct 2022 09:19:56 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.1 To: "Chautru, Nicolas" , Akhil Goyal , "dev@dpdk.org" Cc: "trix@redhat.com" , "mdr@ashroe.eu" , "Richardson, Bruce" , "hemant.agrawal@nxp.com" , "david.marchand@redhat.com" , "stephen@networkplumber.org" , "Vargas, Hernan" References: <20221007213851.31524-1-nicolas.chautru@intel.com> <20221007213851.31524-14-nicolas.chautru@intel.com> <692bde86-9d88-4bc3-00eb-b095038a2744@redhat.com> From: Maxime Coquelin Subject: Re: [EXT] Re: [PATCH v9 13/14] baseband/acc: add PF configure companion function In-Reply-To: X-Scanned-By: MIMEDefang 3.1 on 10.11.54.8 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 10/11/22 23:18, Chautru, Nicolas wrote: > Hi Akhil, Maxime, > >> -----Original Message----- >> From: Akhil Goyal >> Sent: Monday, October 10, 2022 11:12 AM >> To: Chautru, Nicolas ; Maxime Coquelin >> ; dev@dpdk.org >> Cc: trix@redhat.com; mdr@ashroe.eu; Richardson, Bruce >> ; hemant.agrawal@nxp.com; >> david.marchand@redhat.com; stephen@networkplumber.org; Vargas, >> Hernan >> Subject: RE: [EXT] Re: [PATCH v9 13/14] baseband/acc: add PF configure >> companion function >> >>> Hi Akhil, Maxime, >>> >>>> From: Akhil Goyal >>>> Sent: Monday, October 10, 2022 3:09 AM >>>> Subject: RE: [EXT] Re: [PATCH v9 13/14] baseband/acc: add PF >>>> configure companion function >>>> >>>>>> diff --git a/drivers/baseband/acc/version.map >>>>> b/drivers/baseband/acc/version.map >>>>>> index b4ff13e38f..27fbbe3de5 100644 >>>>>> --- a/drivers/baseband/acc/version.map >>>>>> +++ b/drivers/baseband/acc/version.map >>>>>> @@ -6,4 +6,5 @@ EXPERIMENTAL { >>>>>> global: >>>>>> >>>>>> rte_acc10x_configure; >>>>>> + rte_acc200_configure; >>>>>> }; >>>>> >>>>> This is same comment as for ACC100 vs. ACC101. >>>>> Having a single API would be the way to go, given the prototype of >>>>> the functions are identical. >>>>> >>>>> Keep acc200 function, but internal only, rte_acc_configure() would >>>>> call the acc100/acc101/acc200/accXXX based on the device ID. >>>>> >>>> +1 for this. >>>> >>>> I believe a bbdev API should be defined to be used by each of the PMD. >>>> So that application can be agnostic of the underneath device. >>>> >>>> I would recommend to send a deprecation notice to remove all the pmd >>>> APIs going forward. We can take it for now, but these need to be >>>> replaced with generic API as soon as possible. No new such PMD API >>>> would be accepted going forward. >>>> >>> >>> OK understood, we can look into this for 23.03. >>> Are we okay to keep that commit as is for 22.11? >>> >> What Maxime is suggesting is adding a wrapper in PMD to hide variant of >> acc. >> I believe it is better to do it now as this is long term stable release. >> You can send a deprecation notice for removing PMD APIs and adding new >> generic API now which can be done in next cycle. > > Updated in the V10 as suggested. Thanks. > This rte_acc_configure() symbol is marked as experimental. I believe we can remove it without notice (this is already modified in this serie without notice). Yes, no worries since this is experimental. > Note that this is only used by bbdev-test so this is all self-contained and no impact to the ecosystem. Given it is only meant to be used by the dpdk-test-bbdev application, maybe it could be an internal API? Avoiding to export it would make our lives easier. Regards, Maxime > Thanks, > Nic > > > > >