From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Srisivasubramanian S <ssrinivasan@caviumnetworks.com>, dev@dpdk.org
Cc: Shijith Thotton <shijith.thotton@caviumnetworks.com>
Subject: Re: [dpdk-dev] [PATCH] net/liquidio: add support for 10GBase-T cards
Date: Tue, 24 Oct 2017 10:49:13 -0700 [thread overview]
Message-ID: <1fe096ea-7a18-e7a1-2f64-3a4ce1464caf@intel.com> (raw)
In-Reply-To: <1508820170-7512-1-git-send-email-ssrinivasan@caviumnetworks.com>
On 10/23/2017 9:42 PM, Srisivasubramanian S wrote:
> Signed-off-by: Srisivasubramanian S <ssrinivasan@caviumnetworks.com>
> Signed-off-by: Shijith Thotton <shijith.thotton@caviumnetworks.com>
> ---
> doc/guides/nics/liquidio.rst | 2 ++
> drivers/net/liquidio/base/lio_hw_defs.h | 12 ++++++++----
> drivers/net/liquidio/lio_ethdev.c | 7 ++++++-
> 3 files changed, 16 insertions(+), 5 deletions(-)
>
> diff --git a/doc/guides/nics/liquidio.rst b/doc/guides/nics/liquidio.rst
> index 4ccde0c..7bc1604 100644
> --- a/doc/guides/nics/liquidio.rst
> +++ b/doc/guides/nics/liquidio.rst
> @@ -42,7 +42,9 @@ Supported LiquidIO Adapters
> -----------------------------
>
> - LiquidIO II CN2350 210SV/225SV
> +- LiquidIO II CN2350 210SVPT
> - LiquidIO II CN2360 210SV/225SV
> +- LiquidIO II CN2360 210SVPT
Do you want to update release notes to announce new device support?
>
>
> Pre-Installation Configuration
> diff --git a/drivers/net/liquidio/base/lio_hw_defs.h b/drivers/net/liquidio/base/lio_hw_defs.h
> index c7f97f2..d4cd23c 100644
> --- a/drivers/net/liquidio/base/lio_hw_defs.h
> +++ b/drivers/net/liquidio/base/lio_hw_defs.h
> @@ -43,10 +43,14 @@
> #define LIO_CN23XX_VF_VID 0x9712
>
> /* CN23xx subsystem device ids */
> -#define PCI_SUBSYS_DEV_ID_CN2350_210 0x0004
> -#define PCI_SUBSYS_DEV_ID_CN2360_210 0x0005
> -#define PCI_SUBSYS_DEV_ID_CN2360_225 0x0006
> -#define PCI_SUBSYS_DEV_ID_CN2350_225 0x0007
> +#define PCI_SUBSYS_DEV_ID_CN2350_210 0x0004
> +#define PCI_SUBSYS_DEV_ID_CN2360_210 0x0005
> +#define PCI_SUBSYS_DEV_ID_CN2360_225 0x0006
> +#define PCI_SUBSYS_DEV_ID_CN2350_225 0x0007
> +#define PCI_SUBSYS_DEV_ID_CN2350_210SVPN3 0x0008
> +#define PCI_SUBSYS_DEV_ID_CN2360_210SVPN3 0x0009
> +#define PCI_SUBSYS_DEV_ID_CN2350_210SVPT 0x000a
> +#define PCI_SUBSYS_DEV_ID_CN2360_210SVPT 0x000b
>
> /* --------------------------CONFIG VALUES------------------------ */
>
> diff --git a/drivers/net/liquidio/lio_ethdev.c b/drivers/net/liquidio/lio_ethdev.c
> index 239f6af..2ffbfd2 100644
> --- a/drivers/net/liquidio/lio_ethdev.c
> +++ b/drivers/net/liquidio/lio_ethdev.c
> @@ -405,6 +405,10 @@ lio_dev_info_get(struct rte_eth_dev *eth_dev,
> /* CN23xx 10G cards */
> case PCI_SUBSYS_DEV_ID_CN2350_210:
> case PCI_SUBSYS_DEV_ID_CN2360_210:
> + case PCI_SUBSYS_DEV_ID_CN2350_210SVPN3:
> + case PCI_SUBSYS_DEV_ID_CN2360_210SVPN3:
> + case PCI_SUBSYS_DEV_ID_CN2350_210SVPT:
> + case PCI_SUBSYS_DEV_ID_CN2360_210SVPT:
> devinfo->speed_capa = ETH_LINK_SPEED_10G;
> break;
> /* CN23xx 25G cards */
> @@ -413,8 +417,9 @@ lio_dev_info_get(struct rte_eth_dev *eth_dev,
> devinfo->speed_capa = ETH_LINK_SPEED_25G;
> break;
> default:
> + devinfo->speed_capa = ETH_LINK_SPEED_10G;
> lio_dev_err(lio_dev,
> - "Unknown CN23XX subsystem device id. Not setting speed capability.\n");
> + "Unknown CN23XX subsystem device id. Setting 10G as default link speed.\n");
Instead of setting speed and default and print an error log, why not added cases
for new devices and set to 10G there?
> }
>
> devinfo->max_rx_queues = lio_dev->max_rx_queues;
>
next prev parent reply other threads:[~2017-10-24 17:49 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-24 4:42 Srisivasubramanian S
2017-10-24 17:49 ` Ferruh Yigit [this message]
2017-10-25 18:06 ` Srisivasubramanian Srinivasan
2017-10-25 18:23 ` Ferruh Yigit
2017-10-26 2:23 ` Srisivasubramanian Srinivasan
2017-10-26 18:46 ` Ferruh Yigit
2017-10-26 19:17 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1fe096ea-7a18-e7a1-2f64-3a4ce1464caf@intel.com \
--to=ferruh.yigit@intel.com \
--cc=dev@dpdk.org \
--cc=shijith.thotton@caviumnetworks.com \
--cc=ssrinivasan@caviumnetworks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).