From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 70FD6237 for ; Tue, 24 Oct 2017 19:49:15 +0200 (CEST) Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 24 Oct 2017 10:49:14 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.43,428,1503385200"; d="scan'208";a="166539205" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.241.225.60]) ([10.241.225.60]) by fmsmga005.fm.intel.com with ESMTP; 24 Oct 2017 10:49:13 -0700 To: Srisivasubramanian S , dev@dpdk.org Cc: Shijith Thotton References: <1508820170-7512-1-git-send-email-ssrinivasan@caviumnetworks.com> From: Ferruh Yigit Message-ID: <1fe096ea-7a18-e7a1-2f64-3a4ce1464caf@intel.com> Date: Tue, 24 Oct 2017 10:49:13 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <1508820170-7512-1-git-send-email-ssrinivasan@caviumnetworks.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] net/liquidio: add support for 10GBase-T cards X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 24 Oct 2017 17:49:15 -0000 On 10/23/2017 9:42 PM, Srisivasubramanian S wrote: > Signed-off-by: Srisivasubramanian S > Signed-off-by: Shijith Thotton > --- > doc/guides/nics/liquidio.rst | 2 ++ > drivers/net/liquidio/base/lio_hw_defs.h | 12 ++++++++---- > drivers/net/liquidio/lio_ethdev.c | 7 ++++++- > 3 files changed, 16 insertions(+), 5 deletions(-) > > diff --git a/doc/guides/nics/liquidio.rst b/doc/guides/nics/liquidio.rst > index 4ccde0c..7bc1604 100644 > --- a/doc/guides/nics/liquidio.rst > +++ b/doc/guides/nics/liquidio.rst > @@ -42,7 +42,9 @@ Supported LiquidIO Adapters > ----------------------------- > > - LiquidIO II CN2350 210SV/225SV > +- LiquidIO II CN2350 210SVPT > - LiquidIO II CN2360 210SV/225SV > +- LiquidIO II CN2360 210SVPT Do you want to update release notes to announce new device support? > > > Pre-Installation Configuration > diff --git a/drivers/net/liquidio/base/lio_hw_defs.h b/drivers/net/liquidio/base/lio_hw_defs.h > index c7f97f2..d4cd23c 100644 > --- a/drivers/net/liquidio/base/lio_hw_defs.h > +++ b/drivers/net/liquidio/base/lio_hw_defs.h > @@ -43,10 +43,14 @@ > #define LIO_CN23XX_VF_VID 0x9712 > > /* CN23xx subsystem device ids */ > -#define PCI_SUBSYS_DEV_ID_CN2350_210 0x0004 > -#define PCI_SUBSYS_DEV_ID_CN2360_210 0x0005 > -#define PCI_SUBSYS_DEV_ID_CN2360_225 0x0006 > -#define PCI_SUBSYS_DEV_ID_CN2350_225 0x0007 > +#define PCI_SUBSYS_DEV_ID_CN2350_210 0x0004 > +#define PCI_SUBSYS_DEV_ID_CN2360_210 0x0005 > +#define PCI_SUBSYS_DEV_ID_CN2360_225 0x0006 > +#define PCI_SUBSYS_DEV_ID_CN2350_225 0x0007 > +#define PCI_SUBSYS_DEV_ID_CN2350_210SVPN3 0x0008 > +#define PCI_SUBSYS_DEV_ID_CN2360_210SVPN3 0x0009 > +#define PCI_SUBSYS_DEV_ID_CN2350_210SVPT 0x000a > +#define PCI_SUBSYS_DEV_ID_CN2360_210SVPT 0x000b > > /* --------------------------CONFIG VALUES------------------------ */ > > diff --git a/drivers/net/liquidio/lio_ethdev.c b/drivers/net/liquidio/lio_ethdev.c > index 239f6af..2ffbfd2 100644 > --- a/drivers/net/liquidio/lio_ethdev.c > +++ b/drivers/net/liquidio/lio_ethdev.c > @@ -405,6 +405,10 @@ lio_dev_info_get(struct rte_eth_dev *eth_dev, > /* CN23xx 10G cards */ > case PCI_SUBSYS_DEV_ID_CN2350_210: > case PCI_SUBSYS_DEV_ID_CN2360_210: > + case PCI_SUBSYS_DEV_ID_CN2350_210SVPN3: > + case PCI_SUBSYS_DEV_ID_CN2360_210SVPN3: > + case PCI_SUBSYS_DEV_ID_CN2350_210SVPT: > + case PCI_SUBSYS_DEV_ID_CN2360_210SVPT: > devinfo->speed_capa = ETH_LINK_SPEED_10G; > break; > /* CN23xx 25G cards */ > @@ -413,8 +417,9 @@ lio_dev_info_get(struct rte_eth_dev *eth_dev, > devinfo->speed_capa = ETH_LINK_SPEED_25G; > break; > default: > + devinfo->speed_capa = ETH_LINK_SPEED_10G; > lio_dev_err(lio_dev, > - "Unknown CN23XX subsystem device id. Not setting speed capability.\n"); > + "Unknown CN23XX subsystem device id. Setting 10G as default link speed.\n"); Instead of setting speed and default and print an error log, why not added cases for new devices and set to 10G there? > } > > devinfo->max_rx_queues = lio_dev->max_rx_queues; >