From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <anatoly.burakov@intel.com>
Received: from mga11.intel.com (mga11.intel.com [192.55.52.93])
 by dpdk.org (Postfix) with ESMTP id 600D31B440
 for <dev@dpdk.org>; Thu, 14 Feb 2019 17:44:42 +0100 (CET)
X-Amp-Result: SKIPPED(no attachment in message)
X-Amp-File-Uploaded: False
Received: from fmsmga005.fm.intel.com ([10.253.24.32])
 by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;
 14 Feb 2019 08:44:41 -0800
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.58,369,1544515200"; d="scan'208";a="320426899"
Received: from aburakov-mobl1.ger.corp.intel.com (HELO [10.251.90.29])
 ([10.251.90.29])
 by fmsmga005.fm.intel.com with ESMTP; 14 Feb 2019 08:44:41 -0800
To: David Marchand <david.marchand@redhat.com>, dev@dpdk.org
References: <1550150874-9535-1-git-send-email-david.marchand@redhat.com>
From: "Burakov, Anatoly" <anatoly.burakov@intel.com>
Message-ID: <1fed1442-efc2-0156-7db1-8b2c01292659@intel.com>
Date: Thu, 14 Feb 2019 16:44:40 +0000
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101
 Thunderbird/60.5.0
MIME-Version: 1.0
In-Reply-To: <1550150874-9535-1-git-send-email-david.marchand@redhat.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Subject: Re: [dpdk-dev] [PATCH] eal: fix check when retrieving current cpu
 affinity
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 14 Feb 2019 16:44:42 -0000

On 14-Feb-19 1:27 PM, David Marchand wrote:
> pthread_getaffinity_np returns a >0 value when failing.
> 
> This is mainly for the sake of correctness.
> The only case where it could fail is when passing an incorrect cpuset
> size wrt to the kernel.
> 
> Fixes: 2eba8d21f3c9 ("eal: restrict cores auto detection")
> Signed-off-by: David Marchand <david.marchand@redhat.com>
> ---
>   lib/librte_eal/common/eal_common_options.c | 5 ++---
>   1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/lib/librte_eal/common/eal_common_options.c b/lib/librte_eal/common/eal_common_options.c
> index 6c96f45..1f45f82 100644
> --- a/lib/librte_eal/common/eal_common_options.c
> +++ b/lib/librte_eal/common/eal_common_options.c
> @@ -1343,10 +1343,9 @@ static int xdigit2val(unsigned char c)
>   	unsigned int lcore_id;
>   	unsigned int removed = 0;
>   	rte_cpuset_t affinity_set;
> -	pthread_t tid = pthread_self();
>   
> -	if (pthread_getaffinity_np(tid, sizeof(rte_cpuset_t),
> -				&affinity_set) < 0)
> +	if (pthread_getaffinity_np(pthread_self(), sizeof(rte_cpuset_t),
> +				&affinity_set))
>   		CPU_ZERO(&affinity_set);
>   
>   	for (lcore_id = 0; lcore_id < RTE_MAX_LCORE; lcore_id++) {
> 
CC: stable?

-- 
Thanks,
Anatoly