From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D4BA9A0C4E; Sun, 7 Nov 2021 18:50:30 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7740240151; Sun, 7 Nov 2021 18:50:30 +0100 (CET) Received: from wout1-smtp.messagingengine.com (wout1-smtp.messagingengine.com [64.147.123.24]) by mails.dpdk.org (Postfix) with ESMTP id D22B840040 for ; Sun, 7 Nov 2021 18:50:27 +0100 (CET) Received: from compute6.internal (compute6.nyi.internal [10.202.2.46]) by mailout.west.internal (Postfix) with ESMTP id AD73C3200A1E; Sun, 7 Nov 2021 12:50:25 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute6.internal (MEProxy); Sun, 07 Nov 2021 12:50:26 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm2; bh= ZJWGjUvh+6ijT2Q8tEHzfn6ZtPiHJFfJ3hQWLr7tQLI=; b=Kz6vynsyAnzaj+Tm addToykNoXE1spty4B/d/YzxbgkEFCqQL3pHDwahgXWn6Jz7mmS2jE+NECjivQJ8 UVxK7nduJP2W7MugFH1oVnTEvd4W0hJSzAeBWwOuvHbawNdJdmak/5Mw6dBhD/X/ B7eiy3nPzlWkVcqgS0Sea1w1BjbCP2wYEYjze2NTGhtqUrBTAAQrf3egmdbP62Fz Jd3oxZFDw8CPuE2JJPDu92wmBrF0zuMj42P1L+Ukcgq6s82tVT36JTUp+g5xD6eT BvZaLBhOCzagnnzN7AVmHA7Gm2e0aWd0XvhD/PtJ6RRMQsjU8hSdyTBcD50uIiTr YvSnOg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=ZJWGjUvh+6ijT2Q8tEHzfn6ZtPiHJFfJ3hQWLr7tQ LI=; b=gOVjMzFE7SdEFw/uprPeSkQWua1++k2p2ADmD7bKafFKWRIffvT0ERQkd EmKshGRSVJHmGoRDXQ+6nqdswNrtBHkNjRSNYYxZskMAM7l/lq5Uo8dn67zSbQEN ahR8X3Vpn4Fedv1LLV9dr/XdFrScgK9noIiHBonvgKtrO434+TUZtkzxo0icFm5e 9Ni10tasHHfObtzMpvmncBPxGkVNwdX92bSZFuTJpisY+Igh88FsdEc7ha/Y1opX 2bOZzHOZkFsfCxZOsTOwIAPXKOgxl7B25Y/gXp79jAho3QV7i4juwcceNgWWbhP0 OaoNaytchEMKf2Z4ASECLCcWJTPYQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvuddruddtgddutdegucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepudeggfdvfeduffdtfeeglefghfeukefgfffhueejtdetuedtjeeu ieeivdffgeehnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrh homhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sun, 7 Nov 2021 12:50:24 -0500 (EST) From: Thomas Monjalon To: Ali Alnubani Cc: dev@dpdk.org, wojciechx.liguzinski@intel.com Date: Sun, 07 Nov 2021 18:50:23 +0100 Message-ID: <2000014.V5QNo6tYjM@thomas> In-Reply-To: <20211107163054.2745624-1-alialnu@nvidia.com> References: <20211107163054.2745624-1-alialnu@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] sched: fix build with debug enabled X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 07/11/2021 17:30, Ali Alnubani: > Compare pkt_len to 0 instead of NULL to avoid the following build > failure with debug mode enabled: > ../lib/sched/rte_pie.h: In function 'rte_pie_enqueue_empty': > ../lib/sched/rte_pie.h:125:21: error: comparison between pointer > and integer [-Werror] > RTE_ASSERT(pkt_len != NULL); > > Bugzilla ID: 878 > Fixes: 44c730b0e379 ("sched: add PIE based congestion management") > Cc: wojciechx.liguzinski@intel.com > > Signed-off-by: Ali Alnubani Applied, thanks Ali. I expect a lot more fixes in this lib, given the poor review.