From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f41.google.com (mail-wm0-f41.google.com [74.125.82.41]) by dpdk.org (Postfix) with ESMTP id AEDBF2B84 for ; Thu, 29 Sep 2016 16:25:07 +0200 (CEST) Received: by mail-wm0-f41.google.com with SMTP id w84so301542892wmg.1 for ; Thu, 29 Sep 2016 07:25:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:user-agent:in-reply-to :references:mime-version:content-transfer-encoding; bh=q7Xyzx0klJBr0rTXBAWr1yC3gpsdjnseOknI48D1A+Q=; b=MaJxHhiy6S6geTnwA167G4wMbeV1ZR70nbdb4b7iTdr2vHL2MO2fMkeVIZzbKvoTqi gxOolakzAHRYw8CgtE06qgNr9DAUQKRJ1omqezZyxvVOC9ZC1F6yTddygBpKbm/u8POB Rp2NVUEHkAJ7S583Y+MmIQPGdYOx5W4nGnGsbo4m6mxDcbb1oHMyHJ62nxYX4dN5eO2D 2rrH3Unp9dzdOEfGV2S0I+MV9OtGPvI2mFhV6QYzOFpXgODJkKl7u1ZTuIpSrAAEBREm dgo634bzAsXoTPA+HnCU4zqDnbwJUhDaK8uLP+pwL71vh/DdNNunwL9TEvtswXw9ug2I epow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=q7Xyzx0klJBr0rTXBAWr1yC3gpsdjnseOknI48D1A+Q=; b=NvhTz+5P05dX22JRMQ0Q6LPYj2LJZXg81ZilxZHlelMl1WiK7WJ1dkJkes+rvCKeMo 6stmAoHiq/Ks8Cv6YZdU2eKtJYJG8bZRDhZ4/Jlm7xdm8BKGyZ1b8/aHF9zUnlujqI+n 1mtMZCUZrsFF+hFhAbC4bm/UtUKkbr01bKEHt2v+CNikT6V+c1/ACFsNLXSUy20uo8dH ar7y7CV096NXCNnE3v87NADfafVQtRib9uFGV1biYe7zzWSfbxqcPfedr4FWzHbgVZtU Ob6af+i2vd0kGhNAsSsrLgIO2NX06HHK/kQXlQbAcJhW2K8ceun+Jv3uJaHJRZphLHsg ALfQ== X-Gm-Message-State: AA6/9Rmd4po49ILRlzmQnYgTe0j8pYAsvvausBc8FlgbdsFhFlLGimQP5YG41wWM1o+ZPn6D X-Received: by 10.194.9.36 with SMTP id w4mr1729994wja.133.1475159107520; Thu, 29 Sep 2016 07:25:07 -0700 (PDT) Received: from xps13.localnet (184.203.134.77.rev.sfr.net. [77.134.203.184]) by smtp.gmail.com with ESMTPSA id bj8sm14422148wjc.49.2016.09.29.07.25.06 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 29 Sep 2016 07:25:06 -0700 (PDT) From: Thomas Monjalon To: "Trahe, Fiona" Cc: dev@dpdk.org, "De Lara Guarch, Pablo" , "akhil.goyal@nxp.com" Date: Thu, 29 Sep 2016 16:25:06 +0200 Message-ID: <2002488.2H5o8Bgc8G@xps13> User-Agent: KMail/4.14.10 (Linux/4.5.4-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <348A99DA5F5B7549AA880327E580B435890E9364@IRSMSX101.ger.corp.intel.com> References: <20160926163300.22990-1-akhil.goyal@nxp.com> <348A99DA5F5B7549AA880327E580B435890E9364@IRSMSX101.ger.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] app/test: Remove hard coding for nb_queue_pairs in test_cryptodev X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 29 Sep 2016 14:25:07 -0000 2016-09-29 14:12, Trahe, Fiona: > > > From: Akhil Goyal > > > > > > nb_queue_pairs should not be hard coded with device specific number. > > > It should be retrieved from the device infos. > > > Also in ut_setup, ts_params->conf.nb_queue_pairs is already set in > > > testsuite_setup and we are not modifying it. > > > > > > Signed-off-by: Akhil Goyal > > > > Acked-by: Pablo de Lara > > The above code is correct, however it exposes a bug in QAT PMD unit tests. > And some cleanup needed for unnecessary qp setup code. > That cleanup then exposed a bug in aesni_mb PMD which prevents re-creating queue pairs of a different size. > > I have a fix and cleanup patch ready. > Just not sure how best to push it? > The original patch also needs rebasing, doesn't apply cleanly to the latest dpdk-next-crypto > > Pablo should I push all as a reply to the first patch - waiting first for that to be rebased? > Or > It would save Akhil a rebase and be simpler if I can include the original change in my patch and push all as a v2 superceding the original patch? Is this possible? > Or > should I Nack the original patch and push all instead? My preference goes to a v2.