From: Lewis Donzis <lew@perftech.com>
To: Bruce Richardson <bruce.richardson@intel.com>
Cc: dev <dev@dpdk.org>
Subject: Re: FreeBSD 13.1 changes
Date: Mon, 30 May 2022 07:50:19 -0500 (CDT) [thread overview]
Message-ID: <200292248.4577111.1653915019819.JavaMail.zimbra@donzis.com> (raw)
In-Reply-To: <YpR7yl/iPxCYif13@bricha3-MOBL.ger.corp.intel.com>
----- On May 30, 2022, at 3:09 AM, Bruce Richardson bruce.richardson@intel.com wrote:
> On Sun, May 29, 2022 at 06:36:21AM -0500, Lewis Donzis wrote:
>> Apparently FreeBSD 13.1 changed the syntax of the CPUSET macros, so DPDK no
>> longer compiles.
>>
>> For example, here's one definition on FreeBSD 13.0 and prior:
>>
>> CPU_OR(cpuset_t *dst, cpuset_t *src);
>>
>> and here it is in FreeBSD 13.1:
>>
>> CPU_OR(cpuset_t *dst, cpuset_t *src1, cpuset_t *src2);
>>
>> I've modified lib/eal/freebsd/include/rte_os.h to handle both old and new
>> versions of FreeBSD.
>>
>> I'd like to provide the updated file, if someone would be willing to review and
>> commit, please?
>>
> Can you please retest with the latest DPDK code in git. This should be
> fixed there now. See patch [1]. The fix should make its way into the LTS
> backports over time too.
>
> /Bruce
>
> [1]
> http://patches.dpdk.org/project/dpdk/patch/20220520181050.55654-1-bruce.richardson@intel.com/
Yes, it definitely compiles now, thank you!
Something is still not working properly, I think in the ixl driver. But I tried the same test on FreeBSD 13.0 and it also doesn't work, so I don't think that's related to this change. The problem appears to be related to forcing "wait" true on FreeBSD in ixgbe_dev_link_update_share(). Should I post that as a separate thread?
next prev parent reply other threads:[~2022-05-30 12:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-29 11:36 Lewis Donzis
2022-05-30 8:09 ` Bruce Richardson
2022-05-30 12:50 ` Lewis Donzis [this message]
2022-05-30 13:15 ` Bruce Richardson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200292248.4577111.1653915019819.JavaMail.zimbra@donzis.com \
--to=lew@perftech.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).