From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 429C1A0540; Mon, 30 May 2022 14:50:25 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2CE8340694; Mon, 30 May 2022 14:50:25 +0200 (CEST) Received: from smtp-gw.pt.net (smtp-gw.pt.net [206.210.194.15]) by mails.dpdk.org (Postfix) with ESMTP id EB80D400D6 for ; Mon, 30 May 2022 14:50:22 +0200 (CEST) X-ASG-Debug-ID: 1653915020-09411a0f72a13480001-TfluYd Received: from mail.pt.net (mail.pt.net [206.210.194.11]) by smtp-gw.pt.net with ESMTP id UMAyB9rCeJJfyEaL (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NO); Mon, 30 May 2022 07:50:20 -0500 (CDT) X-Barracuda-Envelope-From: lew@donzis.com X-Barracuda-Effective-Source-IP: mail.pt.net[206.210.194.11] X-Barracuda-Apparent-Source-IP: 206.210.194.11 Received: from localhost (localhost [IPv6:::1]) by mail.pt.net (Postfix) with ESMTP id 6140811741F3; Mon, 30 May 2022 07:50:20 -0500 (CDT) Received: from mail.pt.net ([IPv6:::1]) by localhost (mail.pt.net [IPv6:::1]) (amavisd-new, port 10032) with ESMTP id 7bL4F6P8SA4p; Mon, 30 May 2022 07:50:20 -0500 (CDT) Received: from localhost (localhost [IPv6:::1]) by mail.pt.net (Postfix) with ESMTP id 01E73117434A; Mon, 30 May 2022 07:50:20 -0500 (CDT) X-Virus-Scanned: amavisd-new at pt.net Received: from mail.pt.net ([IPv6:::1]) by localhost (mail.pt.net [IPv6:::1]) (amavisd-new, port 10026) with ESMTP id 2fbmXOAx4_pf; Mon, 30 May 2022 07:50:19 -0500 (CDT) Received: from mail.pt.net (mail.pt.net [206.210.194.11]) by mail.pt.net (Postfix) with ESMTP id DB41411741F1; Mon, 30 May 2022 07:50:19 -0500 (CDT) Date: Mon, 30 May 2022 07:50:19 -0500 (CDT) From: Lewis Donzis To: Bruce Richardson Cc: dev Message-ID: <200292248.4577111.1653915019819.JavaMail.zimbra@donzis.com> In-Reply-To: References: <1154975224.4469878.1653824181427.JavaMail.zimbra@donzis.com> Subject: Re: FreeBSD 13.1 changes MIME-Version: 1.0 X-ASG-Orig-Subj: Re: FreeBSD 13.1 changes Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-Originating-IP: [206.210.194.11] X-Mailer: Zimbra 8.8.15_GA_4272 (ZimbraWebClient - GC101 (Mac)/8.8.15_GA_4257) Thread-Topic: FreeBSD 13.1 changes Thread-Index: ybXm3iUFjrIgGh8w6YwAcf2bh9QVfA== X-Barracuda-Connect: mail.pt.net[206.210.194.11] X-Barracuda-Start-Time: 1653915020 X-Barracuda-Encrypted: TLS_AES_256_GCM_SHA384 X-Barracuda-URL: https://smtp-gw.pt.net:443/cgi-mod/mark.cgi X-Virus-Scanned: by bsmtpd at pt.net X-Barracuda-Scan-Msg-Size: 1390 X-Barracuda-BRTS-Status: 1 X-Barracuda-Spam-Score: 0.40 X-Barracuda-Spam-Status: No, SCORE=0.40 using global scores of TAG_LEVEL=1000.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=9.0 tests=BSF_SC0_SA085b X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.3.98363 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- 0.40 BSF_SC0_SA085b Custom Rule SA085b X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org ----- On May 30, 2022, at 3:09 AM, Bruce Richardson bruce.richardson@intel.com wrote: > On Sun, May 29, 2022 at 06:36:21AM -0500, Lewis Donzis wrote: >> Apparently FreeBSD 13.1 changed the syntax of the CPUSET macros, so DPDK no >> longer compiles. >> >> For example, here's one definition on FreeBSD 13.0 and prior: >> >> CPU_OR(cpuset_t *dst, cpuset_t *src); >> >> and here it is in FreeBSD 13.1: >> >> CPU_OR(cpuset_t *dst, cpuset_t *src1, cpuset_t *src2); >> >> I've modified lib/eal/freebsd/include/rte_os.h to handle both old and new >> versions of FreeBSD. >> >> I'd like to provide the updated file, if someone would be willing to review and >> commit, please? >> > Can you please retest with the latest DPDK code in git. This should be > fixed there now. See patch [1]. The fix should make its way into the LTS > backports over time too. > > /Bruce > > [1] > http://patches.dpdk.org/project/dpdk/patch/20220520181050.55654-1-bruce.richardson@intel.com/ Yes, it definitely compiles now, thank you! Something is still not working properly, I think in the ixl driver. But I tried the same test on FreeBSD 13.0 and it also doesn't work, so I don't think that's related to this change. The problem appears to be related to forcing "wait" true on FreeBSD in ixgbe_dev_link_update_share(). Should I post that as a separate thread?