DPDK patches and discussions
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH 2/2] pipeline: autodetect endianness of action args
Date: Tue, 20 Apr 2021 21:57:51 +0200	[thread overview]
Message-ID: <2003889.D9zfWNbQnx@thomas> (raw)
In-Reply-To: <20210411232338.4005-2-cristian.dumitrescu@intel.com>

12/04/2021 01:23, Cristian Dumitrescu:
> Each table entry is made up of match fields and action data, with the
> latter made up of the action ID and the action arguments. The approach
> of having the user specify explicitly the endianness of the action
> arguments is difficult to be picked up by P4 compilers, as the P4
> compiler is generally unaware about this aspect.
> This commit introduces the auto-detection of the endianness of the
> action arguments by examining the endianness of the their destination:
> network byte order (NBO) when they get copied to headers and host byte
> order (HBO) when they get copied to packet meta-data or mailboxes.
> The endianness specification of each action argument as part of the
> rule specification, e.g. H(...) and N(...) is removed from the rule
> file and auto-detected based on their destination. The DMA instruction
> scope is made internal, so mov instructions need to be used. The
> pattern of transferring complete headers from table entry action args
> to headers is detected, and the associated set of mov instructions
> plus header validate is internally detected and replaced with the
> internal-only DMA instruction to preserve performance.
> Signed-off-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>

Series applied, thanks

  parent reply	other threads:[~2021-04-20 19:57 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-11 23:23 [dpdk-dev] [PATCH 1/2] pipeline: modularize the instruction optimizer Cristian Dumitrescu
2021-04-11 23:23 ` [dpdk-dev] [PATCH 2/2] pipeline: autodetect endianness of action args Cristian Dumitrescu
2021-04-20  0:48   ` Thomas Monjalon
2021-04-20 10:04     ` Dumitrescu, Cristian
2021-04-20 10:06       ` Thomas Monjalon
2021-04-20 10:20         ` Dumitrescu, Cristian
2021-04-20 14:48           ` Aaron Conole
2021-04-20 19:57   ` Thomas Monjalon [this message]
2021-04-21  7:49     ` Ali Alnubani
2021-04-21 12:57       ` Aaron Conole
2021-04-21 13:03         ` Ali Alnubani
2021-04-21 13:21           ` Aaron Conole
2021-04-21 13:58       ` Dumitrescu, Cristian
2021-04-21 14:24         ` Ali Alnubani
2021-04-21 15:10           ` Dumitrescu, Cristian

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2003889.D9zfWNbQnx@thomas \
    --to=thomas@monjalon.net \
    --cc=cristian.dumitrescu@intel.com \
    --cc=dev@dpdk.org \


* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).