From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <thomas.monjalon@6wind.com> Received: from mail-wi0-f171.google.com (mail-wi0-f171.google.com [209.85.212.171]) by dpdk.org (Postfix) with ESMTP id C2D4A5A9A for <dev@dpdk.org>; Tue, 24 Feb 2015 04:11:05 +0100 (CET) Received: by mail-wi0-f171.google.com with SMTP id ex7so1819671wid.4 for <dev@dpdk.org>; Mon, 23 Feb 2015 19:11:05 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=0STIw/38UBkcO2wyFafQRPnbsJoQUjXDo9EZgK5qA8s=; b=ERIwPcwipioMzeA2Eba1NngD4D1mmIZPyi+IehxhHW9ffxTGymuSwgymb9YDt3fpS0 xWx2fB9NRxwpdNygOdAN8GYw2jsDO9FgFKVd7/zDAc0PdamLlj3f8i3bq+sAuxVq8doQ aJee2no5s3040MD2W7JOrtDabTxU/dusZRBEnz4ErpZ9q5UbM76jq292Iqijhvm3RGsW hk6RmMosWR3Mmmdz9iyBMIcWf9ZdS3tkJrN/cMeaMBusZacQD7k0gIGIRAlmO2kbvZHr FSUqB0aWfyI0qCx/8aszI3DxoTzt+Z0g84Uf7TnJuLUaBcPdKFuplNZIy3QYvuMuk4I7 0Wcg== X-Gm-Message-State: ALoCoQnZXPEFTJhp1KSSUdFW6SBDfq9UlE0pwDZNxuMFmVaeMqgP5278odE5Vmo70zVA+0rV9i6g X-Received: by 10.194.24.103 with SMTP id t7mr27662448wjf.15.1424747465668; Mon, 23 Feb 2015 19:11:05 -0800 (PST) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by mx.google.com with ESMTPSA id hm6sm58169950wjb.32.2015.02.23.19.11.04 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 23 Feb 2015 19:11:04 -0800 (PST) From: Thomas Monjalon <thomas.monjalon@6wind.com> To: Yerden Zhumabekov <e_zhumabekov@sts.kz> Date: Tue, 24 Feb 2015 04:10:34 +0100 Message-ID: <2004494.FgxmON1ogB@xps13> Organization: 6WIND User-Agent: KMail/4.14.4 (Linux/3.18.4-1-ARCH; KDE/4.14.4; x86_64; ; ) In-Reply-To: <54EBE934.8080707@sts.kz> References: <1409724351-23786-1-git-send-email-e_zhumabekov@sts.kz> <2302266.QHkfKt2YM8@xps13> <54EBE934.8080707@sts.kz> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v6 0/7] rte_hash_crc reworked to be platform-independent X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK <dev.dpdk.org> List-Unsubscribe: <http://dpdk.org/ml/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://dpdk.org/ml/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <http://dpdk.org/ml/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Tue, 24 Feb 2015 03:11:06 -0000 2015-02-24 09:00, Yerden Zhumabekov: >=20 > 23.02.2015 23:36, Thomas Monjalon =D0=BF=D0=B8=D1=88=D0=B5=D1=82: > > 2015-02-19 15:21, Bruce Richardson: > >> Confirmed, this worked for me too. > >> Looking at the patches, they look good. However, one thing I think= we are missing > >> is a unit test to verify that all our CRC implementations give the= same result. > >> That would be useful as a sanity check of the software fallback es= pecially. The > >> existing hash tests, test the hash table implementation rather tha= n the > >> mathematical argorithm used to compute the hash values. > >> > >> Overall, though, software fallback for CRC is something well worth= while having. > >> > >> Series Acked-by: Bruce Richardson <bruce.richardson@intel.com> > > Applied, thanks > > > > Note: running doxygen compilation helped me to find and fix a small= > > mismatch (parameter alg was flag in comment). >=20 > Thanks, Bruce, Thomas. >=20 > As for yielding the same hash value, I made a test which runs every > CRC32 implementation across a number of randomly generated data sets.= > Results are equal on my trial run. >=20 > I can post a patch for test_hash.c a bit later if this kind of check > suffices. Yes, seems interesting. Thanks