From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id 0AD5F5F72 for ; Tue, 15 Jan 2019 01:03:40 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 5739F2888D; Mon, 14 Jan 2019 19:03:39 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Mon, 14 Jan 2019 19:03:39 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=CPbOGMCcs40EpNMOkyoKnqaJw3XcUkSt7CT7OVhPo3g=; b=CfgHs0enj7PB IjnVsAEkMTAgMGUoCa6pVXlgklfGguKnFAjB0Ww7zIFRR6qDptxqnyEV4JElRkJ4 j9gO4efu3Ye+8WUL/OLdF0jaiK1k66OUowO6kmnecAKFb0PdozYjAOjfK1il9vJ8 6zb51BdZGiXDYKSI3fqf790733A3jQY= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=CPbOGMCcs40EpNMOkyoKnqaJw3XcUkSt7CT7OVhPo 3g=; b=C/1qRg6wvWkLvNx+zE4cIg5SQcfz6DYdr0Am2mIRCbQtr/mh5UTa9dMkC rnUitxFPbdk630IiYhw89r4a/nu8K0fY+xmECByJDO05KM3dpBjlh4EN5BG6e4wW JwikAFBou2lGMLyrxIKPMz1oFNkpMpYa9NMd3MTyv6CmageUsWjSGMVE5fnkjGRk ezYt8eaNZ77zS/QZakXOci8JU9osK3+z+sq+fvnbT5XKwSP6BKemdue9/0y+N+UR Ip8EmpbJF1owxjhwLs2DNwUGhHYpi3WF8RZfX920Hk4Mf42X6am0fbmP6jfFZQba A/lJSLUzjGHt/EiMaT5z9xLO6ht3w== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedtledrgedvgdduhecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfhuthenuceurghilhhouhhtmecufedt tdenucenucfjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvf hhohhmrghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvght qeenucffohhmrghinhepughpughkrdhorhhgnecukfhppeejjedrudefgedrvddtfedrud ekgeenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhhonhdr nhgvthenucevlhhushhtvghrufhiiigvpedt X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id D7859E4663; Mon, 14 Jan 2019 19:03:37 -0500 (EST) From: Thomas Monjalon To: AndyPei Cc: dev@dpdk.org, rosen.xu@intel.com, tianfei.zhang@intel.com Date: Tue, 15 Jan 2019 01:03:36 +0100 Message-ID: <2005571.rmhIWEJz30@xps> In-Reply-To: <1545746524-116580-1-git-send-email-andy.pei@intel.com> References: <1545161721-382282-1-git-send-email-andy.pei@intel.com> <1545746524-116580-1-git-send-email-andy.pei@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v3]/driver/raw/ifpga_rawdev: fix a memory leak bug in ifpga X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 15 Jan 2019 00:03:40 -0000 Hi Andy, I comment here for all your patches (4 are pending). They are your first patches for DPDK, welcome! You may want to read the guides explaining how to contribute: http://doc.dpdk.org/guides/contributing/patches.html The title should be "raw/ifpga: fix memory leak in [area here]" 25/12/2018 15:02, AndyPei: > When ifpga_rawdev_create() allocate memory for a new rawdev, the original code > allocate redundant memory for adapter, which is a member of the rawdev. > What is actually necessary is the adapter to be initialized, not memory allocated. > > What is different in v3 from v2 is that the adapter is no longer need to be freed. The changelog is better located after --- below. > fixes:ef1e8ede3da5 > cc: rosen.xu@intel.com > cc: tianfei.zhang@intel.com The format should be a bit different. Please use git log -1 --abbrev=12 --format='Fixes: %h (\"%s\")%nCc: %ae' and check with devtools/check-git-log.sh > Signed-off-by: AndyPei Should there be a space in your name as "Andy Pei"? [...] > /** > - * opae_adapter_data_alloc - alloc opae_adapter_data data structure > + * opae_adapter_init - init opae_adapter data structure > + * @adpdate: pointer of opae_adater data structure > + * @name: adapter name. > + * @data: private data of this adapter. The doxygen format is @param param_name param_description. It is also important to strictly match the name of the parameter. @adpdate is a typo (should be @param adapter). You can build the doc with "make doc-api-html" and check the result in your browser. > + * > + * Return: 0 on success. > + */ > +int opae_adapter_init(struct opae_adapter *adapter, > + const char *name, void *data)