Re: [dpdk-dev] [PATCH v2 1/3] ether: Add API to support setting TX rate for queue and VF

[Thomas Monjalon <thomas.monjalon@6wind.com>]

Hi Changchun,

2014-06-05 03:30, Ouyang, Changchun:
> As we can see below, There are already 4 existing functions for vf in the header file:
> rte_ethdev.h:int rte_eth_dev_set_vf_rxmode(uint8_t port, uint16_t vf, uint16_t rx_mode,
> rte_ethdev.h:rte_eth_dev_set_vf_tx(uint8_t port,uint16_t vf, uint8_t on);
> rte_ethdev.h:rte_eth_dev_set_vf_rx(uint8_t port,uint16_t vf, uint8_t on);
> rte_ethdev.h:rte_eth_dev_set_vf_vlan_filter(uint8_t port, uint16_t vlan_id,
> 
> So do we have plan to move them or remove them as they are all for VF specifically?

I'm not very happy with these functions. I feel it's too specific because
only related to igb/ixgbe features.
We should try to isolate these things elsewhere. The ethdev API should be generic.
It's not the right time to debate about this but I'd like to have such cleanup in roadmap.

> If no, why we can accept those functions, but not accept the rte_eth_set_vf_rate_limit? :-)

Let's accept it while thinking together to a future nice cleanup.

-- 
Thomas