From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wg0-f51.google.com (mail-wg0-f51.google.com [74.125.82.51]) by dpdk.org (Postfix) with ESMTP id 3C3C8B0A9 for ; Wed, 11 Jun 2014 01:02:12 +0200 (CEST) Received: by mail-wg0-f51.google.com with SMTP id x12so5304171wgg.34 for ; Tue, 10 Jun 2014 16:02:26 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=rrQSuEOXFHtNZ8Po5UllTTNa3YnSniCwrlSLb8t50/U=; b=HPthRPi/t2hOyEb9JqaBszRh5ncHsfXHwF5BF9TH7UBrWeDYFj3aBwgucO+vDXpfaE sq7JqRJcM4wyMqgffSRO/shEaVRPZQ6fbeZAaB1EWDyZO1OGIHSbm068MQsOFjnywKfx fjA7HPVrUFE6XuA7xXAVllt3rKOKmTUAsBuLAKAHUoG8m65fGdiW/Ry8MvINX4GnSok+ jtNXeF/muqWpo3GyeD/lwcv3TBZbdnr+AXHqARtOYi2u3mjeDXdZGeCtef1cmoUQV9th uH06W/dCmAji/UQYylPck+my/ampBqk7UcCWcYvVLeZIKxZCG7OJSI2Edzs6hC5IabfA jhEA== X-Gm-Message-State: ALoCoQlE29Z/ZsvIF58I35RkNTCg9kO2/oTVwcCTjT8R6ckpt5zJN5KyQSVx3fu30xaA6WQba6IC X-Received: by 10.194.63.196 with SMTP id i4mr46280284wjs.50.1402441346792; Tue, 10 Jun 2014 16:02:26 -0700 (PDT) Received: from xps13.localnet (ip-96.net-80-236-123.rev.numericable.fr. [80.236.123.96]) by mx.google.com with ESMTPSA id kp5sm31524159wjb.30.2014.06.10.16.02.25 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 10 Jun 2014 16:02:26 -0700 (PDT) From: Thomas Monjalon To: "Ouyang, Changchun" Date: Wed, 11 Jun 2014 01:02:26 +0200 Message-ID: <2006926.ZSHy59qidU@xps13> Organization: 6WIND User-Agent: KMail/4.13.1 (Linux/3.14.4-1-ARCH; KDE/4.13.1; x86_64; ; ) In-Reply-To: References: <1401090331-18455-1-git-send-email-changchun.ouyang@intel.com> <2115230.WNnKFPWGt0@xps13> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v2 1/3] ether: Add API to support setting TX rate for queue and VF X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 10 Jun 2014 23:02:12 -0000 Hi Changchun, 2014-06-05 03:30, Ouyang, Changchun: > As we can see below, There are already 4 existing functions for vf in the header file: > rte_ethdev.h:int rte_eth_dev_set_vf_rxmode(uint8_t port, uint16_t vf, uint16_t rx_mode, > rte_ethdev.h:rte_eth_dev_set_vf_tx(uint8_t port,uint16_t vf, uint8_t on); > rte_ethdev.h:rte_eth_dev_set_vf_rx(uint8_t port,uint16_t vf, uint8_t on); > rte_ethdev.h:rte_eth_dev_set_vf_vlan_filter(uint8_t port, uint16_t vlan_id, > > So do we have plan to move them or remove them as they are all for VF specifically? I'm not very happy with these functions. I feel it's too specific because only related to igb/ixgbe features. We should try to isolate these things elsewhere. The ethdev API should be generic. It's not the right time to debate about this but I'd like to have such cleanup in roadmap. > If no, why we can accept those functions, but not accept the rte_eth_set_vf_rate_limit? :-) Let's accept it while thinking together to a future nice cleanup. -- Thomas