From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 05C36A04FF;
	Thu,  5 May 2022 18:29:15 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id EB04542827;
	Thu,  5 May 2022 18:29:14 +0200 (CEST)
Received: from NAM04-BN8-obe.outbound.protection.outlook.com
 (mail-bn8nam08on2089.outbound.protection.outlook.com [40.107.100.89])
 by mails.dpdk.org (Postfix) with ESMTP id D1C7941145
 for <dev@dpdk.org>; Thu,  5 May 2022 18:29:13 +0200 (CEST)
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=gDgn8BgJAgXch9daqjllV2+9FUnDqYOyVrqjvgdB8N2LETB2j4s8iY6b6M2jGODpAnZsjFbD4YHqu12rMNX+3A3P4VSEdf3P2MkDkbvS9N9rO0x/xj8eGk/bpjPGP5farzMAuJVE7Dc4RkdQqKEV7vaBJFEUGO9kNqNqzsVbp82Wy5b2WGoPZQefGm352hZ3LHe8E6azQnG4Bn/fuVobbNbDPnEiuyUACwj/qZGdWTuNjquGspoh/GTQ5Ui1752antTJ24bLZi0D07M2WFhz3ruqEvOON7rZotpO6dseeK7TxLF/S8zrlQBHcG9JufElf9+f3kSTp5PXEcZLF05qgA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; 
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=4wrvjK8Hc23/qyLSm+0BzRGzldEJSl5GIIpeNWM3whc=;
 b=bgrB28LIukdHSYOWTvThK9M97vA1Tf02ce/pXG0axHrfVmqmUHYDVqNMlQP/9YFMU/FRmizfFQkIwIg9tfv9ulm/Nra7JMSmU+Svps5NZrqMa2w0TIcvbC6VXNIt++PHUq9KxPQCzWx9IHBgrWo/imCbVkdO7ZVEaSoZf0Tn9iignPuXHkQYQ7qcfdD25TfA9lZqlXoJb2ei1E9TEoYfadMHVsAXmiK6xvpwbWTNj+Pvg07nvF/aHkkKIlon9S7kNTadK7JrThtyNBD57CTokGXPEZyiCamIeUI8FpcQlei80Gwne65mKcW4dMxtGREa40Oge4Wyjf/cYQe1aA2rqA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is
 149.199.80.198) smtp.rcpttodomain=chelsio.com smtp.mailfrom=xilinx.com;
 dmarc=pass (p=none sp=none pct=100) action=none header.from=xilinx.com;
 dkim=none (message not signed); arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=xilinx.onmicrosoft.com; s=selector2-xilinx-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=4wrvjK8Hc23/qyLSm+0BzRGzldEJSl5GIIpeNWM3whc=;
 b=lJ6mr+bp2yN06oncpmjvznHI/IPtl5HuFOCPtlOj27GOO1vlJ3cxS662kDBgvqa/2OfyQ0ivJUTY0EglsVNtikQyAtZIIw4rICzr0C9L8XyL+GY/gncSPHOg9TJ7vCspweBud/74acQKawtRHNI3qARhoAzEkBX+R8MP/YIQMKE=
Received: from DS7PR03CA0355.namprd03.prod.outlook.com (2603:10b6:8:55::30) by
 BY5PR02MB6642.namprd02.prod.outlook.com (2603:10b6:a03:20c::23) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.24; Thu, 5 May
 2022 16:29:10 +0000
Received: from DM3NAM02FT013.eop-nam02.prod.protection.outlook.com
 (2603:10b6:8:55:cafe::e1) by DS7PR03CA0355.outlook.office365.com
 (2603:10b6:8:55::30) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.13 via Frontend
 Transport; Thu, 5 May 2022 16:29:10 +0000
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 149.199.80.198)
 smtp.mailfrom=xilinx.com; dkim=none (message not signed)
 header.d=none;dmarc=pass action=none header.from=xilinx.com;
Received-SPF: Pass (protection.outlook.com: domain of xilinx.com designates
 149.199.80.198 as permitted sender) receiver=protection.outlook.com;
 client-ip=149.199.80.198; helo=xir-pvapexch02.xlnx.xilinx.com;
Received: from xir-pvapexch02.xlnx.xilinx.com (149.199.80.198) by
 DM3NAM02FT013.mail.protection.outlook.com (10.13.5.126) with Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.20.5227.15 via Frontend Transport; Thu, 5 May 2022 16:29:09 +0000
Received: from xir-pvapexch02.xlnx.xilinx.com (172.21.17.17) by
 xir-pvapexch02.xlnx.xilinx.com (172.21.17.17) with Microsoft SMTP Server
 (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.1.2176.14; Thu, 5 May 2022 17:29:04 +0100
Received: from smtp.xilinx.com (172.21.105.197) by
 xir-pvapexch02.xlnx.xilinx.com (172.21.17.17) with Microsoft SMTP Server id
 15.1.2176.14 via Frontend Transport; Thu, 5 May 2022 17:29:04 +0100
Envelope-to: rahul.lakkireddy@chelsio.com,
 dev@dpdk.org
Received: from [10.71.119.95] (port=45949)
 by smtp.xilinx.com with esmtp (Exim 4.90)
 (envelope-from <ferruh.yigit@xilinx.com>)
 id 1nmeLg-0000GQ-AS; Thu, 05 May 2022 17:29:04 +0100
Message-ID: <20092a6b-c1f5-4d12-3391-687d648fa0e7@xilinx.com>
Date: Thu, 5 May 2022 17:29:03 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.1
Subject: Re: [PATCH 5/5] net/cxgbe: read firmware configuration file from
 filesystem
Content-Language: en-US
To: Rahul Lakkireddy <rahul.lakkireddy@chelsio.com>, <dev@dpdk.org>
References: <cover.1650297776.git.rahul.lakkireddy@chelsio.com>
 <f795d66bc336eb68d36ad8618c7c86e1cdf346e3.1650297776.git.rahul.lakkireddy@chelsio.com>
From: Ferruh Yigit <ferruh.yigit@xilinx.com>
In-Reply-To: <f795d66bc336eb68d36ad8618c7c86e1cdf346e3.1650297776.git.rahul.lakkireddy@chelsio.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
X-EOPAttributedMessage: 0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 3acc4e96-2646-4cf3-1948-08da2eb46237
X-MS-TrafficTypeDiagnostic: BY5PR02MB6642:EE_
X-Microsoft-Antispam-PRVS: <BY5PR02MB6642B8FD6EDC60406F6B64C0D0C29@BY5PR02MB6642.namprd02.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: kEv+jOtvbUcPcLvrIvlwci8hZLcv4LpXMThmVye3i+r6gA0lDMGqjHZoPPm5Qoowx8pggZUfx7y3oY/sZxk5dZZH5MdwjPQlogG3oDBH2tjgHkSVeT7ydieiBmJ/DgSLf03zBLcZBt5mKyBCxa/e7lNLXoEsLbHu+gs9N9YD1lUdePyE3iizVxcrmIX0740qdbZOs25Vr5HUyd2b+P982s/exdZhCpuRIDY2kviwIGNOFBtv1YtgtBirW613hASfe8r+aJwrjcO/8TU1/yt9yWMckVFOivoyrToUvgeyn1jy02BZHbpoPNp/5Dj2tNQX/hg+yYJuqerffu56UUfSti0kjaxdDffRWyU2Y8OIpnxzSS64rqGTw2Fm+M1vjqjMhkqWd31fVhgGNTOp60clDsg8QY8oG2hAfIM1Zzx1H+M0KMedzHoB8KdnZOTQsNcHsMtLAmDSWmo0OzwaCMiFNQpWznSU/l0yGKsp9xtwtM8SeSFi0vxhyLHxWFpykaxJ2fVxj2U1Kwa5yxysz0ZLapZt7XFkQHiVzhdaCwiUxcdYPjYlZm3hbm4KFFECTGEu7lN6kiqTPTEjoo9zUH5i3pN82fdvLR/HN07v0xvimCy0L0Y3qz96eXbLFNNEOhsg+y8pHG9iPOX8ZGvNmcKQhO14+I9bF+RZc8OFlFgmg7ovXYE4S+XcftvOrHgA7oCBcK4RiIiQq0IJP9006ZGtmJ/+xJ3hSAWMc3RuNPfE1uY=
X-Forefront-Antispam-Report: CIP:149.199.80.198; CTRY:IE; LANG:en; SCL:1; SRV:;
 IPV:CAL; SFV:NSPM; H:xir-pvapexch02.xlnx.xilinx.com;
 PTR:unknown-80-198.xilinx.com; CAT:NONE;
 SFS:(13230001)(4636009)(46966006)(40470700004)(36840700001)(9786002)(8936002)(508600001)(2906002)(8676002)(70206006)(70586007)(5660300002)(316002)(110136005)(7636003)(44832011)(31696002)(4744005)(31686004)(82310400005)(356005)(53546011)(26005)(2616005)(47076005)(40460700003)(336012)(426003)(186003)(36756003)(36860700001)(50156003)(43740500002);
 DIR:OUT; SFP:1101; 
X-OriginatorOrg: xilinx.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 May 2022 16:29:09.6866 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 3acc4e96-2646-4cf3-1948-08da2eb46237
X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c; Ip=[149.199.80.198];
 Helo=[xir-pvapexch02.xlnx.xilinx.com]
X-MS-Exchange-CrossTenant-AuthSource: DM3NAM02FT013.eop-nam02.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR02MB6642
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org

On 4/18/2022 11:24 PM, Rahul Lakkireddy wrote:
> Add support to read firmware configuration file from
> /lib/firmware/cxgb4/ path in the filesystem.
> 

Hi Rahul,

Can you please document the FW config file in the driver documentation?
Please add:
- Path of the config file
- Content of the config file. As far as I can see from the code the 
config file directly sent to the FW, does this mean config file is binary?
- What happens when config file is not found

Also are these values overlap with the devargs that PMD has? If so what 
happens in that case, which one is used, devargs one or config file one?

Previously there was 'cxgbtool' tool to send the config file, is this 
method replacing it? Why not keep using 'cxgbtool'?

Thanks,
ferruh


> Signed-off-by: Rahul Lakkireddy<rahul.lakkireddy@chelsio.com>

<...>