From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by dpdk.org (Postfix) with ESMTP id D1C4B1B3B7 for ; Thu, 12 Oct 2017 22:51:07 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 21210212D8; Thu, 12 Oct 2017 16:51:07 -0400 (EDT) Received: from frontend1 ([10.202.2.160]) by compute1.internal (MEProxy); Thu, 12 Oct 2017 16:51:07 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=Cb+3UIUa/++nGQAA6hNI4ZW/Nu be2g8kc7HOmJQQ0Cc=; b=Lx16mNIpXpXAqbZBNKSNy/Vlj6D7ZzHPImKF4oO52c AonO65+RwXXLkIlBglycjxOvcWkB/zoCq5/4yX55L4P3gToRp7wQJA5gsBFe3bDA 73AYQV1d92DJikox08RVKVNAtEj6fql+qJyZNdT0UZFyHUc6kKFPMCaEEdQU4tz1 k= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=Cb+3UI Ua/++nGQAA6hNI4ZW/Nube2g8kc7HOmJQQ0Cc=; b=sQH/lCkEu9GStzm2ZC1JU8 MZFar+GgkUG1tLneQ9D0MvxBNSYG1oRZwhmgI1bub37+S9nc0nZjwTv7v7h+v3qQ ehNLaZH2i8Ibphg9+MFnU1YSR17TWV1MXD1qzJP3Pd5eyVdK7+ZMm71A5iPqZHl8 maWcm2Q1qxOWNwxbVRaXqrLYdX2RLV4IzoLJhuFelavw//89wbnVNhM2/4geMUCX nBUNWX2DtYAfAS18wNk77QbmX7A+u6uOWh3MN/CpVU1JqvBEWlE6oHrmfCLnPB1w OnV8oZtAFRnttsj3vtHpUNFX8b4xZufmW++aRi3JGKT0x/y8wVPgQlTniXKJSVKg == X-ME-Sender: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id B60297E3DE; Thu, 12 Oct 2017 16:51:06 -0400 (EDT) From: Thomas Monjalon To: Cristian Dumitrescu Cc: dev@dpdk.org Date: Thu, 12 Oct 2017 22:51:05 +0200 Message-ID: <2009950.PBKcGuERrl@xps> In-Reply-To: <1503488186-90047-1-git-send-email-cristian.dumitrescu@intel.com> References: <1503488186-90047-1-git-send-email-cristian.dumitrescu@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH 0/4] meter: add meter configuration profile api X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 12 Oct 2017 20:51:08 -0000 > Cristian Dumitrescu (4): > meter: add meter configuration profile > test: meter autotest update > qos_meter: accommodate meter api changes > deprecation: removed the librte_meter notice > > doc/guides/rel_notes/deprecation.rst | 3 - > examples/qos_meter/main.c | 36 ++++--- > examples/qos_meter/main.h | 32 ++++--- > lib/librte_meter/rte_meter.c | 88 ++++++++++------- > lib/librte_meter/rte_meter.h | 170 ++++++++++++++++++++++----------- > lib/librte_meter/rte_meter_version.map | 8 ++ > test/test/test_meter.c | 138 ++++++++++++++++---------- > 7 files changed, 306 insertions(+), 169 deletions(-) There are too many checkpatches warnings. And there is at least one compilation error with the first patch: test/test/test_meter.c:93:34: fatal error: incompatible pointer types passing 'struct rte_meter_srtcm_params *' to parameter of type 'struct rte_meter_srtcm_profile *' [-Wincompatible-pointer-types] Please try to improve for RC2.