From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-we0-f175.google.com (mail-we0-f175.google.com [74.125.82.175]) by dpdk.org (Postfix) with ESMTP id 701193796 for ; Mon, 23 Mar 2015 15:08:56 +0100 (CET) Received: by weop45 with SMTP id p45so138824817weo.0 for ; Mon, 23 Mar 2015 07:08:56 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=+kcJjYTdPdWJ2triDbyuDNadr86hfmNHJI3t0L1+m3o=; b=Odfeiqjhdgqb7PrQ0w1gKdJ/201uQaN6oxLI7L4OBp4N1p+R3AfQiakDmT70WWw9Xr sRjzdW7ojIUoocH+nnTzj2Hzqk9sn++UceWmZ/pBew2Ym0YJj+286z3WoQSjdr6hTbDI k1WhCs4cCc6aDdGr7ZxxetoAg9rutzMR9huIVrbAKzMqfq9Pa6pCQogPiHdWGIXZv+lM SEA9a5hwMN7iLavqTYwPZ1zeP/bJuR4p9EAWxFw8qdyseFKh6PwZlSMha+5QEKKxhQbx +xqUNxOYLGT/zR9mt6gFd8bxZiNT7U+DUgvv5a+1Gu3D1ly5hhfEcRzQj1ENKpLsUq4b iW3Q== X-Gm-Message-State: ALoCoQmHXkqKNqWpyRrfnXf8gC3xMtoU1X7d7G3USTe+Bm4aHGcnRgbzO6O+B0MOhGnfceUhAAbD X-Received: by 10.180.107.198 with SMTP id he6mr5499509wib.68.1427119736275; Mon, 23 Mar 2015 07:08:56 -0700 (PDT) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by mx.google.com with ESMTPSA id fm10sm11315910wib.7.2015.03.23.07.08.54 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 23 Mar 2015 07:08:55 -0700 (PDT) From: Thomas Monjalon To: konstantin.ananyev@intel.com, helin.zhang@intel.com Date: Mon, 23 Mar 2015 15:08:14 +0100 Message-ID: <2010640.1zJMycB9XT@xps13> Organization: 6WIND User-Agent: KMail/4.14.4 (Linux/3.18.4-1-ARCH; KDE/4.14.4; x86_64; ; ) In-Reply-To: <1421994224-2127-1-git-send-email-stephen@networkplumber.org> References: <1421994224-2127-1-git-send-email-stephen@networkplumber.org> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org, Stephen Hemminger Subject: Re: [dpdk-dev] [PATCH] ixgbe: do not include CRC in Tx byte count X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 23 Mar 2015 14:08:56 -0000 Konstantin, Helin, your review would be appreciate here. Thanks > From: Stephen Hemminger > > The ixgbe driver was including CRC in the transmit packet byte > count, but not for packets received. This was notice when forwarding and > the number of bytes received was greater than the number of bytes transmitted > for the same number of packets. Make the driver behave like other > virtual devices and not include CRC in byte count. Use the same queue > counters already computed and used for Rx. > > Signed-off-by: Stephen Hemminger