From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id 079CE5B20 for ; Mon, 14 Jan 2019 23:45:40 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 87F8C2654B; Mon, 14 Jan 2019 17:45:39 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Mon, 14 Jan 2019 17:45:39 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=CIBFPvRxGDZpJTNdtGkrdBOtgk8yq2gbLQyDk/ipUKg=; b=eeCwG+9ev28d RWHSHBwbS+BQ8uPo6hJ4rBOUUqVnWPZrWQoNauFrsUyxOBKwlKVr+H3Em4YBqwdv cEGrkndChW+gNkhQ0PJGxvObI5Nk0xr8IItLyGrcK//J+RRLGkVy6w14DSRl/jT+ czxJBaWzNRk6C0GnkKGeAafGuH/SsS8= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=CIBFPvRxGDZpJTNdtGkrdBOtgk8yq2gbLQyDk/ipU Kg=; b=WwRPbQ6mrUCQmZ6RRG/5t6wzLUYLmp91YHvimM6CjwU9bQ1OY5JAZC8h2 4ErQjJtVpoBME1FLv7A0mwOQz29MxU12hXCm+VjmjKENpBl854AQigj5r2tqECqm UC9aBORJVJDkMxdMks2SirlRgyQ3xIFwfMpNu5qkXjy5ppU3KkJnPi5ZHH/tP9v4 RwtaWi8nn/8ahR3QSLhjK6GCOe4ZU+7h7YIq2JjzaFd35cpMTu0VZaE5GvYD3FOI jnM/BDzHBsRahGohhAUkDxj5KwTBNRsedV9oCc77ROvElc6o6BNxEH4xIbFCmyxO T2dAUJAb6LxgCstDBCJr2McuAwl3A== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedtledrgedugdduiedvucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfquhhtnecuuegrihhlohhuthemucef tddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjughrpefhvffufffkjg hfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghsucfoohhnjhgrlhhonhcu oehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucfkphepjeejrddufeegrddvtd efrddukeegnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghl ohhnrdhnvghtnecuvehluhhsthgvrhfuihiivgeptd X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 6113F100E5; Mon, 14 Jan 2019 17:45:38 -0500 (EST) From: Thomas Monjalon To: David Hunt Cc: dev@dpdk.org, liang.j.ma@intel.com Date: Mon, 14 Jan 2019 23:45:37 +0100 Message-ID: <2010732.Y0ziD7SgTV@xps> In-Reply-To: <20190108145926.37367-1-david.hunt@intel.com> References: <20190108145926.37367-1-david.hunt@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] lib/power: fix error handling on setting governor X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 14 Jan 2019 22:45:40 -0000 08/01/2019 15:59, David Hunt: > In the power_set_governor_*() functions, we using fputs() on /sys > filesystem. However, we also need to call fflush() to ensure that > the write completes successfully. Otherwise the attempt to set the > power governor fails and the function returns as if it has > succeeded. This patch adds an fflush to ensure that the > write succeeds, otherwise returns an error. > > Fixes: e6c6dc0f96c8 ("power: add p-state driver compatibility") > > Signed-off-by: David Hunt Applied, thanks