From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id 804D1160 for ; Mon, 29 Oct 2018 03:06:22 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 16B4620FE0; Sun, 28 Oct 2018 22:06:22 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Sun, 28 Oct 2018 22:06:22 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=n52JZNIodaI+aA6amXkn3HI8Nxih4fNkcvlXlt+/Ww8=; b=JkteEI1oW9Ry qAZzh1j9FdDxsr/zjPlQMwe982IIf1Sbjtbt2/76YGG6BxQu7gHZy87SpiGGeFIQ YH6GHAUjp4Cjp8TyqUElVgzhJKU9u3Ne0M6LgaqNmuOkhQcJuZLymdbFKMJOwLF4 +zW6hA30EYGismcZLhXNmZiKxHuSGSU= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=n52JZNIodaI+aA6amXkn3HI8Nxih4fNkcvlXlt+/W w8=; b=mPnVETebl8AuQ6vD8W9RxNv56qVqBvMaLM5Sg0HYbrv0YvuIBey+sspcu ETBzBgrrgEk5MGFqljqwjKPoeGnR4KikY2cENzpQIJbvQStuRztpSXfnHHmUbvI8 vQLvXCx+0/lGhXc8rTZOXBeSIRNYppkuegsMfmDsdIouLlkrqCMWhVvbvWQE60ym rL19u/dg8mkK38w7w8vxM7IXKkVyXFH7N+Jb2ZJDwJXm/jTORzDoirgr8JOJ+oDC 2+cQgFAtGFI+lTI0XeWEenBWFGgGfyXsDQnjyaICNnZJCu8MbcB39pArzBJnhdv6 irNrC5FPBuKAk7n4G/4eKN1DR8eeA== X-ME-Sender: X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id C2130102ED; Sun, 28 Oct 2018 22:06:20 -0400 (EDT) From: Thomas Monjalon To: "Varghese, Vipin" Cc: dev@dpdk.org, "Van Haaren, Harry" , "Byrne, Stephen1" Date: Mon, 29 Oct 2018 03:06:27 +0100 Message-ID: <2011444.UUVssWKW1k@xps> In-Reply-To: References: <20181012131403.36566-1-vipin.varghese@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] examples/service_cores: check lcores before test run X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 29 Oct 2018 02:06:22 -0000 17/10/2018 16:57, Van Haaren, Harry: > From: Varghese, Vipin > > > > The service core samples has varied profiles created to run on specified > > lcore count. The patch adds the check before each run, to ensure > > example has sufficent lcores to be added as service cores on given run > > profile. If sufficent cores are not found, the run is skipped with user > > notification. > > > > Signed-off-by: Vipin Varghese > > --- > > The +1 feels weird, but given there's a core offset of 1 above, > this seems like the best solution: > > Acked-by: Harry van Haaren Applied, thanks