From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from wout2-smtp.messagingengine.com (wout2-smtp.messagingengine.com [64.147.123.25]) by dpdk.org (Postfix) with ESMTP id EB7991B3A6 for ; Wed, 30 Jan 2019 13:23:15 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.west.internal (Postfix) with ESMTP id D77C916BA; Wed, 30 Jan 2019 07:23:14 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Wed, 30 Jan 2019 07:23:15 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=W5uFgoRxiB5F9brkkxmLBOJNB6E0moZCf6ayztPWySY=; b=CQN4M2sDkl+3 MrtREb/HpVlOKwImdM9vy6xLzub+4bLamBBcJ91ubI2ra432EyDDC9d8gQDOf+es fwPfA0wwAnokC3yIj1RQPJHRCH+o1pAXwmS+0IpbC0In0+bgCo5lLRzksIMQJlff UXcqdmUaoR7fMYom/NZXkjUuqpqmwBo= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=W5uFgoRxiB5F9brkkxmLBOJNB6E0moZCf6ayztPWy SY=; b=vASbQV7LWY9ImjVJEYr3KQIF61+EipqANGps+E8oN3UEzxVK2JPvJ0h8y YsTe2LUlkh9xqCCf6TdzYghEgux7Po6xlY+Z2987NSKGbo7vpO4KqoVK8g1dxk2d zo+eeUdDWN367Xc+lUZDN48j/g4EdQNwS9EV+lfDk4m7A1tjjl36PJ0kZ7Uvf/he qy3T+A4yw564WIs1AURfAiSJM7W/epT1gwh3MNwuW8NxlhbeiB2Os1NJG4QgPrsE /xqhDyVRyPFheiHHgU0oTv/auTGU/myCt0BLDedt9eefqfjxmGAF81Y4Jaag7ysX 5AnTyK9sX5Za8iMCIBtAjmzIJK8bA== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedtledrjeeggdeflecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfhuthenuceurghilhhouhhtmecufedt tdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujfgurhephffvufffkfgjfh gggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgrshcuofhonhhjrghlohhnuceo thhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecuffhomhgrihhnpegthhgvtghkph grthgthhgvshdrshhhnecukfhppeejjedrudefgedrvddtfedrudekgeenucfrrghrrghm pehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvthenucevlhhush htvghrufhiiigvpedt X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 6633AE41E4; Wed, 30 Jan 2019 07:23:13 -0500 (EST) From: Thomas Monjalon To: Bruce Richardson Cc: Ferruh Yigit , David Marchand , dev@dpdk.org, Qi Zhang Date: Wed, 30 Jan 2019 13:23:11 +0100 Message-ID: <20115951.qhu0p6tsJr@xps> In-Reply-To: <20190130113159.GC157424@bricha3-MOBL.ger.corp.intel.com> References: <20190129153052.38634-1-ferruh.yigit@intel.com> <6481538.UeMWjqPEGc@xps> <20190130113159.GC157424@bricha3-MOBL.ger.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] devtools: check commit log fixes syntax X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 30 Jan 2019 12:23:16 -0000 30/01/2019 12:31, Bruce Richardson: > On Wed, Jan 30, 2019 at 12:27:58PM +0100, Thomas Monjalon wrote: > > 30/01/2019 12:17, Ferruh Yigit: > > > On 1/30/2019 9:58 AM, David Marchand wrote: > > > > The contributing guide does indicate you are supposed to run both > > > > checkpatches.sh and check-git-log.sh. > > > > I am pretty sure I missed this second step in the past.. > > > > > > > > How about calling check-git-log.sh from checkpatches.sh ? > > > > check-git-log.sh does not support patch files as input, so it would need > > > > support for it. > > > > > > That sounds good idea to have single script to run. > > > > It will never be only one script to run. > > There are more scripts in devtools and I plan to add more. > > Some checks can be done only once for a group of commits, > > and will be really too slow if run for each patch when merging a branch. > > > > About check-git-log, some tests cannot be possible outside of a git tree. > > Do you want to run it when checkpatches is run on git tree? > > Wouldn't it be confusing? > > > Possibly, but we can print out a warning when not run, saying > "check-git-log skipped because we are not running on git tree". I think the > benefit of having all checks done by one script is greater than the > downside of a little confusion. OK