From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A77A1A0C55; Wed, 13 Oct 2021 18:53:47 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 91A80410DA; Wed, 13 Oct 2021 18:53:47 +0200 (CEST) Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by mails.dpdk.org (Postfix) with ESMTP id 43E0740E50 for <dev@dpdk.org>; Wed, 13 Oct 2021 18:53:46 +0200 (CEST) Received: from compute6.internal (compute6.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id 79C285C0064; Wed, 13 Oct 2021 12:53:45 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute6.internal (MEProxy); Wed, 13 Oct 2021 12:53:45 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm2; bh= 5K+AMctbfV9886Mep8qizM1TdFGgGSSHCHWmOd1zwws=; b=bfhY83amcOtpd5vr qsOvlVkyjh6Ef7aMI2X+nWgCiov3GT7CkHjooCN8DClXQGiyLngZAyWhEESx2ILw mjDG8i4blkOw9p49h6kJcV3LZw5rmiD2hrHGa+nZ7iz7XERBPCtXQ30XfEUt+hgP QZTD7JEKAV490dBlZCZsL4qnBtz5pX1dM+iKghLRFO7yb7EKE6gXXYlgoHlB3SNK kDTURZlfnwHyFNIw8cP8PBF0k7aOMECDdJiPQiYPUczONfS2ebQdmFdGby4F0ZUV i89riy6qwsB9VpBSpwsmZ7DM75HSA5NOdA44JwOmB/V6WmFBhi1pLMIQh0jxG4cs h105gw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=5K+AMctbfV9886Mep8qizM1TdFGgGSSHCHWmOd1zw ws=; b=UQDWfnfkCEJYVYo726Y4z8Ef179ryhDrBPFLMg2nl/ROMd5tnFVEvMhOC lfR93Lh67XqmDKJ3giLrPV5dad7wOJsOxOT8PjypYlX+T29NXAZZ5dWjEUlu/d8R E73bTCGLS/Kf3CbvBw2869rE02LREXNOnfCM2HhQsiNK/3v2OFh8AoMeHG4cLT0B 4thLknAmIDuLu+lmcfDkrEwRHwTaDMC7fnDrcXnses/X2uMARaifgR4LfkWdLNa9 9WCMKqHu2HGmZtdQio9kEqU2jvT0V1ucCqbojwNitEzTM3J6wYBWIF1udSnsdE1d xHCy5EvtYznQy5t6Qk9/OvAHZ6PJA== X-ME-Sender: <xms:GQ9nYZVRbygVAYefoemBDbXO9DVEB8lpI8f4h1i9p5gA-zO0WsFvpw> <xme:GQ9nYZm2A-6_9olpUyKI9vbT9Z8uIE0UDsSfSsXkx3vj2hz_dxE2grrNpE3OErvqe SjAtlb8IKs-rLAgDA> X-ME-Received: <xmr:GQ9nYVaNDqhnYT6WBsJ-Rt1YLcoQh5wGGjcq9ARbj-rC51KUgOnYG33XZ3o-0Q0DeFTp3m0iwgzezqgyzJ0bTkVTJiPmunA866TJwaSz> X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvtddrvddutddguddtgecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc ggtffrrghtthgvrhhnpedugefgvdefudfftdefgeelgffhueekgfffhfeujedtteeutdej ueeiiedvffegheenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfh hrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: <xmx:GQ9nYcXdWMUErec9haUpjf7d8hhxO5liMvOyrExhM_Nmh5Jp4hlagA> <xmx:GQ9nYTkv9WHRxhnsElyQMXCa5QXuKT77fhDHdaSyiTPg9ptt4Lzi7g> <xmx:GQ9nYZftRHVlseCMxZPGfQJ0GA3LCcwl48bTawQeWC4IYbX2HqmaAQ> <xmx:GQ9nYV53c0s5Io__nW4MayT9gy8DhqNKVd_II87WK3N2N6rMh32lHA> Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 13 Oct 2021 12:53:42 -0400 (EDT) From: Thomas Monjalon <thomas@monjalon.net> To: Aman Kumar <aman.kumar@vvdntech.in> Cc: dev@dpdk.org, rasland@nvidia.com, asafp@nvidia.com, shys@nvidia.com, viacheslavo@nvidia.com, akozyrev@nvidia.com, matan@nvidia.com, anatoly.burakov@intel.com, keesang.song@amd.com Date: Wed, 13 Oct 2021 18:53:40 +0200 Message-ID: <2012249.R8O7gIrz0W@thomas> In-Reply-To: <20210823084411.29592-2-aman.kumar@vvdntech.in> References: <20210823084411.29592-1-aman.kumar@vvdntech.in> <20210823084411.29592-2-aman.kumar@vvdntech.in> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH 2/2] net/mlx5: optimize mprq memcpy for AMD EPYC2 platforms X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> 23/08/2021 10:44, Aman Kumar: > add non temporal load and temporal store for mprq memcpy. > define mlx5_ntload_tstore in meson build configuration to > enable this optimization. This utilizes AMD EPYC2 optimized > rte_memcpy* routines. [...] > +option('mlx5_ntload_tstore', type: 'boolean', value: false, description: > + 'to enable optimized MPRQ in RX datapath') Please don't make it a compilation option. Why isn't it always enabled? There was a comment on the first patch. Do you plan to make a new version?