From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Julien Courtat <julien.courtat@6wind.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] pci: fix probing blacklisted device with RTE_PCI_DRV_MULTIPLE flag
Date: Tue, 16 Apr 2013 17:11:01 +0200 [thread overview]
Message-ID: <201304161711.01205.thomas.monjalon@6wind.com> (raw)
In-Reply-To: <1366101108-14177-1-git-send-email-julien.courtat@6wind.com>
pushed, thanks !
16/04/2013 10:31, Julien Courtat :
> When blacklisting network adapters that share a PCI bus address with multiple
> ports such as Mellanox ConnectX-3 (librte_pmd_mlx4), RTE applications
> enter infinite loops while probing PCI devices.
>
> This commit removes this probe on subsequent instances for blacklisted devices
> that have RTE_PCI_DRV_MULTIPLE set.
>
> Acked-by: Adrien Mazarguil <adrien.mazarguil@6wind.com>
> Signed-off-by: Julien Courtat <julien.courtat@6wind.com>
> ---
> lib/librte_eal/common/eal_common_pci.c | 4 +++-
> 1 files changed, 3 insertions(+), 1 deletions(-)
>
> diff --git a/lib/librte_eal/common/eal_common_pci.c b/lib/librte_eal/common/eal_common_pci.c
> index 3a6ab70..4e1a944 100644
> --- a/lib/librte_eal/common/eal_common_pci.c
> +++ b/lib/librte_eal/common/eal_common_pci.c
> @@ -91,9 +91,11 @@ pci_probe_all_drivers(struct rte_pci_device *dev)
> if (rte_eal_pci_probe_one_driver(dr, dev))
> continue;
> /* initialize subsequent driver instances for this device */
> - if (dr->drv_flags & RTE_PCI_DRV_MULTIPLE)
> + if ((dr->drv_flags & RTE_PCI_DRV_MULTIPLE) &&
> + (!dev->blacklisted)) {
> while (rte_eal_pci_probe_one_driver(dr, dev) == 0)
> ;
> + }
> return 0;
> }
> return -1;
next prev parent reply other threads:[~2013-04-16 15:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-16 8:31 Julien Courtat
2013-04-16 15:11 ` Thomas Monjalon [this message]
2016-08-26 0:33 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201304161711.01205.thomas.monjalon@6wind.com \
--to=thomas.monjalon@6wind.com \
--cc=dev@dpdk.org \
--cc=julien.courtat@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).