From: Adrien Mazarguil <adrien.mazarguil@6wind.com>
To: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] app: fix refcnt in mbuf allocation
Date: Mon, 6 May 2013 15:56:16 +0200 [thread overview]
Message-ID: <20130506135616.GN12221@6wind.com> (raw)
In-Reply-To: <CAAYH+dX-n2vbZh8P-by0Vk-sPn-E+ZSTMx1HJnKiHXgh-5G+wQ@mail.gmail.com>
Hi all (replying below)
On Mon, May 06, 2013 at 09:28:33AM -0400, Han, Dongsu wrote:
> Sounds good. With the two bug fixes I submitted txonly now runs perfectly.
> Thanks!
> -Dongsu
> On May 6, 2013 8:47 AM, "Thomas Monjalon" <thomas.monjalon@6wind.com> wrote:
>
> > Hi Dongsu Han,
> >
> > I think your fix is right.
> > I've just removed tx_mbuf_alloc() and directly called rte_pktmbuf_alloc()
> > instead.
> > Is it OK for you ?
> > Could you also review this (modified) description ?
[...]
While using rte_pktmbuf_alloc() is the correct fix, it's much slower than
__rte_mbuf_raw_alloc() due to the unnecessary call to rte_pktmbuf_reset().
Since testpmd is often used for performance testing, we should consider a
wrapper function calling __rte_mbuf_raw_alloc() directly instead, as in
rte_rxmbuf_alloc() implemented in igb and ixgbe PMDs.
--
Adrien Mazarguil
6WIND
next prev parent reply other threads:[~2013-05-06 13:56 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-02 14:24 [dpdk-dev] suggested patch: testpmd txonly mbuf_alloc does not increment refcnt Han, Dongsu
2013-05-06 12:47 ` [dpdk-dev] [PATCH] app: fix refcnt in mbuf allocation Thomas Monjalon
2013-05-06 13:28 ` Han, Dongsu
2013-05-06 13:56 ` Adrien Mazarguil [this message]
2013-05-06 15:47 ` Han, Dongsu
2013-05-06 16:13 ` [dpdk-dev] " Thomas Monjalon
2013-05-06 16:00 ` [dpdk-dev] [PATCH] " Thomas Monjalon
2013-05-06 16:13 ` Adrien Mazarguil
2013-05-06 16:33 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130506135616.GN12221@6wind.com \
--to=adrien.mazarguil@6wind.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).