From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <adrien.mazarguil@6wind.com>
Received: from mail-wi0-x231.google.com (mail-wi0-x231.google.com
 [IPv6:2a00:1450:400c:c05::231])
 by dpdk.org (Postfix) with ESMTP id 52C244AAA
 for <dev@dpdk.org>; Mon,  6 May 2013 15:56:17 +0200 (CEST)
Received: by mail-wi0-f177.google.com with SMTP id hq12so2567486wib.16
 for <dev@dpdk.org>; Mon, 06 May 2013 06:56:17 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=google.com; s=20120113;
 h=x-received:date:from:to:subject:message-id:references:mime-version
 :content-type:content-disposition:in-reply-to:x-gm-message-state;
 bh=/gKXGYN4pKoCG3dD7YoODWHebQJDGVJT11UZJaPr8Y8=;
 b=HeCA/KZMC9VWXDnB4HlSX6fMtfZ8oJoPInXJ/Z6v7bOsIvfu5NnxP4iwGckGNAvNgl
 bEbNfy1KUAxPvRKGLUo5EB/0tVs3Xql5fsElDF/iRIOD3bwj58sxlQbdom2RTsZ/eI23
 7HnU3SfmnvB8JXDmyRwThhWhJ4nzA/JiL6q61S7qFKFGrSbAcD3X9x/ZZOfyevkodTA4
 tCdhn9PrbsXhOYALW1M4Jbjwr3yhRAofPfw6i+8RxnkYHOAjB565uPKMbukskkPmviYj
 Pdxb/W3pH3RhtHsJl38jO0FNsniCgNPxGptGnvEJU5Fwhf/JaqA1rNwgD606Ivioipwr
 az0Q==
X-Received: by 10.180.108.3 with SMTP id hg3mr8971885wib.17.1367848577249;
 Mon, 06 May 2013 06:56:17 -0700 (PDT)
Received: from 6wind.com (6wind.net2.nerim.net. [213.41.180.237])
 by mx.google.com with ESMTPSA id ge7sm15426765wib.6.2013.05.06.06.56.15
 for <dev@dpdk.org> (version=TLSv1 cipher=RC4-SHA bits=128/128);
 Mon, 06 May 2013 06:56:16 -0700 (PDT)
Date: Mon, 6 May 2013 15:56:16 +0200
From: Adrien Mazarguil <adrien.mazarguil@6wind.com>
To: dev@dpdk.org
Message-ID: <20130506135616.GN12221@6wind.com>
References: <CAAYH+dW3RenDv9=dn0Mtdubp0443OWqAqPYfHjGKfQcjQHNgxg@mail.gmail.com>
 <1367844470-15346-1-git-send-email-thomas.monjalon@6wind.com>
 <CAAYH+dX-n2vbZh8P-by0Vk-sPn-E+ZSTMx1HJnKiHXgh-5G+wQ@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAAYH+dX-n2vbZh8P-by0Vk-sPn-E+ZSTMx1HJnKiHXgh-5G+wQ@mail.gmail.com>
X-Gm-Message-State: ALoCoQmq96Ffzvu0rUfpyrUZd5EEL9i1kr5l/Hhtj0M4nsbwp45z8X8Y9UssgqsgPljautCcKIo2
Subject: Re: [dpdk-dev] [PATCH] app: fix refcnt in mbuf allocation
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Mon, 06 May 2013 13:56:17 -0000

Hi all (replying below)

On Mon, May 06, 2013 at 09:28:33AM -0400, Han, Dongsu wrote:
> Sounds good. With the two bug fixes I submitted txonly now runs perfectly.
> Thanks!
> -Dongsu
> On May 6, 2013 8:47 AM, "Thomas Monjalon" <thomas.monjalon@6wind.com> wrote:
> 
> > Hi Dongsu Han,
> >
> > I think your fix is right.
> > I've just removed tx_mbuf_alloc() and directly called rte_pktmbuf_alloc()
> > instead.
> > Is it OK for you ?
> > Could you also review this (modified) description ?
[...]

While using rte_pktmbuf_alloc() is the correct fix, it's much slower than
__rte_mbuf_raw_alloc() due to the unnecessary call to rte_pktmbuf_reset().

Since testpmd is often used for performance testing, we should consider a
wrapper function calling __rte_mbuf_raw_alloc() directly instead, as in
rte_rxmbuf_alloc() implemented in igb and ixgbe PMDs.

-- 
Adrien Mazarguil
6WIND