From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas.monjalon@6wind.com>
Received: from mail-wg0-x22f.google.com (mail-wg0-x22f.google.com
 [IPv6:2a00:1450:400c:c00::22f])
 by dpdk.org (Postfix) with ESMTP id 1812E684A
 for <dev@dpdk.org>; Fri, 17 May 2013 16:45:58 +0200 (CEST)
Received: by mail-wg0-f47.google.com with SMTP id e11so388959wgh.26
 for <dev@dpdk.org>; Fri, 17 May 2013 07:46:02 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=google.com; s=20120113;
 h=x-received:from:organization:to:subject:date:user-agent:cc
 :references:in-reply-to:mime-version:content-type
 :content-transfer-encoding:message-id:x-gm-message-state;
 bh=ITqnHj/Q9YuksZKHQqKbmKopS94nEAbZepgdVZVxOq0=;
 b=aKSk3il+w8Ti7mteal0NYsrQ/NZvdx4aGDR4xBh6V6pOXePy2wEZOT5Ahk6dCQERXC
 6r0ypLgdglNK15jCGGVq+YexZ99YnbKP9mxothrhWkKV0+oGuKWFKZBZn9Kf17gp7YG/
 BqyoOE8kqUKJC9BVNbqIk0QvvWtDKtlUF8s2MUQkEialaP+HBLG2+J+ZYTRLNrotXdJH
 B6hOJhxJVQCKy029BhDKVRqeiuiRBmgWaehWat2lsHDnPVuqfvcm9Yh78T14C7nFszYu
 e/9L5Mqoh/EfJIUFiYHqfuz4Qz51MUdCjKK73+7p2kKMKzXmlwiAI/ZNa1voprE4kpIo
 +CiQ==
X-Received: by 10.180.79.69 with SMTP id h5mr34450850wix.14.1368801960112;
 Fri, 17 May 2013 07:46:00 -0700 (PDT)
Received: from angus.localnet (6wind.net2.nerim.net. [213.41.180.237])
 by mx.google.com with ESMTPSA id d5sm9966150wic.1.2013.05.17.07.45.58
 for <multiple recipients>
 (version=TLSv1.2 cipher=ECDHE-RSA-RC4-SHA bits=128/128);
 Fri, 17 May 2013 07:45:58 -0700 (PDT)
From: Thomas Monjalon <thomas.monjalon@6wind.com>
Organization: 6WIND
To: Olivier MATZ <olivier.matz@6wind.com>
Date: Fri, 17 May 2013 16:46:00 +0200
User-Agent: KMail/1.13.7 (Linux/3.2.0-4-amd64; KDE/4.8.4; x86_64; ; )
References: <1367940644-13357-1-git-send-email-thomas.monjalon@6wind.com>
 <5195F477.1050501@6wind.com>
In-Reply-To: <5195F477.1050501@6wind.com>
MIME-Version: 1.0
Content-Type: Text/Plain;
  charset="us-ascii"
Content-Transfer-Encoding: 7bit
Message-Id: <201305171646.00572.thomas.monjalon@6wind.com>
X-Gm-Message-State: ALoCoQlSQzAwFY7OWu5h0pIuhBCMMy8DXF7TKX41l3lX0WMz5JfbTO1SkRphYypuhBlMzX2IRMBt
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] lib: set version 1.2.3r2 and more helper
	macros
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 17 May 2013 14:45:59 -0000

17/05/2013 11:12, Olivier MATZ :
> > @@ -75,7 +87,8 @@ rte_version(void) {
> > 
> >  	return RTE_VER_PREFIX" "
> >  	
> >  			RTE_STR(RTE_VER_MAJOR)"."
> >  			RTE_STR(RTE_VER_MINOR)"."
> > 
> > -			RTE_STR(RTE_VER_PATCH_LEVEL);
> > +			RTE_STR(RTE_VER_PATCH_LEVEL)"r"
> > +			RTE_STR(RTE_VER_PATCH_RELEASE);
> > 
> >  }
> 
> In this patch, do you think it could be useful to add
> a #ifdef RTE_VER_PATCH_RELEASE ? The idea is to return
> "1.2.3" if there is no patch release and "1.2.3r4" in
> the dpdk.org case. As a result this patch would be integrable
> in Intel DPDK mainline.

This patch introduce RTE_VER_PATCH_RELEASE so #ifdef RTE_VER_PATCH_RELEASE is 
always true. I don't see why a commercial version of the DPDK would like to 
apply part of this patch.

-- 
Thomas