DPDK patches and discussions
 help / color / mirror / Atom feed
From: Stephen Hemminger <shemminger@vyatta.com>
To: dev@dpdk.org
Subject: [dpdk-dev] [PATCH 3/7] optimize log/panic
Date: Thu, 30 May 2013 10:12:37 -0700	[thread overview]
Message-ID: <20130530171626.884622340@vyatta.com> (raw)
In-Reply-To: <20130530171234.301927271@vyatta.com>

[-- Attachment #1: rte_panic-cold.patch --]
[-- Type: text/plain, Size: 1166 bytes --]

Both logging and calls to panic are never in the critical path.
Use the GCC attribute cold to mark these functions as cold,
which generates more optimised code.

Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>

---
 lib/librte_eal/common/include/rte_debug.h |    1 +
 lib/librte_eal/common/include/rte_log.h   |    1 +
 2 files changed, 2 insertions(+)

--- a/lib/librte_eal/common/include/rte_debug.h	2013-05-29 08:45:38.888471864 -0700
+++ b/lib/librte_eal/common/include/rte_debug.h	2013-05-29 08:49:12.361864834 -0700
@@ -87,6 +87,7 @@ void rte_dump_registers(void);
  * documentation.
  */
 void __rte_panic(const char *funcname , const char *format, ...)
+	__attribute__((cold))
 	__attribute__((noreturn))
 	__attribute__((format(printf, 2, 3)));
 
--- a/lib/librte_eal/common/include/rte_log.h	2013-03-28 08:50:50.234413869 -0700
+++ b/lib/librte_eal/common/include/rte_log.h	2013-05-29 08:49:12.361864834 -0700
@@ -216,6 +216,7 @@ int rte_log_add_in_history(const char *b
  *   - Negative on error.
  */
 int rte_log(uint32_t level, uint32_t logtype, const char *format, ...)
+	__attribute__((cold))
 	__attribute__((format(printf, 3, 4)));
 
 /**

  parent reply	other threads:[~2013-05-30 17:21 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-30 17:12 [dpdk-dev] [PATCH 0/7] Vyatta patches Stephen Hemminger
2013-05-30 17:12 ` [dpdk-dev] [PATCH 1/7] [PATCH 4/8] igb: workaround errata with wthresh on 82576 Stephen Hemminger
2013-06-05 14:22   ` Vincent JARDIN
2013-06-12 10:06     ` [dpdk-dev] [PATCH 1/7] " Thomas Monjalon
2013-05-30 17:12 ` [dpdk-dev] [PATCH 2/7] rte_timer: optimize for empty case Stephen Hemminger
2013-06-05 14:25   ` Vincent JARDIN
2013-06-12 10:07     ` Thomas Monjalon
2013-05-30 17:12 ` Stephen Hemminger [this message]
2013-06-05 14:34   ` [dpdk-dev] [PATCH 3/7] optimize log/panic Vincent JARDIN
2013-06-12 10:09     ` Thomas Monjalon
2013-05-30 17:12 ` [dpdk-dev] [PATCH 4/7] eal: support different modules Stephen Hemminger
2013-06-03  8:58   ` Damien Millescamps
2013-06-03 15:41     ` Stephen Hemminger
2013-06-03 16:36       ` Thomas Monjalon
2013-06-03 17:26         ` Stephen Hemminger
2013-06-04  9:17           ` Damien Millescamps
2013-06-03 16:08     ` Antti Kantee
2013-06-03 16:29       ` Thomas Monjalon
2013-06-03 17:25         ` Stephen Hemminger
2013-06-03 18:40         ` Antti Kantee
2013-05-30 17:12 ` [dpdk-dev] [PATCH 5/7] pci: support multiple PCI regions per device Stephen Hemminger
2013-06-03 16:41   ` Thomas Monjalon
2013-06-05 14:50   ` Damien Millescamps
2013-06-05 15:49     ` Stephen Hemminger
2013-06-05 18:05       ` Damien Millescamps
2013-06-05 21:33         ` Stephen Hemminger
2013-06-18  1:28           ` somnath kotur
2013-07-16  8:53             ` Thomas Monjalon
2013-07-19 16:44               ` Stephen Hemminger
2013-05-30 17:12 ` [dpdk-dev] [PATCH 6/7] igb_uio: pci_block_user_cfg_access is unsafe, remove it Stephen Hemminger
2013-05-30 17:12 ` [dpdk-dev] [PATCH 7/7] eal: add ability to override DPDK syslog parameters Stephen Hemminger
2013-06-05 14:36   ` Vincent JARDIN
2013-06-12 10:18     ` Thomas Monjalon
2013-05-30 22:20 ` [dpdk-dev] [PATCH 0/7] Vyatta patches Thomas Monjalon
2013-05-31  9:29 ` Damien Millescamps
2013-05-31 15:45   ` Stephen Hemminger
2013-05-31 16:44     ` Damien Millescamps
2013-05-31 17:00       ` Stephen Hemminger
2013-06-03 15:22 ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130530171626.884622340@vyatta.com \
    --to=shemminger@vyatta.com \
    --cc=dev@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).