From: Stephen Hemminger <stephen@networkplumber.org>
To: Damien Millescamps <damien.millescamps@6wind.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH 4/7] eal: support different modules
Date: Mon, 3 Jun 2013 08:41:54 -0700 [thread overview]
Message-ID: <20130603084154.70219c8f@nehalam.linuxnetplumber.net> (raw)
In-Reply-To: <51AC5A99.1050207@6wind.com>
On Mon, 03 Jun 2013 10:58:01 +0200
Damien Millescamps <damien.millescamps@6wind.com> wrote:
> comments inlined.
>
> On 05/30/2013 07:12 PM, Stephen Hemminger wrote:
> > An additional change is that failure to detect module should not be fatal,
> > but an error like other EAL setup problems, allowing the application
> > to recover.
> >
> > Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
> >
> > ---
> > app/chkincs/test_pci.c | 3 ++-
> > app/test/test_pci.c | 4 ++--
> > lib/librte_eal/common/include/rte_pci.h | 5 ++---
> > lib/librte_eal/linuxapp/eal/eal_pci.c | 9 ++-------
> > lib/librte_pmd_igb/e1000_ethdev.c | 2 +-
> > lib/librte_pmd_ixgbe/ixgbe_ethdev.c | 4 ++--
> > 6 files changed, 11 insertions(+), 16 deletions(-)
> >
> > --- a/lib/librte_eal/common/include/rte_pci.h 2013-05-29 08:45:38.000000000 -0700
> > +++ b/lib/librte_eal/common/include/rte_pci.h 2013-05-29 09:02:50.000000000 -0700
> > @@ -151,12 +151,11 @@ struct rte_pci_driver {
> > pci_devinit_t *devinit; /**< Device init. function. */
> > struct rte_pci_id *id_table; /**< ID table, NULL terminated. */
> > uint32_t drv_flags; /**< Flags contolling handling of device. */
> > + const char *module_name; /**< Associated kernel module */
>
> You solution only permits for one module to be checked during
> initialization, while the former solution using flags could be easily
> extended to check for more than one module.
> However it is true that there is a problem with this module check since
> it is historically hard-coded for "igb_uio".
>
> Some better solution could be to have a new flag that will check for a
> NULL terminated array of module_name.
>
> > };
> >
> > -/** Device needs igb_uio kernel module */
> > -#define RTE_PCI_DRV_NEED_IGB_UIO 0x0001
> > /** Device driver must be registered several times until failure */
> > -#define RTE_PCI_DRV_MULTIPLE 0x0002
> > +#define RTE_PCI_DRV_MULTIPLE 0x0001
> You are breaking a public API here, and I don't see any technical reason
> to do so. The RTE_PCI_DRV_NEED_IGB_UIO flag could be deprecated, but
> there is no way its value could be recycled into an already existing flag.
>
> >
> > /**
> > * Probe the PCI bus for registered drivers.
> > --- a/lib/librte_eal/linuxapp/eal/eal_pci.c 2013-03-28 08:50:50.000000000 -0700
> > +++ b/lib/librte_eal/linuxapp/eal/eal_pci.c 2013-05-29 09:04:00.000000000 -0700
> > @@ -76,7 +76,7 @@
> > * This code is used to simulate a PCI probe by parsing information in
> > * sysfs. Moreover, when a registered driver matches a device, the
> > * kernel driver currently using it is unloaded and replaced by
> > - * igb_uio module, which is a very minimal userland driver for Intel
> > + * a module, which is a very minimal userland driver for Intel
> > * network card, only providing access to PCI BAR to applications, and
> > * enabling bus master.
> > */
> > @@ -84,8 +84,6 @@
> >
> > #define PROC_MODULES "/proc/modules"
> >
> > -#define IGB_UIO_NAME "igb_uio"
> > -
> > #define UIO_NEWID "/sys/bus/pci/drivers/%s/new_id"
> > #define UIO_BIND "/sys/bus/pci/drivers/%s/bind"
> >
> > @@ -700,12 +698,9 @@ int
> > rte_eal_pci_probe_one_driver(struct rte_pci_driver *dr, struct rte_pci_device *dev)
> > {
> > struct rte_pci_id *id_table;
> > - const char *module_name = NULL;
> > + const char *module_name = dr->module_name;
> > int uio_status = -1;
> >
> > - if (dr->drv_flags & RTE_PCI_DRV_NEED_IGB_UIO)
> > - module_name = IGB_UIO_NAME;
> > -
> > uio_status = pci_uio_check_module(module_name);
> >
> > for (id_table = dr->id_table ; id_table->vendor_id != 0; id_table++) {
> > --- a/lib/librte_pmd_ixgbe/ixgbe_ethdev.c 2013-05-29 08:45:38.000000000 -0700
> > +++ b/lib/librte_pmd_ixgbe/ixgbe_ethdev.c 2013-05-29 16:08:07.544000027 -0700
> > @@ -547,7 +547,7 @@ static struct eth_driver rte_ixgbe_pmd =
> > {
> > .name = "rte_ixgbe_pmd",
> > .id_table = pci_id_ixgbe_map,
> > - .drv_flags = RTE_PCI_DRV_NEED_IGB_UIO,
> > + .module_name = "igb_uio",
> > },
> > .eth_dev_init = eth_ixgbe_dev_init,
> > .dev_private_size = sizeof(struct ixgbe_adapter),
> > @@ -560,7 +560,7 @@ static struct eth_driver rte_ixgbevf_pmd
> > {
> > .name = "rte_ixgbevf_pmd",
> > .id_table = pci_id_ixgbevf_map,
> > - .drv_flags = RTE_PCI_DRV_NEED_IGB_UIO,
> > + .module_name = "igb_uio",
> > },
> > .eth_dev_init = eth_ixgbevf_dev_init,
> > .dev_private_size = sizeof(struct ixgbe_adapter),
> > --- a/app/test/test_pci.c 2013-03-28 08:50:50.000000000 -0700
> > +++ b/app/test/test_pci.c 2013-05-29 16:05:22.881670915 -0700
> > @@ -69,7 +69,7 @@ static int my_driver_init(struct rte_pci
> > struct rte_pci_device *dev);
> >
> > /*
> > - * To test cases where RTE_PCI_DRV_NEED_IGB_UIO is set, and isn't set, two
> > + * To test cases where module_name is set, and isn't set, two
> > * drivers are created (one with IGB devices, the other with IXGBE devices).
> > */
> >
> > @@ -101,7 +101,7 @@ struct rte_pci_driver my_driver = {
> > .name = "test_driver",
> > .devinit = my_driver_init,
> > .id_table = my_driver_id,
> > - .drv_flags = RTE_PCI_DRV_NEED_IGB_UIO,
> > + .module_name = "igb_uio",
> > };
> >
> > struct rte_pci_driver my_driver2 = {
> > --- a/app/chkincs/test_pci.c 2013-03-28 08:50:50.210414181 -0700
> > +++ b/app/chkincs/test_pci.c 2013-05-29 16:07:43.880238599 -0700
> > @@ -64,7 +64,8 @@ struct rte_pci_driver my_driver = {
> > "test_driver",
> > my_driver_init,
> > my_driver_id,
> > - RTE_PCI_DRV_NEED_IGB_UIO,
> > + 0,
> > + "igb_uio",
> > };
> >
> > static int
> > --- a/lib/librte_pmd_igb/e1000_ethdev.c 2013-05-29 08:45:38.888471864 -0700
> > +++ b/lib/librte_pmd_igb/e1000_ethdev.c 2013-05-29 16:04:50.410003570 -0700
> > @@ -336,7 +336,7 @@ static struct eth_driver rte_igb_pmd = {
> > {
> > .name = "rte_igb_pmd",
> > .id_table = pci_id_igb_map,
> > - .drv_flags = RTE_PCI_DRV_NEED_IGB_UIO,
> > + .module_name = "igb_uio",
> > },
> > .eth_dev_init = eth_igb_dev_init,
> > .dev_private_size = sizeof(struct e1000_adapter),
> >
> >
>
It is one module per driver which works quite well.
The code identifies the module to load based on the PCI id.
next prev parent reply other threads:[~2013-06-03 15:41 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-30 17:12 [dpdk-dev] [PATCH 0/7] Vyatta patches Stephen Hemminger
2013-05-30 17:12 ` [dpdk-dev] [PATCH 1/7] [PATCH 4/8] igb: workaround errata with wthresh on 82576 Stephen Hemminger
2013-06-05 14:22 ` Vincent JARDIN
2013-06-12 10:06 ` [dpdk-dev] [PATCH 1/7] " Thomas Monjalon
2013-05-30 17:12 ` [dpdk-dev] [PATCH 2/7] rte_timer: optimize for empty case Stephen Hemminger
2013-06-05 14:25 ` Vincent JARDIN
2013-06-12 10:07 ` Thomas Monjalon
2013-05-30 17:12 ` [dpdk-dev] [PATCH 3/7] optimize log/panic Stephen Hemminger
2013-06-05 14:34 ` Vincent JARDIN
2013-06-12 10:09 ` Thomas Monjalon
2013-05-30 17:12 ` [dpdk-dev] [PATCH 4/7] eal: support different modules Stephen Hemminger
2013-06-03 8:58 ` Damien Millescamps
2013-06-03 15:41 ` Stephen Hemminger [this message]
2013-06-03 16:36 ` Thomas Monjalon
2013-06-03 17:26 ` Stephen Hemminger
2013-06-04 9:17 ` Damien Millescamps
2013-06-03 16:08 ` Antti Kantee
2013-06-03 16:29 ` Thomas Monjalon
2013-06-03 17:25 ` Stephen Hemminger
2013-06-03 18:40 ` Antti Kantee
2013-05-30 17:12 ` [dpdk-dev] [PATCH 5/7] pci: support multiple PCI regions per device Stephen Hemminger
2013-06-03 16:41 ` Thomas Monjalon
2013-06-05 14:50 ` Damien Millescamps
2013-06-05 15:49 ` Stephen Hemminger
2013-06-05 18:05 ` Damien Millescamps
2013-06-05 21:33 ` Stephen Hemminger
2013-06-18 1:28 ` somnath kotur
2013-07-16 8:53 ` Thomas Monjalon
2013-07-19 16:44 ` Stephen Hemminger
2013-05-30 17:12 ` [dpdk-dev] [PATCH 6/7] igb_uio: pci_block_user_cfg_access is unsafe, remove it Stephen Hemminger
2013-05-30 17:12 ` [dpdk-dev] [PATCH 7/7] eal: add ability to override DPDK syslog parameters Stephen Hemminger
2013-06-05 14:36 ` Vincent JARDIN
2013-06-12 10:18 ` Thomas Monjalon
2013-05-30 22:20 ` [dpdk-dev] [PATCH 0/7] Vyatta patches Thomas Monjalon
2013-05-31 9:29 ` Damien Millescamps
2013-05-31 15:45 ` Stephen Hemminger
2013-05-31 16:44 ` Damien Millescamps
2013-05-31 17:00 ` Stephen Hemminger
2013-06-03 15:22 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130603084154.70219c8f@nehalam.linuxnetplumber.net \
--to=stephen@networkplumber.org \
--cc=damien.millescamps@6wind.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).