From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pb0-x22a.google.com (mail-pb0-x22a.google.com [IPv6:2607:f8b0:400e:c01::22a]) by dpdk.org (Postfix) with ESMTP id 3E03A234 for ; Mon, 3 Jun 2013 19:25:11 +0200 (CEST) Received: by mail-pb0-f42.google.com with SMTP id uo1so6035803pbc.15 for ; Mon, 03 Jun 2013 10:25:18 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=date:from:to:cc:subject:message-id:in-reply-to:references:x-mailer :mime-version:content-type:content-transfer-encoding :x-gm-message-state; bh=2g2O9PZptjyXuanFl6OmvJaF1xJFBpTRBkbg0YaBuqI=; b=bBHReZMZQKKfx1pz2ZYOy0S3reR0RiJgSPjLp4hC91jWXlGGR/HZ8Wv2Hxgh0ge3y6 pZbXCuq93CftFgQGw0/8LQIL+8c7oIV2msPnutZtTowPVAi88ZFfDge6PfPLEVODouL8 mG/kj240Jibcs6B6lskU54x6D+0c3pQddhccUCWV3a/ckuvcTYyozVv1VRcIfPTMG00P 5MzYNwhQvod/pBy2rm9vWfrJ0rLstj7LFK7R0xejLl13cx2JGefPPyIHKgAX76iAtGtA 7/ER4lzFkia3cI3Gbyh05jtGs6e+DG/kO+qENdKw3FDYccayDaaN9KVwnF9wcJR7/r6t zAnA== X-Received: by 10.66.159.195 with SMTP id xe3mr25060137pab.49.1370280318419; Mon, 03 Jun 2013 10:25:18 -0700 (PDT) Received: from nehalam.linuxnetplumber.net (static-50-53-71-109.bvtn.or.frontiernet.net. [50.53.71.109]) by mx.google.com with ESMTPSA id ov2sm59811320pbc.34.2013.06.03.10.25.17 for (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Mon, 03 Jun 2013 10:25:18 -0700 (PDT) Date: Mon, 3 Jun 2013 10:25:14 -0700 From: Stephen Hemminger To: Thomas Monjalon Message-ID: <20130603102514.474dd37b@nehalam.linuxnetplumber.net> In-Reply-To: <201306031829.02984.thomas.monjalon@6wind.com> References: <20130530171234.301927271@vyatta.com> <51AC5A99.1050207@6wind.com> <51ACBF95.1030109@iki.fi> <201306031829.02984.thomas.monjalon@6wind.com> X-Mailer: Claws Mail 3.8.1 (GTK+ 2.24.10; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Gm-Message-State: ALoCoQkfxGvlKKP4iScYN83rTxZPQCzpBA3EpPpCz5WDAfdGCpvQVK5Wzs7vQYtByD/6mwvbFkVL Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH 4/7] eal: support different modules X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 03 Jun 2013 17:25:11 -0000 On Mon, 3 Jun 2013 18:29:02 +0200 Thomas Monjalon wrote: > 03/06/2013 18:08, Antti Kantee : > > On 03.06.2013 10:58, Damien Millescamps wrote: > > >> -/** Device needs igb_uio kernel module */ > > >> -#define RTE_PCI_DRV_NEED_IGB_UIO 0x0001 > > >> > > >> /** Device driver must be registered several times until failure */ > > >> > > >> -#define RTE_PCI_DRV_MULTIPLE 0x0002 > > >> +#define RTE_PCI_DRV_MULTIPLE 0x0001 > > > > > > You are breaking a public API here, and I don't see any technical reason > > > to do so. The RTE_PCI_DRV_NEED_IGB_UIO flag could be deprecated, but > > > there is no way its value could be recycled into an already existing > > > flag. > > > > Is breaking the API a bad thing in this context? IMHO the > > initialization APIs need work before they're general enough and > > perpetually supporting the current ones seems like an unnecessary > > burden. I'm trying to understand the general guidelines of the project. > > > > (and nittily, recycling flag values is fine for static-only libs as long > > as you remove the old macro, but of course removal is the API breakage > > you mentioned) > > Yes, DPDK is a young project but breaking API should be always justified. > In this case it is not mandatory to change it. > This is a source project, there is no fixed ABI.