From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pa0-x232.google.com (mail-pa0-x232.google.com [IPv6:2607:f8b0:400e:c03::232]) by dpdk.org (Postfix) with ESMTP id 8DF46532D for ; Wed, 5 Jun 2013 23:33:34 +0200 (CEST) Received: by mail-pa0-f50.google.com with SMTP id fb1so1258319pad.9 for ; Wed, 05 Jun 2013 14:33:42 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=date:from:to:cc:subject:message-id:in-reply-to:references:x-mailer :mime-version:content-type:content-transfer-encoding :x-gm-message-state; bh=FHUaZW2J8YjWWGU+84yzaCeDzXjwxUAX4DTQ9/zf5E4=; b=gG6QploG7zqijXTtpQjGR7cw9DJ62QGzQqSHzRm9wtP1E7zIt3fQd6LvsCZ8YjMDci ivjirG0Um/tPftGDrVPK99R5Tbdw7peY19GztMIx8s8IQtsLm2jJAFaXZZ2fxNlXplSS 1lV+iQVslXaZZdjY+YS/5iCi3ydUBIW6jkzO7uOW8z804g0qcMxPBqyjEzSFP1FWoFHU XO0JvPEf06NQf/2U9Fw6INBQdQ95TGrZGy3I5V5ZKn0qJqDZ8EQU2ZqydnzC8C0AY8B4 RHjHKlgbvOfnwuh1lGLe9RdpIp+MBiy0uiIi2qYgz2IN48scldBzPgbePehd6Y2A0wkS p0iw== X-Received: by 10.66.150.106 with SMTP id uh10mr36345107pab.118.1370468021894; Wed, 05 Jun 2013 14:33:41 -0700 (PDT) Received: from nehalam.linuxnetplumber.net (static-50-53-71-109.bvtn.or.frontiernet.net. [50.53.71.109]) by mx.google.com with ESMTPSA id bd5sm4981899pac.0.2013.06.05.14.33.40 for (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Wed, 05 Jun 2013 14:33:41 -0700 (PDT) Date: Wed, 5 Jun 2013 14:33:37 -0700 From: Stephen Hemminger To: Damien Millescamps Message-ID: <20130605143337.76af91ff@nehalam.linuxnetplumber.net> In-Reply-To: <51AF7DDB.1070005@6wind.com> References: <20130530171234.301927271@vyatta.com> <20130530171627.005239011@vyatta.com> <51AF501B.5060306@6wind.com> <20130605084927.34f138c1@nehalam.linuxnetplumber.net> <51AF7DDB.1070005@6wind.com> X-Mailer: Claws Mail 3.8.1 (GTK+ 2.24.10; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Gm-Message-State: ALoCoQnTCUd/BYnYUfR+pg2NMi5YfrDsSOb5DZ9Nlv948+XN/6MKVigLt+C7J0KIA+qmgHE1UYSh Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH 5/7] pci: support multiple PCI regions per device X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 05 Jun 2013 21:33:35 -0000 On Wed, 05 Jun 2013 20:05:15 +0200 Damien Millescamps wrote: > On 06/05/2013 05:49 PM, Stephen Hemminger wrote: > > On Wed, 05 Jun 2013 16:50:03 +0200 > > Damien Millescamps wrote: > > > >> Hi Stephen, > >> > >> Overall this patch is very nice. My only comment on this one is why do > >> you limit the max number of memory resources to 5 ? > >> The PCI configuration space permits to store up to 6 base addresses. > >> > >>> +#define PCI_MEM_RESOURCE 5 > >> Please, can you add a log/comment with your patch, too ? > >> > >> > >> Cheers, > > Only because I was trying to save some space, and I didn't see any hardware > > with that many useful regions. Also the kernel UIO driver has some control > > over which regions get exposed. > > I agree that hardware generally don't use that much BAR for the PCIe. > However, this is only a matter of 20 to 24 Bytes, so I don't see any > reason not defining this macro as per the PCI standard value. > > Could you add a commit log and change that so it can be ack'd and pushed > in the DPDK repository ? > > Thanks, Go ahead and change the 5 to a 7. No point in another resend of whole pile.