From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wg0-f41.google.com (mail-wg0-f41.google.com [74.125.82.41]) by dpdk.org (Postfix) with ESMTP id 021175934 for ; Fri, 26 Jul 2013 15:21:09 +0200 (CEST) Received: by mail-wg0-f41.google.com with SMTP id n11so781924wgh.4 for ; Fri, 26 Jul 2013 06:21:32 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=from:organization:to:subject:date:user-agent:cc:references :in-reply-to:mime-version:content-type:content-transfer-encoding :message-id:x-gm-message-state; bh=qER6nhpkZHaDW6KMDhc6iWlC6dNYmD3LYIi3aad58yI=; b=IZrie+kviFyzYcYJpi/Xe498MUEvj2dSnvc9fhhbNXYX6u5jF+tMAQHSZxaUDLI6uC dA7upOqRxaT8kUxQE+uJeiu/sbqGQqoZzdMiSe4sSsqT+JbxViHdoNqF7LnWbNmen/bw lfZGN12qp12dSjwGk60Pq1ieUVOyJ1Zc1kSqRGXW9rtmPdcL/PsHm1Y1YNJkeMQhRq4i WhwPDgnLWUu3OeQTzCKERBTEc42ViV3nN9ul9MWSAHtdlIWtyFtcQLcTUXF/EZaQI8Ix msIvcMnll79+xZ7jPUd2MqvFxMFaYM+cn1eAexF7waEor2tFSS2KYJURrnn/L4oogV5S QR1Q== X-Received: by 10.194.7.137 with SMTP id j9mr35205551wja.11.1374844892893; Fri, 26 Jul 2013 06:21:32 -0700 (PDT) Received: from angus.localnet (6wind.net2.nerim.net. [213.41.180.237]) by mx.google.com with ESMTPSA id b20sm4760846wiw.4.2013.07.26.06.21.31 for (version=TLSv1.2 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Fri, 26 Jul 2013 06:21:32 -0700 (PDT) From: Thomas Monjalon Organization: 6WIND To: Adrien Mazarguil Date: Fri, 26 Jul 2013 15:21:30 +0200 User-Agent: KMail/1.13.7 (Linux/3.2.0-4-amd64; KDE/4.8.4; x86_64; ; ) References: <1374837948-20169-1-git-send-email-adrien.mazarguil@6wind.com> In-Reply-To: <1374837948-20169-1-git-send-email-adrien.mazarguil@6wind.com> MIME-Version: 1.0 Content-Type: Text/Plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Message-Id: <201307261521.30526.thomas.monjalon@6wind.com> X-Gm-Message-State: ALoCoQnSRrKwbhgVO2omf5N3546+Gglhxp1/2HmEa8dSCpBys48qcNNfKJDVRz/cJW7qSpCDW6DS Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH] kni: fix build with kernel < 3.3 with netdev_features_t backport X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 26 Jul 2013 13:21:10 -0000 26/07/2013 13:25, Adrien Mazarguil : > The netdev_features_t typedef appeared in Linux 3.3, but checking the > kernel version isn't enough with some distributions (such as Debian > Wheezy) that backported it into 3.2, causing a compilation failure due to > redefinition. > > Since the presence of a typedef can't be tested at compile time, this > commit adds type kni_netdev_features_t, which, depending on the kernel > version, translates either to u32 or netdev_features_t. > > Signed-off-by: Adrien Mazarguil acked and applied -- Thomas