* [dpdk-dev] [PATCH] mem: remove unneeded log
@ 2013-07-26 14:54 Thomas Monjalon
2013-07-26 15:08 ` Thomas Monjalon
0 siblings, 1 reply; 2+ messages in thread
From: Thomas Monjalon @ 2013-07-26 14:54 UTC (permalink / raw)
To: dev
From: Olivier Matz <olivier.matz@6wind.com>
Remove an error log in memzone_reserve_aligned_thread_unsafe().
It is up to the caller to log the error, and this is already done
in DPDK code (especially in network drivers).
Signed-off-by: Olivier Matz <olivier.matz@6wind.com>
Acked-by: Thomas Monjalon <thomas.monjalon@6wind.com>
---
lib/librte_eal/common/eal_common_memzone.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/lib/librte_eal/common/eal_common_memzone.c b/lib/librte_eal/common/eal_common_memzone.c
index 5532f0d..cd60054 100644
--- a/lib/librte_eal/common/eal_common_memzone.c
+++ b/lib/librte_eal/common/eal_common_memzone.c
@@ -198,9 +198,6 @@ memzone_reserve_aligned_thread_unsafe(const char *name, uint64_t len,
return memzone_reserve_aligned_thread_unsafe(name, len - align,
socket_id, 0, align);
- RTE_LOG(ERR, EAL, "%s(%s, %" PRIu64 ", %d): "
- "No appropriate segment found\n",
- __func__, name, requested_len, socket_id);
rte_errno = ENOMEM;
return NULL;
}
--
1.7.10.4
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [dpdk-dev] [PATCH] mem: remove unneeded log
2013-07-26 14:54 [dpdk-dev] [PATCH] mem: remove unneeded log Thomas Monjalon
@ 2013-07-26 15:08 ` Thomas Monjalon
0 siblings, 0 replies; 2+ messages in thread
From: Thomas Monjalon @ 2013-07-26 15:08 UTC (permalink / raw)
To: dev
26/07/2013 16:54, Thomas Monjalon :
> From: Olivier Matz <olivier.matz@6wind.com>
>
> Remove an error log in memzone_reserve_aligned_thread_unsafe().
> It is up to the caller to log the error, and this is already done
> in DPDK code (especially in network drivers).
>
> Signed-off-by: Olivier Matz <olivier.matz@6wind.com>
> Acked-by: Thomas Monjalon <thomas.monjalon@6wind.com>
> ---
> lib/librte_eal/common/eal_common_memzone.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/lib/librte_eal/common/eal_common_memzone.c
> b/lib/librte_eal/common/eal_common_memzone.c index 5532f0d..cd60054 100644
> --- a/lib/librte_eal/common/eal_common_memzone.c
> +++ b/lib/librte_eal/common/eal_common_memzone.c
> @@ -198,9 +198,6 @@ memzone_reserve_aligned_thread_unsafe(const char *name,
> uint64_t len, return memzone_reserve_aligned_thread_unsafe(name, len -
> align, socket_id, 0, align);
>
> - RTE_LOG(ERR, EAL, "%s(%s, %" PRIu64 ", %d): "
> - "No appropriate segment found\n",
> - __func__, name, requested_len, socket_id);
> rte_errno = ENOMEM;
> return NULL;
> }
pushed
--
Thomas
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-07-26 15:08 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-07-26 14:54 [dpdk-dev] [PATCH] mem: remove unneeded log Thomas Monjalon
2013-07-26 15:08 ` Thomas Monjalon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).