From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas.monjalon@6wind.com>
Received: from mail-wi0-f180.google.com (mail-wi0-f180.google.com
 [209.85.212.180]) by dpdk.org (Postfix) with ESMTP id 465375965
 for <dev@dpdk.org>; Fri, 26 Jul 2013 17:08:03 +0200 (CEST)
Received: by mail-wi0-f180.google.com with SMTP id c10so987745wiw.7
 for <dev@dpdk.org>; Fri, 26 Jul 2013 08:08:26 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=google.com; s=20120113;
 h=from:organization:to:subject:date:user-agent:references:in-reply-to
 :mime-version:content-type:content-transfer-encoding:message-id
 :x-gm-message-state;
 bh=ymqN+jfR3+799qY1PVlsq55URghvT8iYE/8BUkEFG30=;
 b=i0Q/CkTC3DCB87EIkZebuTw1dU8bF9UZjtwn2vWUkJlapTLfmtXjiPpJqaOipviKLs
 FiHp4g1yHzbm6C/275tZ5TYXpm3a5+lYFcQkY+K5M39JFWYmCNly+XcmzIhkW6f8Dc+Z
 excqSX3pnYX4WWvf2wBDklIIEkxeuSLtFOYJKkeUsD9GHVX8YEVqtd4IBmiRGfCkzLfl
 iyEhIPTo40de5hV/DIrlLhYfU93BtuLF5EPIUYZKBxhXfG7SMWxS4EqvPed+LAEICcAE
 g6ZqyBBRQpPCogmeQqTj7qyYBD8k6eOfxthc9nER4y+GIzNES8RdRvPeM9C7e9Xlue2D
 wBaA==
X-Received: by 10.180.38.102 with SMTP id f6mr6055138wik.12.1374851306113;
 Fri, 26 Jul 2013 08:08:26 -0700 (PDT)
Received: from angus.localnet (6wind.net2.nerim.net. [213.41.180.237])
 by mx.google.com with ESMTPSA id u9sm5351580wif.6.2013.07.26.08.08.24
 for <dev@dpdk.org>
 (version=TLSv1.2 cipher=ECDHE-RSA-RC4-SHA bits=128/128);
 Fri, 26 Jul 2013 08:08:25 -0700 (PDT)
From: Thomas Monjalon <thomas.monjalon@6wind.com>
Organization: 6WIND
To: dev@dpdk.org
Date: Fri, 26 Jul 2013 17:08:23 +0200
User-Agent: KMail/1.13.7 (Linux/3.2.0-4-amd64; KDE/4.8.4; x86_64; ; )
References: <1374850483-9104-1-git-send-email-thomas.monjalon@6wind.com>
In-Reply-To: <1374850483-9104-1-git-send-email-thomas.monjalon@6wind.com>
MIME-Version: 1.0
Content-Type: Text/Plain;
  charset="us-ascii"
Content-Transfer-Encoding: 7bit
Message-Id: <201307261708.23631.thomas.monjalon@6wind.com>
X-Gm-Message-State: ALoCoQn/YxoMX5j6U0r3+Pa1/tj8bHA8iY8C4er/YB0kETll7F2BREhFm1LS+3UUqvtlSvMWBPRc
Subject: Re: [dpdk-dev] [PATCH] mem: remove unneeded log
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 26 Jul 2013 15:08:03 -0000

26/07/2013 16:54, Thomas Monjalon :
> From: Olivier Matz <olivier.matz@6wind.com>
> 
> Remove an error log in memzone_reserve_aligned_thread_unsafe().
> It is up to the caller to log the error, and this is already done
> in DPDK code (especially in network drivers).
> 
> Signed-off-by: Olivier Matz <olivier.matz@6wind.com>
> Acked-by: Thomas Monjalon <thomas.monjalon@6wind.com>
> ---
>  lib/librte_eal/common/eal_common_memzone.c |    3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/lib/librte_eal/common/eal_common_memzone.c
> b/lib/librte_eal/common/eal_common_memzone.c index 5532f0d..cd60054 100644
> --- a/lib/librte_eal/common/eal_common_memzone.c
> +++ b/lib/librte_eal/common/eal_common_memzone.c
> @@ -198,9 +198,6 @@ memzone_reserve_aligned_thread_unsafe(const char *name,
> uint64_t len, return memzone_reserve_aligned_thread_unsafe(name, len -
> align, socket_id, 0, align);
> 
> -		RTE_LOG(ERR, EAL, "%s(%s, %" PRIu64 ", %d): "
> -			"No appropriate segment found\n",
> -			__func__, name, requested_len, socket_id);
>  		rte_errno = ENOMEM;
>  		return NULL;
>  	}

pushed

-- 
Thomas