From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-bk0-f53.google.com (mail-bk0-f53.google.com [209.85.214.53]) by dpdk.org (Postfix) with ESMTP id 4E3CB684A for ; Mon, 16 Sep 2013 11:47:56 +0200 (CEST) Received: by mail-bk0-f53.google.com with SMTP id d7so1433810bkh.12 for ; Mon, 16 Sep 2013 02:48:34 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:organization:to:subject:date:user-agent:cc :references:in-reply-to:mime-version:content-type :content-transfer-encoding:message-id; bh=BnNHTsi6jvq4KoxqFMuxr8ZgqgJnVEfmlQHYApvENng=; b=XMypEhedXOLBqk47ZjrkaeObrHJ5J+gy+NpVVC8JX5xpEhegZP3SmzgLfPtfQMNiT1 P3PLyJwKOghD41uZRDLkSHI7r2HsKACQvEzP828BBHu59JL2/tu6Cw+Os7BlQpmoVgmW wN3mcyLtTzakpDX1ibMhs2kIlNb6Q9zU3be27NgX2Bq0yKzBcUvSoxzvMhgbjZOUOZOT Hf5HvSaJT7TKXtIFdi2jTdZx4VnSTA7GmoW5GKXF+hmfXNYQTbI7SpdSMpPVClBkxrKd aum3bMnwyGjZpcewiX/MOcCrhdBCZC37mOouvJWyX7P6JZahtVTVjXoo+ZJbzQnT+63C /nJA== X-Gm-Message-State: ALoCoQkYEiHSXXsXrbYPS9PzXEUJS+nMYxMi46Nl67cZBDGGvPqRnK/CAThj2FHtkbEsrplSRPv5 X-Received: by 10.205.86.199 with SMTP id at7mr23818858bkc.9.1379324914075; Mon, 16 Sep 2013 02:48:34 -0700 (PDT) Received: from angus.localnet (guy78-3-82-239-227-177.fbx.proxad.net. [82.239.227.177]) by mx.google.com with ESMTPSA id nv4sm7066611bkb.3.1969.12.31.16.00.00 (version=TLSv1.2 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Mon, 16 Sep 2013 02:48:33 -0700 (PDT) From: Thomas Monjalon Organization: 6WIND To: Ivan Boule Date: Mon, 16 Sep 2013 11:48:32 +0200 User-Agent: KMail/1.13.7 (Linux/3.2.0-4-amd64; KDE/4.8.4; x86_64; ; ) References: <1379079521-28859-1-git-send-email-thomas.monjalon@6wind.com> <5236D2D7.6000103@6wind.com> In-Reply-To: <5236D2D7.6000103@6wind.com> MIME-Version: 1.0 Content-Type: Text/Plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Message-Id: <201309161148.32510.thomas.monjalon@6wind.com> Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH] ethdev: fix non-reconfigurable pmd init X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 16 Sep 2013 09:47:56 -0000 16/09/2013 11:43, Ivan Boule : > On 09/13/2013 03:38 PM, Thomas Monjalon wrote: > > Some Poll-Mode Drivers (PMD) are not reconfigurable and, > > thus, do not implement (rx|tx)_queue_release functions. > > For these drivers, the functions rte_eth_dev_(rx|tx)_queue_config > > must return an ENOTSUP error only when reconfiguring, > > but not at initial configuration. > > > > Move the FUNC_PTR_OR_ERR_RET check into the case of reconfiguration. > > > > Signed-off-by: Thomas Monjalon > > Acked-by: Ivan Boule pushed, thanks -- Thomas