From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-we0-f182.google.com (mail-we0-f182.google.com [74.125.82.182]) by dpdk.org (Postfix) with ESMTP id 097BB1F3 for ; Wed, 25 Sep 2013 16:46:47 +0200 (CEST) Received: by mail-we0-f182.google.com with SMTP id q59so6132970wes.41 for ; Wed, 25 Sep 2013 07:47:28 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:organization:to:subject:date:user-agent:cc :references:in-reply-to:mime-version:content-type :content-transfer-encoding:message-id; bh=rgYZqwKZQtEPrn+fFJ+q3QOUGKufYRq2E4M/PiGxGE4=; b=JIHmW8LFgF4awZxQYEx1wOiNtDwZFucHP+ldfZHuEfoJEVTx3HYND6NzKbCDxU+A6X Upgg8jFlcfu6igZKRVKYoCoGQOEbkKCQhs81sWKmUnPldkRJHaG88VEYBVeKpkK7uDfR 6b8oRYj/WU4FKr/HJn2dX/K/1G4jJ6holbOFUbZSNJhXDsxgEeFxi7pPNlrXK2Dr2luh LCDpoufjqNiiC70KosSznONJzcLzJuylFxO2atQzG1gb6CxgwxZWjIKCgqjuaG4Lvsqr o+tBWW6HSWre8vCqhjI8I3SR6eEKF8hXGCyLw7Kh+r+BQXMlUDkNk3DJiVR3f+7w5ub4 J1ZA== X-Gm-Message-State: ALoCoQnEwgBC/NddK7JBkGcE/wDbHiFJZxE1+iBs0hxliJRARvouCS7pR9nepcBeDrUTtqmlXhW6 X-Received: by 10.194.109.35 with SMTP id hp3mr1951566wjb.55.1380120448506; Wed, 25 Sep 2013 07:47:28 -0700 (PDT) Received: from angus.localnet (6wind.net2.nerim.net. [213.41.180.237]) by mx.google.com with ESMTPSA id fz8sm18634340wic.0.1969.12.31.16.00.00 (version=TLSv1.2 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Wed, 25 Sep 2013 07:47:27 -0700 (PDT) From: Thomas Monjalon Organization: 6WIND To: jigsaw Date: Wed, 25 Sep 2013 16:47:26 +0200 User-Agent: KMail/1.13.7 (Linux/3.2.0-4-amd64; KDE/4.8.4; x86_64; ; ) References: <1379963780-5044-1-git-send-email-jigsaw@gmail.com> <1FD9B82B8BF2CF418D9A1000154491D973F50C7E@ORSMSX102.amr.corp.intel.com> In-Reply-To: <1FD9B82B8BF2CF418D9A1000154491D973F50C7E@ORSMSX102.amr.corp.intel.com> MIME-Version: 1.0 Content-Type: Text/Plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Message-Id: <201309251647.26757.thomas.monjalon@6wind.com> Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH] Add support for 82599 Tx->Rx loopback operation. X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 25 Sep 2013 14:46:48 -0000 25/09/2013 16:12, Venkatesan, Venky : > I for one would prefer that the changes not really modify any files in the > librte_pmd_ixgbe/ixgbe directory. Those files are derived directly from > the BSD driver baseline, and any changes will make future merges of newer > code more challenging. The changes should be limited to files in the > librte_pmd_ixgbe directory (and ethdev). I agree with Venky. The poll-mode drivers e1000 and ixgbe are based on drivers located in subdirectories e1000/ and ixgbe/. And by design, these poll-mode drivers use the base drivers without modifying it. So please try to restrict your changes to ixgbe_ethdev.c and ixgbe_rxtx.c. The coding rules are not written. If needed, we could add a file for it. Thanks for your patch -- Thomas