[dpdk-dev] [vmxnet3-usermap PATCH] kmod: remove useless debug hack

[dpdk-dev] [vmxnet3-usermap PATCH] kmod: remove useless debug hack

[Thomas Monjalon]

The PCI address was stored in unused variables of the netdev.
It has been introduced in commit 75ab826258c1099e2e56ec48fd17dfa5591111cd.
But it is a useless hack.

Signed-off-by: Thomas Monjalon <thomas.monjalon@6wind.com>
---
 kmod/vmxnet3_drv.c |   12 ------------
 1 file changed, 12 deletions(-)

diff --git a/kmod/vmxnet3_drv.c b/kmod/vmxnet3_drv.c
index 0443ad6..fc51f7e 100644
--- a/kmod/vmxnet3_drv.c
+++ b/kmod/vmxnet3_drv.c
@@ -3928,9 +3928,6 @@ vmxnet3_probe_device(struct pci_dev *pdev,
 	int size;
 	int num_tx_queues = num_tqs[atomic_read(&devices_found)];
 	int num_rx_queues = num_rqs[atomic_read(&devices_found)];
-	/* Parse device address on the PCIe bus. */
-	uint16_t dom = 0;
-	uint8_t bus = 0, dev = 0, func = 0;
 
 #ifdef VMXNET3_RSS
 	if ((atomic_read(&devices_found) < VMXNET3_SHM_MAX_DEVICES &&
@@ -4171,15 +4168,6 @@ vmxnet3_probe_device(struct pci_dev *pdev,
 	vmxnet3_check_link(adapter, FALSE);
 	atomic_inc(&devices_found);
 
-	/* Fill PCIe bus address info. */
-	sscanf(dev_name(adapter->netdev->dev.parent),
-	       "%04hx:%02hhx:%02hhx.%hhd",
-	       &dom, &bus, &dev, &func);
-
-	adapter->netdev->mem_start = (dom<<16)|(bus<<8)|dev;
-	adapter->netdev->mem_end = (dom<<16)|(bus<<8)|dev;
-	adapter->netdev->if_port = func;
-
 	return 0;
 
 err_register:
-- 
1.7.10.4

Re: [dpdk-dev] [vmxnet3-usermap PATCH] kmod: remove useless debug hack

[Damien Millescamps]

On 09/27/2013 05:07 PM, Thomas Monjalon wrote:
> The PCI address was stored in unused variables of the netdev.
> It has been introduced in commit 75ab826258c1099e2e56ec48fd17dfa5591111cd.
> But it is a useless hack.
>
> Signed-off-by: Thomas Monjalon <thomas.monjalon@6wind.com>
> ---
>  kmod/vmxnet3_drv.c |   12 ------------
>  1 file changed, 12 deletions(-)
Ack

Re: [dpdk-dev] [vmxnet3-usermap PATCH] kmod: remove useless debug hack

[Thomas Monjalon]

27/09/2013 17:13, Damien Millescamps :
> On 09/27/2013 05:07 PM, Thomas Monjalon wrote:
> > The PCI address was stored in unused variables of the netdev.
> > It has been introduced in commit
> > 75ab826258c1099e2e56ec48fd17dfa5591111cd. But it is a useless hack.
> > 
> > Signed-off-by: Thomas Monjalon <thomas.monjalon@6wind.com>
> > ---
> > 
> >  kmod/vmxnet3_drv.c |   12 ------------
> >  1 file changed, 12 deletions(-)
> 
> Ack

pushed

-- 
Thomas