From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pb0-f52.google.com (mail-pb0-f52.google.com [209.85.160.52]) by dpdk.org (Postfix) with ESMTP id 35CCD68B9 for ; Fri, 4 Oct 2013 19:39:51 +0200 (CEST) Received: by mail-pb0-f52.google.com with SMTP id wz12so4292553pbc.11 for ; Fri, 04 Oct 2013 10:40:34 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-type:content-transfer-encoding; bh=h1swikz9gtpEVuodo/7dmE079IRPpWCmEbx50lQ5Bb8=; b=jLI/EaHfLFfPnFg6iLNGjpsFHOmOvOKzdQiORWzom8hq/zMBFT4uKI7jrBIrCSde/R HqXBbiJwKanSoYG5X6tux0JzRYIN978AzLm9zEF1wz/ilmtRCylSjhG2gVCBtNZhoMrN KV55JWp/Cov/gdUksuoRSbeYgluGrbeniiIGgu63Fb08DIiBPpOMh7komCg3HEFFYJ+j 3d9OvG7DGXZ+VyEex4nzs9v8ED8Fdj+145YIDxLatRehGGKnAS8sVfToNs6MvmKeo30A qrF2NdXlJNKcfrkpOVizZlZNhOVEMUk20f1/D5RbAg9W2mDSWQo8ZYSZQu6l3NazdHxn QZUg== X-Gm-Message-State: ALoCoQnALM8A7ZUahNKSgw/pHR+U6dhpwmEETKAE8DobsJXgNAwzDBlX/i3SW78eeZrfBUwaUDVR X-Received: by 10.66.169.172 with SMTP id af12mr17205708pac.23.1380908434330; Fri, 04 Oct 2013 10:40:34 -0700 (PDT) Received: from nehalam.linuxnetplumber.net (static-50-53-83-51.bvtn.or.frontiernet.net. [50.53.83.51]) by mx.google.com with ESMTPSA id qf7sm19550263pac.14.1969.12.31.16.00.00 (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Fri, 04 Oct 2013 10:40:34 -0700 (PDT) Date: Fri, 4 Oct 2013 10:40:30 -0700 From: Stephen Hemminger To: Qinglai Xiao Message-ID: <20131004104030.206356dd@nehalam.linuxnetplumber.net> In-Reply-To: <1380906413-3406-1-git-send-email-jigsaw@gmail.com> References: <1380906413-3406-1-git-send-email-jigsaw@gmail.com> X-Mailer: Claws Mail 3.8.1 (GTK+ 2.24.10; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH] Request for comments on ixgbe TSO support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 Oct 2013 17:39:51 -0000 On Fri, 4 Oct 2013 20:06:52 +0300 Qinglai Xiao wrote: > This patch is a draft of TSO on 82599. That is, it is not expected to be > accepted as is. > The problem is where to put the mss field. In this patch, the mss is put in > the union of hash in rte_pktmbuf. It is not the best place, but it is quite > convenient, since hash is not used in TX procedure. > The idea is to avoid increasing sizeof(struct rte_pktmbuf), while keeping mss > easy to access. > > However, the hash is also misleading, coz mss has nothing to do with Rx hash. > A more formal way could be rename hash as below: > > union { > uint32_t data; > struct rx_hash hash; > uint32_t tx_mss; > } misc; > > It is gonna be a major change coz it affects the core data structure. > > Any comments will be appreciated. > > Qinglai Xiao (1): > ixgbe: TCP/UDP segment offload support on 82599. > > lib/librte_mbuf/rte_mbuf.h | 6 +++++- > lib/librte_pmd_ixgbe/ixgbe_rxtx.c | 32 +++++++++++++++++++++++++++++--- > 2 files changed, 34 insertions(+), 4 deletions(-) > This will work for local generated packets but overlapping existing field won't work well for forwarding. What we want to be able to do is to take offload (jumbo) packets in with from virtio (need better driver support which I am doing), and then send them through to network devices.