From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas.monjalon@6wind.com>
Received: from mail-we0-f170.google.com (mail-we0-f170.google.com
 [74.125.82.170]) by dpdk.org (Postfix) with ESMTP id CBFD64BBC
 for <dev@dpdk.org>; Wed, 23 Oct 2013 11:18:17 +0200 (CEST)
Received: by mail-we0-f170.google.com with SMTP id u57so495531wes.15
 for <dev@dpdk.org>; Wed, 23 Oct 2013 02:19:06 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:from:organization:to:subject:date:user-agent:cc
 :references:in-reply-to:mime-version:content-type
 :content-transfer-encoding:message-id;
 bh=Xy2W6RJl3k7ujvPCFc4w/wGcqBYpQc6CPj4+2j6/PfE=;
 b=lcTxom3mLu10carq1N+fzW5l9C3UTniDaDElajwuK6JrXMOjumalcnhLj5t08528De
 p0MnVzYjOIDL7Unx1nZ2u1bxdO36W96DWDPAah0QEkYi73qX0LYDx06djuRtIU/B/aDZ
 /MGU9zw5hVe3LVy2rNhbZ6B/p2uSgpBdFQmEEMsAoVjBOqTJyjExSDRAtwizeAxsiwLv
 bdWDgg+zG8csEzuAuf8ldy0+THMIwVmA8jgsegnhNFyOyIG8LnMIYGAbWI5Ab5+TBg7X
 tz+lPHwX+TkBdE/E5pYIE5cHWprswpbsMbyExkHuCjJfBmHEux1hxGisUd/hlkHU7hVc
 ZLGA==
X-Gm-Message-State: ALoCoQlj2P/Gu79b0/Pc91x0gLFLXrQeztcTWpLjQq5yaAxc4sMto5GppoT3UV7enmEvX2qbyM9d
X-Received: by 10.194.175.66 with SMTP id by2mr566812wjc.59.1382519946852;
 Wed, 23 Oct 2013 02:19:06 -0700 (PDT)
Received: from angus.localnet (6wind.net2.nerim.net. [213.41.180.237])
 by mx.google.com with ESMTPSA id b13sm14833557wic.9.2013.10.23.02.19.05
 for <multiple recipients>
 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
 Wed, 23 Oct 2013 02:19:05 -0700 (PDT)
From: Thomas Monjalon <thomas.monjalon@6wind.com>
Organization: 6WIND
To: Qinglai Xiao <jigsaw@gmail.com>
Date: Wed, 23 Oct 2013 11:19:04 +0200
User-Agent: KMail/1.13.7 (Linux/3.2.0-4-amd64; KDE/4.8.4; x86_64; ; )
References: <1382364674-27098-1-git-send-email-jigsaw@gmail.com>
In-Reply-To: <1382364674-27098-1-git-send-email-jigsaw@gmail.com>
MIME-Version: 1.0
Content-Type: Text/Plain;
  charset="us-ascii"
Content-Transfer-Encoding: 7bit
Message-Id: <201310231119.04536.thomas.monjalon@6wind.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] ixgbe: query assignment of queues to VF
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 23 Oct 2013 09:18:18 -0000

21/10/2013 16:11, Qinglai Xiao :
> Physical Function assignes Tx/Rx queues to each VF according to
> different schemes[1]. By querying through mailbox, VF is able to
> get number of Tx/Rx queues assigned to it.
> 
> Note that current Intel ixgbe driver ixgbe-3.18.7 does not fully
> support mailbox message IXGBE_VF_GET_QUEUES. The service routine
> for IXGBE_VF_GET_QUEUES must be fixed, otherwise PF always return
> 1 as Tx/Rx queue number.
> 
> [1] See section 7.2.1.2.1, 7.1.2.2 and 7.10.2.7.2 of Intel 82599 10
>     Gbe Controller Datasheet.
> 
> Signed-off-by: Qinglai Xiao <jigsaw@gmail.com>

Acked and applied with light modifications:

-	 * Must let PF know we are at mailbox API 11 level.
+	 * Must let PF know we are at mailbox API version 1.1.

> +}
> +
> +
>  /*
>   * Virtual Function device init

Only 1 empty line is sufficient here.

Thanks for your patch.
Please, keep us informed about the needed PF patch.
-- 
Thomas