From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas.monjalon@6wind.com>
Received: from mail-wg0-f42.google.com (mail-wg0-f42.google.com [74.125.82.42])
 by dpdk.org (Postfix) with ESMTP id 909B1156
 for <dev@dpdk.org>; Thu,  7 Nov 2013 11:56:03 +0100 (CET)
Received: by mail-wg0-f42.google.com with SMTP id n12so294903wgh.1
 for <dev@dpdk.org>; Thu, 07 Nov 2013 02:56:57 -0800 (PST)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:from:organization:to:subject:date:user-agent:cc
 :references:in-reply-to:mime-version:content-type
 :content-transfer-encoding:message-id;
 bh=UWTgSoEDjz2llbB4tD0ugw1TM/YEAqChfYAKSiaTy9s=;
 b=KbBfhOoMYpawPGsEAphCUzs9PXZyysUQzQ04Og3U1Ihft1FNU/btbmGubLoeW+KVOm
 w34fPBVtRP+l+JUpJ1mDzHuZTEv1JeHxKlCEd18HEuy2ae8t9fehNTcN/2gV+nRebL+9
 fOIt3HHhT5HlnD5GsCmRl9KAra7JSjQezHgJAKrVy8yhgfzU6gaURzTO8bU9dRK/XP/g
 lLoPsrgfNAEfzMCZAXcFDijK6fOxl7UUNGMzBSX1q4OXr2nKF8Cu0OXhaHKQhpre6abd
 GnZqVUcenpxK8FbhSmxh1t9dwtP6zZXAg7uLVzkt9XTgmQWPGaHVgnAPylO+ILhc1ebr
 IBqA==
X-Gm-Message-State: ALoCoQn7kegcMXcP5s2vCNnUsKMAhG5AxQTKj9m4EcedTLXoib5Tt+PIAJ/edxd1DkNkKUGykVeG
X-Received: by 10.194.1.139 with SMTP id 11mr6682350wjm.33.1383821817271;
 Thu, 07 Nov 2013 02:56:57 -0800 (PST)
Received: from angus.localnet (6wind.net2.nerim.net. [213.41.180.237])
 by mx.google.com with ESMTPSA id td6sm5643536wic.10.2013.11.07.02.56.55
 for <multiple recipients>
 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
 Thu, 07 Nov 2013 02:56:56 -0800 (PST)
From: Thomas Monjalon <thomas.monjalon@6wind.com>
Organization: 6WIND
To: Olivier MATZ <olivier.matz@6wind.com>
Date: Thu, 7 Nov 2013 11:56:53 +0100
User-Agent: KMail/1.13.7 (Linux/3.2.0-4-amd64; KDE/4.8.4; x86_64; ; )
References: <1383650075-30182-1-git-send-email-thomas.monjalon@6wind.com>
 <527B5CFB.9000904@6wind.com>
In-Reply-To: <527B5CFB.9000904@6wind.com>
MIME-Version: 1.0
Content-Type: Text/Plain;
  charset="us-ascii"
Content-Transfer-Encoding: 7bit
Message-Id: <201311071156.53190.thomas.monjalon@6wind.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] doc: fix doxygen parsing of __attribute__
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 07 Nov 2013 10:56:03 -0000

07/11/2013 10:27, Olivier MATZ :
> I think you should provide a pointer to the doxygen documentation
> in the commit log to explain the modification. Maybe this one is
> appropriate:
> http://www.stack.nl/~dimitri/doxygen/manual/preprocessing.html
> 
> About the patch itself, it looks good to me.

Thanks for your comment.

It is pushed.

-- 
Thomas